Mark session defunct on TCP Client side when disconnecting with peer.

The TCP server on receiving a TCPDisconnect from the client marks
the corresponding secure session as defunct.
The TCP client should also mark its session defunct when proactively
closing the connection with peer.

Author: pidarped

src/transport/SessionManager.cpp

@@ -714,27 +714,7 @@ void SessionManager::HandleConnectionClosed(Transport::ActiveTCPConnectionState
 {
     VerifyOrReturn(conn != nullptr);
 
-    // Mark the corresponding secure sessions as defunct
-    mSecureSessions.ForEachSession([&](auto session) {
-        if (session->IsActiveSession() && session->GetTCPConnection() == conn)
-        {
-            SessionHandle handle(*session);
-            // Notify the SessionConnection delegate of the connection
-            // closure.
-            if (mConnDelegate != nullptr)
-            {
-                mConnDelegate->OnTCPConnectionClosed(handle, conErr);
-            }
-
-            // Dis-associate the connection from session by setting it to a
-            // nullptr.
-            session->SetTCPConnection(nullptr);
-            // Mark session as defunct
-            session->MarkAsDefunct();
-        }
-
-        return Loop::Continue;
-    });
+    MarkSecureSessionDefunctForConnection(conn, conErr);
 
     // TODO: A mechanism to mark an unauthenticated session as unusable when
     // the underlying connection is broken. Issue #32323
@@ -785,6 +765,8 @@ void SessionManager::TCPDisconnect(Transport::ActiveTCPConnectionState * conn, b
         conn->mPeerAddr.ToString(peerAddrBuf);
         ChipLogProgress(Inet, "Disconnecting TCP connection from peer at %s.", peerAddrBuf);
         mTransportMgr->TCPDisconnect(conn, shouldAbort);
+
+        MarkSecureSessionDefunctForConnection(conn, CHIP_NO_ERROR);
     }
 }
 #endif // INET_CONFIG_ENABLE_TCP_ENDPOINT
@@ -1336,6 +1318,33 @@ Optional<SessionHandle> SessionManager::FindSecureSessionForNode(ScopedNodeId pe
     return mrpSession != nullptr ? MakeOptional<SessionHandle>(*mrpSession) : Optional<SessionHandle>::Missing();
 }
 
+#if INET_CONFIG_ENABLE_TCP_ENDPOINT
+void SessionManager::MarkSecureSessionDefunctForConnection(Transport::ActiveTCPConnectionState * conn, CHIP_ERROR conErr)
+{
+    // Mark the corresponding secure sessions as defunct
+    mSecureSessions.ForEachSession([&](auto session) {
+        if (session->IsActiveSession() && session->GetTCPConnection() == conn)
+        {
+            SessionHandle handle(*session);
+            // Notify the SessionConnection delegate of the connection
+            // closure.
+            if (mConnDelegate != nullptr)
+            {
+                mConnDelegate->OnTCPConnectionClosed(handle, conErr);
+            }
+
+            // Dis-associate the connection from session by setting it to a
+            // nullptr.
+            session->SetTCPConnection(nullptr);
+            // Mark session as defunct
+            session->MarkAsDefunct();
+        }
+
+        return Loop::Continue;
+    });
+}
+#endif // INET_CONFIG_ENABLE_TCP_ENDPOINT
+
 /**
  * Provides a means to get diagnostic information such as number of sessions.
  */

src/transport/SessionManager.h

@@ -621,6 +621,10 @@ class DLL_EXPORT SessionManager : public TransportMgrDelegate, public FabricTabl
         return payloadHeader.HasMessageType(Protocols::SecureChannel::MsgType::MsgCounterSyncReq) ||
             payloadHeader.HasMessageType(Protocols::SecureChannel::MsgType::MsgCounterSyncRsp);
     }
+
+#if INET_CONFIG_ENABLE_TCP_ENDPOINT
+    void MarkSecureSessionDefunctForConnection(Transport::ActiveTCPConnectionState * conn, CHIP_ERROR conErr);
+#endif // INET_CONFIG_ENABLE_TCP_ENDPOINT
 };
 
 namespace MessagePacketBuffer {