Skip to content

Commit 7091b76

Browse files
bzbarsky-applepimpalemahesh
authored andcommitted
Log attempts to commission a device in Matter.framework. (project-chip#37502)
Also logs the SSID when doing commmissioning onto a Wi-Fi network.
1 parent e91bc70 commit 7091b76

File tree

2 files changed

+14
-0
lines changed

2 files changed

+14
-0
lines changed

src/darwin/Framework/CHIP/MTRCommissioningParameters.mm

+12
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,18 @@ - (void)setFailSafeExpiryTimeoutSecs:(NSNumber * _Nullable)failSafeExpiryTimeout
4545
self.failSafeTimeout = failSafeExpiryTimeoutSecs;
4646
}
4747

48+
- (NSString *)description
49+
{
50+
// SSID is not required to be UTF-8, but almost always is.
51+
NSString * ssidString;
52+
if (self.wifiSSID) {
53+
ssidString = [[NSString alloc] initWithData:self.wifiSSID encoding:NSUTF8StringEncoding];
54+
} else {
55+
ssidString = nil;
56+
}
57+
return [NSString stringWithFormat:@"<MTRCommissioningParameters: %p ssid: %@>", self, ssidString];
58+
}
59+
4860
@end
4961

5062
NS_ASSUME_NONNULL_END

src/darwin/Framework/CHIP/MTRDeviceController_Concrete.mm

+2
Original file line numberDiff line numberDiff line change
@@ -950,6 +950,8 @@ - (BOOL)commissionNodeWithID:(NSNumber *)nodeID
950950
commissioningParams:(MTRCommissioningParameters *)commissioningParams
951951
error:(NSError * __autoreleasing *)error
952952
{
953+
MTR_LOG("%@ trying to commission node with ID 0x%016llX parameters %@", self, nodeID.unsignedLongLongValue, commissioningParams);
954+
953955
if (self.suspended) {
954956
MTR_LOG_ERROR("%@ suspended: can't commission device ID 0x%016llX with parameters %@", self, nodeID.unsignedLongLongValue, commissioningParams);
955957
// TODO: Can we do a better error here?

0 commit comments

Comments
 (0)