Prevent crash when pjsip_inv_verify_request3() return error #4503
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pjsip_inv_verify_request3()
method will initialize the return argument(p_tdata
) to NULLpjproject/pjsip/src/pjsip-ua/sip_inv.c
Line 1268 in 77b3657
So, it might crash here if
pjsip_inv_verify_request3()
returns error andp_tdata
is still not set.pjproject/pjsip/src/pjsua-lib/pjsua_call.c
Lines 1397 to 1399 in 77b3657
This patch will check for the return argument to prevent the crash.