Move jest-dev-server to global (#121)

* Move jest-dev-server to global

* Remove unused variable from PlaywrightEnvironment

Author: mmarkelov

src/PlaywrightEnvironment.ts

@@ -24,21 +24,6 @@ const KEYS = {
   ENTER: '\r',
 }
 
-let teardownServer: (() => Promise<void>) | null = null
-
-const logMessage = ({
-  message,
-  action,
-}: {
-  message: string
-  action: string
-}): void => {
-  console.log('')
-  console.error(message)
-  console.error(`\n☝️ You ${action} in jest-playwright.config.js`)
-  process.exit(1)
-}
-
 const getBrowserPerProcess = async (
   playwrightInstance: GenericBrowser,
   browserType: BrowserType,
@@ -77,7 +62,7 @@ export const getPlaywrightEnv = (basicEnv = 'node') => {
       const config = await readConfig(this._config.rootDir)
       //@ts-ignore
       const browserType = getBrowserType(this._config.browserName)
-      const { context, exitOnPageError, server, selectors } = config
+      const { context, exitOnPageError, selectors } = config
       const playwrightPackage = await readPackage()
       if (playwrightPackage === IMPORT_KIND_PLAYWRIGHT) {
         // eslint-disable-next-line @typescript-eslint/no-var-requires
@@ -98,30 +83,6 @@ export const getPlaywrightEnv = (basicEnv = 'node') => {
       )
       let contextOptions = context
 
-      if (server) {
-        // eslint-disable-next-line @typescript-eslint/no-var-requires
-        const devServer = require('jest-dev-server')
-        const { setup, ERROR_TIMEOUT, ERROR_NO_COMMAND } = devServer
-        teardownServer = devServer.teardown
-        try {
-          await setup(server)
-        } catch (error) {
-          if (error.code === ERROR_TIMEOUT) {
-            logMessage({
-              message: error.message,
-              action: 'can set "server.launchTimeout"',
-            })
-          }
-          if (error.code === ERROR_NO_COMMAND) {
-            logMessage({
-              message: error.message,
-              action: 'must set "server.command"',
-            })
-          }
-          throw error
-        }
-      }
-
       if (device) {
         const { viewport, userAgent } = playwright.devices[device]
         contextOptions = { viewport, userAgent, ...contextOptions }
@@ -192,7 +153,7 @@ export const getPlaywrightEnv = (basicEnv = 'node') => {
       }
     }
 
-    async teardown(jestConfig: JestConfig.InitialOptions = {}): Promise<void> {
+    async teardown(): Promise<void> {
       const { page, browser } = this.global
       if (page) {
         page.removeListener('pageerror', handleError)
@@ -203,10 +164,6 @@ export const getPlaywrightEnv = (basicEnv = 'node') => {
       }
 
       await super.teardown()
-
-      if (!jestConfig.watch && !jestConfig.watchAll && teardownServer) {
-        await teardownServer()
-      }
     }
   }
 }

src/global.ts

@@ -1,6 +1,60 @@
-// TODO Check this global methods
-// eslint-disable-next-line @typescript-eslint/no-empty-function
-export const setup = (): void => {}
+/* eslint-disable no-console */
+import {
+  setup as setupServer,
+  teardown as teardownServer,
+  ERROR_TIMEOUT,
+  ERROR_NO_COMMAND,
+} from 'jest-dev-server'
+import { readConfig } from './utils'
+import type { Config as JestConfig } from '@jest/types'
 
-// eslint-disable-next-line @typescript-eslint/no-empty-function
-export const teardown = (): void => {}
+let didAlreadyRunInWatchMode = false
+
+const logMessage = ({
+  message,
+  action,
+}: {
+  message: string
+  action: string
+}): void => {
+  console.log('')
+  console.error(message)
+  console.error(`\n☝️ You ${action} in jest-playwright.config.js`)
+  process.exit(1)
+}
+
+export async function setup(jestConfig: JestConfig.GlobalConfig) {
+  const config = await readConfig(jestConfig.rootDir)
+
+  // If we are in watch mode, - only setupServer() once.
+  if (jestConfig.watch || jestConfig.watchAll) {
+    if (didAlreadyRunInWatchMode) return
+    didAlreadyRunInWatchMode = true
+  }
+
+  if (config.server) {
+    try {
+      await setupServer(config.server)
+    } catch (error) {
+      if (error.code === ERROR_TIMEOUT) {
+        logMessage({
+          message: error.message,
+          action: 'can set "server.launchTimeout"',
+        })
+      }
+      if (error.code === ERROR_NO_COMMAND) {
+        logMessage({
+          message: error.message,
+          action: 'must set "server.command"',
+        })
+      }
+      throw error
+    }
+  }
+}
+
+export async function teardown(jestConfig: JestConfig.GlobalConfig) {
+  if (!jestConfig.watch && !jestConfig.watchAll) {
+    await teardownServer()
+  }
+}