You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
When used as a library in another C# application, attempting to apply some patches results in an invalid checksum error. Compiling without the checksum validation results in an invalid output file.
To Reproduce
Steps to reproduce the behavior:
Compile the main branch and use the resulting PleOps.XdeltaSharp.dll in a project.
Add the decoder as shown in the example on the README.
Create a vcdiff patch using the latest xdelta3 on any platform, with the flags -f -e -S -s.
Run the program.
View checksum error.
Expected behavior
Patch applies properly.
Exceptions
Screenshots
Using xdelta3 to create a patch. More context provided at the bottom for the strange naming convention.
Using the CLI tool to apply the patch. Works flawlessly.
The snippet of code that is failing. Note that this is run in a for loop that iterates over a list of patch files. It also overwrites the original file.
Desktop:
OS: Windows, macOS, and Linux (Arch)
Version: Main branch
Additional context
I am trying to implement support for VCDIFF patches in HoneyPatcher - a mod installer and file patcher for the PlayStation3 game Sonic the Fighters. It was made in the Godot game engine and uses C# as its primary language.
The game is an internally emulated SEGA Model 2 game - as such the easiest way to do any small code edits is to use patches.
The reason the VCDIFF patches are named oddly is so that HoneyPatcher can use the file extension to identify what file to patch.
Of note, I have been successful in creating and applying several patches. Some could only be created successfully using the Linux version of Xdelta3, and then applied everywhere. Others fail on all platforms. The problem is wildly inconsistent, but I have made sure that my original file(s) is/are clean numerous times.
I have tried multiple versions of Xdelta3, as well as DeltaPatcher with secondary compression disabled.
In DeltaPatcher, removing the checksum from the file results in no error, but also no changes when the patch is applied. This once again works fine with the CLI tool.
Describe the bug
When used as a library in another C# application, attempting to apply some patches results in an invalid checksum error. Compiling without the checksum validation results in an invalid output file.
To Reproduce
Steps to reproduce the behavior:
PleOps.XdeltaSharp.dll
in a project.-f -e -S -s
.Expected behavior
Patch applies properly.
Exceptions
Screenshots
Using xdelta3 to create a patch. More context provided at the bottom for the strange naming convention.
Using the CLI tool to apply the patch. Works flawlessly.
The snippet of code that is failing. Note that this is run in a for loop that iterates over a list of patch files. It also overwrites the original file.
Desktop:
Additional context
The text was updated successfully, but these errors were encountered: