Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scss override after update to 18 #17391

Open
JimTudeski opened this issue Jan 14, 2025 · 2 comments
Open

scss override after update to 18 #17391

JimTudeski opened this issue Jan 14, 2025 · 2 comments
Assignees
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Milestone

Comments

@JimTudeski
Copy link

Is there any way to use the old host-deep style override in version 18? We have a huge project with lot of override but after i update from 17 these aren't working now with the new design tokens.

@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 14, 2025
@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 16, 2025
@mertsincan mertsincan added this to the 19.1.0 milestone Jan 16, 2025
@mertsincan mertsincan self-assigned this Jan 16, 2025
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Jan 16, 2025
@mertsincan
Copy link
Member

Did you make any changes in the style scss? Or did you just override the scss variable?

@JimTudeski
Copy link
Author

yes, neither ":host ::ng-deep ..." override doesn't working with version 18 and this is very big problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
Status: Review
Development

No branches or pull requests

2 participants