Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

Refactor Tx circuit with challenge API #752

Closed
aguzmant103 opened this issue Sep 8, 2022 · 1 comment · Fixed by #803
Closed

Refactor Tx circuit with challenge API #752

aguzmant103 opened this issue Sep 8, 2022 · 1 comment · Fixed by #803
Assignees
@han0110
Milestone
successful-erc20

Comments

@aguzmant103
Copy link
Member

aguzmant103 commented Sep 8, 2022 •
edited
Loading

Using the challenge API instead of the instance value for randomness in Tx circuit

Notes:

  • The randomness will be provided from the super circuit instead of being queried from within the Keccak circuit. This applies to all the sub circuits
  • Treat the randomness as an expression, need a small test.
  • The circuit needs to be divided into 2 phases: one with the commitments that don't use the randomness; and another one that has access to the randomness and commits values that use it (via RLC).
@ed255 ed255 added this to the successful-erc20 milestone Sep 8, 2022
@ed255
Copy link
Member

ed255 commented Sep 13, 2022

Reference example: https://github.com/han0110/halo2/blob/feature%2Fchallenge-api/halo2_proofs/examples/shuffle.rs

@han0110 han0110 self-assigned this Sep 21, 2022
@han0110 han0110 moved this from 📋 Refined Backlog to 🏗 In progress in zkEVM Community Edition Sep 21, 2022
@ed255 ed255 linked a pull request Sep 28, 2022 that will close this issue
Refactor Tx circuit and use challenge api #803
Merged
1 task
@ed255 ed255 moved this from 🏗 In progress to 👀 In review in zkEVM Community Edition Sep 28, 2022
@ed255 ed255 mentioned this issue Sep 29, 2022
Closed
10 tasks
@ed255 ed255 moved this from 👀 In review to ✅ Done in zkEVM Community Edition Oct 4, 2022
lispc added a commit that referenced this issue Aug 28, 2023
@darth-cy @lispc
@kunxian-xia @roynalnaruto
refactor: remove keccak constants from aggregator (#752)
1d190ba 
* add row counting interface for keccak

* add class level capacity calculator for keccak

* remove f capacity from core

* remove capacity calculator in aggregator util

* remove unnecessary imports

* replace max keccak round in core

* replace reference for max keccak

* remove unnecessary keccak imports and constants

* remove max keccak constant

* remove constants in hash cell parsing

* remove constant column sanity check

* add state column usage log

* adjust input bytes column

* add long column padding

* correct fmt

* fix fmt

* minor fixes

* fix

* Fix: allow skipping of L1Msg tx part 2 (calculate num_all_txs in tx circuit) (#778)

* calculate num_l1_msgs and num_l2_txs in tx circuit

* fix

* fmt and clippy

* fix: non-last tx requires next is calldata

* add NumAllTxs in block table and copy it from pi to block table

* add lookup for NumAllTxs in tx circuit

* clippy

* add block num diff check to avoid two real block have same num

* clippy

* address comments

* Fix the bugs in RLP/Tx/PI circuit which are reported by Zellic & KALOS auditors (#572)

* fix finding 3 (#575)

* Fix zellic finding 4 (#576)

* fix finding 3 (#575)

* fix finding 4

---------

Co-authored-by: Rohit Narurkar <rohit.narurkar@protonmail.com>

* add range check on diffs (#586)

* Fix finding 10 (#578)

* fix finding 3 (#575)

* fix finding 10

* Fix finding 13 (#579)

* fix finding 3 (#575)

* fix finding 13

* Fix zellic finding 14 (#580)

* fix finding 3 (#575)

* fix finding 14

* Fix zellic finding 5 (#584)

* fix finding 3 (#575)

* fix finding 5

* refine comments

* fmt

* Fix finding 17 (#602)

* add q_last

* fix

* add more diff range check

* fix finding 7 (#625)

* tx_id = 1 when sm starts

* Fix finding 11 : use length for rlc in rlp table (#719)

* fix: use tag_bytes_rlc and tag_length to copy tag's bytes around

* fix lookup input for Len & RLC & GasCost fields in tx circuit

* refactor

* fix

* refactor

* fix col phase issue

* refactor bytes_rlc type

* Fix the bugs in Tx & PI circuits reported by Zellic & KALOS auditors (#612)

* lookup chain_id to RLP table

* fix finding 22 (#614)

* fix finding 21 (#613)

* fix finding 23 (#618)

* fix finding 26 (#622)

* fix finding 28 (#624)

Co-authored-by: Rohit Narurkar <rohit.narurkar@protonmail.com>

* fix finding 29 (#623)

Co-authored-by: Rohit Narurkar <rohit.narurkar@protonmail.com>

* enforce is_final is true at the last row and fix RLC related vul (#735)

* Fix finding 30  (#733)

* enforce all txs in a block are included in the tx table

* clippy

---------

Co-authored-by: Rohit Narurkar <rohit.narurkar@protonmail.com>

* Fix Zellic / Kalos finding25 (#619)

* fix finding 25

* add comment

---------

Co-authored-by: Rohit Narurkar <rohit.narurkar@protonmail.com>

* fix conflicts

---------

Co-authored-by: Rohit Narurkar <rohit.narurkar@protonmail.com>
Co-authored-by: Zhang Zhuo <mycinbrin@gmail.com>

* use q_first instead

* fmt

---------

Co-authored-by: Rohit Narurkar <rohit.narurkar@protonmail.com>
Co-authored-by: Zhang Zhuo <mycinbrin@gmail.com>

* add pi comments

* rename preimage col idx

* add keccak rows check

* rename input bytes col finder fn

* modify keccak row env constaint

* modify keccak row env constaint

* add named constant setup vars

* modify keccak row check

* clippy advised

* add comments on chunk hash

* fmt

* avoid constant lookup table

* avoid repetitive computation of input_bytes_col_idx

---------

Co-authored-by: Zhuo Zhang <mycinbrin@gmail.com>
Co-authored-by: xkx <xiakunxian130@gmail.com>
Co-authored-by: Rohit Narurkar <rohit.narurkar@protonmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@han0110 han0110

Labels
None yet
Projects
zkEVM Community Edition
Status: ✅ Done
Milestone
successful-erc20
Development

Successfully merging a pull request may close this issue.

Refactor Tx circuit and use challenge api han0110/zkevm-circuits
3 participants
@han0110 @ed255 @aguzmant103