Skip to content

Commit 033863b

Browse files
committed
Add/update comment about global items we add
1 parent f60a021 commit 033863b

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

src/data-model-providers/codegen/CodegenDataModelProvider.cpp

+8-1
Original file line numberDiff line numberDiff line change
@@ -285,11 +285,18 @@ CHIP_ERROR CodegenDataModelProvider::Attributes(const ConcreteClusterPath & path
285285
ReturnErrorOnFailure(builder.Append(AttributeEntryFrom(path, attribute)));
286286
}
287287

288+
289+
// This "GlobalListEntry" is specific for metadata that ember does not include
290+
// in its attribute list metadata.
291+
//
292+
// By spec these Attribute/AcceptedCommands/GeneratedCommants lists are:
293+
// - lists of elements
294+
// - read-only, with read privilege view
295+
// - fixed value (no such flag exists, so this is not a quality flag we set/track)
288296
DataModel::AttributeEntry globalListEntry;
289297

290298
globalListEntry.readPrivilege = Access::Privilege::kView;
291299
globalListEntry.flags.Set(DataModel::AttributeQualityFlags::kListAttribute);
292-
// these entries should also be `Fixed` however no such flag is propagated (we do not track)
293300

294301
for (auto & attribute : GlobalAttributesNotInMetadata)
295302
{

0 commit comments

Comments
 (0)