Skip to content

Commit 060823b

Browse files
committed
Fix incorrect min/max values on energy attributes
1 parent 5d07e62 commit 060823b

File tree

2 files changed

+14
-14
lines changed

2 files changed

+14
-14
lines changed

src/app/zap-templates/zcl/data-model/chip/electrical-energy-measurement-cluster.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -42,12 +42,12 @@ limitations under the License.
4242
<!--Conformance feature IMPE & PERE - for now optional-->
4343
<attribute code="0x0004" side="server" define="PERIODIC_ENERGY_EXPORTED" type="EnergyMeasurementStruct" isNullable="true" optional="true">PeriodicEnergyExported</attribute>
4444
<!--Conformance feature EXPE & PERE - for now optional-->
45-
<event code="0x0000" name="CumulativeEnergyMeasured" priority="info" apiMaturity="provisional" optional="true">
45+
<event code="0x0000" name="CumulativeEnergyMeasured" priority="info" apiMaturity="provisional" optional="true" side="server">
4646
<description>CumulativeEnergyMeasured</description>
4747
<field id="0" name="EnergyImported" type="EnergyMeasurementStruct" optional="true"/>
4848
<field id="1" name="EnergyExported" type="EnergyMeasurementStruct" optional="true"/>
4949
</event>
50-
<event code="0x0001" name="PeriodicEnergyMeasured" priority="info" apiMaturity="provisional" optional="true">
50+
<event code="0x0001" name="PeriodicEnergyMeasured" priority="info" apiMaturity="provisional" optional="true" side="server">
5151
<description>PeriodicEnergyMeasured</description>
5252
<field id="0" name="EnergyImported" type="EnergyMeasurementStruct" optional="true"/>
5353
<field id="1" name="EnergyExported" type="EnergyMeasurementStruct" optional="true"/>

src/app/zap-templates/zcl/data-model/chip/electrical-power-measurement-cluster.xml

+12-12
Original file line numberDiff line numberDiff line change
@@ -38,24 +38,24 @@ limitations under the License.
3838
<attribute code="0x0001" side="server" define="NUMBER_OF_MEASUREMENT_TYPES" type="int8u" min="1">NumberOfMeasurementTypes</attribute>
3939
<attribute code="0x0002" side="server" define="ACCURACY" type="array" entryType="MeasurementAccuracyStruct" minLength="1">Accuracy</attribute>
4040
<attribute code="0x0003" side="server" define="RANGES" type="array" optional="true" entryType="MeasurementRangeStruct" minLength="0">Ranges</attribute>
41-
<attribute code="0x0004" side="server" define="VOLTAGE" type="voltage_mv" isNullable="true" min="-2" max="2" optional="true" default="0x8000000000000000">Voltage</attribute>
41+
<attribute code="0x0004" side="server" define="VOLTAGE" type="voltage_mv" isNullable="true" min="0xC000000000000000" max="0x4000000000000000" optional="true" default="0x8000000000000000">Voltage</attribute>
4242
<!--Conformance feature [ALTC] - for now optional-->
43-
<attribute code="0x0005" side="server" define="ACTIVE_CURRENT" type="amperage_ma" isNullable="true" min="-2" max="2" optional="true" default="0x8000000000000000">ActiveCurrent</attribute>
43+
<attribute code="0x0005" side="server" define="ACTIVE_CURRENT" type="amperage_ma" isNullable="true" min="0xC000000000000000" max="0x4000000000000000" optional="true" default="0x8000000000000000">ActiveCurrent</attribute>
4444
<!--Conformance feature [ALTC] - for now optional-->
45-
<attribute code="0x0006" side="server" define="REACTIVE_CURRENT" type="amperage_ma" isNullable="true" min="-2" max="2" optional="true" default="0x8000000000000000">ReactiveCurrent</attribute>
46-
<attribute code="0x0007" side="server" define="APPARENT_CURRENT" type="amperage_ma" isNullable="true" min="0" max="2" optional="true" default="0x8000000000000000">ApparentCurrent</attribute>
45+
<attribute code="0x0006" side="server" define="REACTIVE_CURRENT" type="amperage_ma" isNullable="true" min="0xC000000000000000" max="0x4000000000000000" optional="true" default="0x8000000000000000">ReactiveCurrent</attribute>
46+
<attribute code="0x0007" side="server" define="APPARENT_CURRENT" type="amperage_ma" isNullable="true" min="0" max="0x4000000000000000" optional="true" default="0x8000000000000000">ApparentCurrent</attribute>
4747
<!--Conformance feature [ALTC] - for now optional-->
48-
<attribute code="0x0008" side="server" define="ACTIVE_POWER" type="power_mw" isNullable="true" min="-2" max="2" default="0x8000000000000000">ActivePower</attribute>
48+
<attribute code="0x0008" side="server" define="ACTIVE_POWER" type="power_mw" isNullable="true" min="0xC000000000000000" max="0x4000000000000000" default="0x8000000000000000">ActivePower</attribute>
4949
<!--Conformance feature [ALTC] - for now optional-->
50-
<attribute code="0x0009" side="server" define="REACTIVE_POWER" type="power_mw" isNullable="true" min="-2" max="2" optional="true" default="0x8000000000000000">ReactivePower</attribute>
50+
<attribute code="0x0009" side="server" define="REACTIVE_POWER" type="power_mw" isNullable="true" min="0xC000000000000000" max="0x4000000000000000" optional="true" default="0x8000000000000000">ReactivePower</attribute>
5151
<!--Conformance feature [ALTC] - for now optional-->
52-
<attribute code="0x000A" side="server" define="APPARENT_POWER" type="power_mw" isNullable="true" min="-2" max="2" optional="true" default="0x8000000000000000">ApparentPower</attribute>
52+
<attribute code="0x000A" side="server" define="APPARENT_POWER" type="power_mw" isNullable="true" min="0xC000000000000000" max="0x4000000000000000" optional="true" default="0x8000000000000000">ApparentPower</attribute>
5353
<!--Conformance feature [ALTC] - for now optional-->
54-
<attribute code="0x000B" side="server" define="RMS_VOLTAGE" type="voltage_mv" isNullable="true" min="-2" max="2" optional="true" default="0x8000000000000000">RMSVoltage</attribute>
54+
<attribute code="0x000B" side="server" define="RMS_VOLTAGE" type="voltage_mv" isNullable="true" min="0xC000000000000000" max="0x4000000000000000" optional="true" default="0x8000000000000000">RMSVoltage</attribute>
5555
<!--Conformance feature [ALTC] - for now optional-->
56-
<attribute code="0x000C" side="server" define="RMS_CURRENT" type="amperage_ma" isNullable="true" min="-2" max="2" optional="true" default="0x8000000000000000">RMSCurrent</attribute>
56+
<attribute code="0x000C" side="server" define="RMS_CURRENT" type="amperage_ma" isNullable="true" min="0xC000000000000000" max="0x4000000000000000" optional="true" default="0x8000000000000000">RMSCurrent</attribute>
5757
<!--Conformance feature [ALTC] - for now optional-->
58-
<attribute code="0x000D" side="server" define="RMS_POWER" type="power_mw" isNullable="true" min="-2" max="2" optional="true" default="0x8000000000000000">RMSPower</attribute>
58+
<attribute code="0x000D" side="server" define="RMS_POWER" type="power_mw" isNullable="true" min="0xC000000000000000" max="0x4000000000000000" optional="true" default="0x8000000000000000">RMSPower</attribute>
5959
<!--Conformance feature HARM - for now optional-->
6060
<attribute code="0x000E" side="server" define="FREQUENCY" type="int64s" isNullable="true" optional="true" min="0" max="1000000" default="0x8000000000000000">Frequency</attribute>
6161
<!--Conformance feature PWRQ - for now optional-->
@@ -64,8 +64,8 @@ limitations under the License.
6464
<attribute code="0x0010" side="server" define="HARMONIC_PHASES" type="array" isNullable="true" optional="true" entryType="HarmonicMeasurementStruct">HarmonicPhases</attribute>
6565
<!--Conformance feature [POLY] - for now optional-->
6666
<attribute code="0x0011" side="server" define="POWER_FACTOR" type="int64s" isNullable="true" min="-10000" max="10000" optional="true" default="0x8000000000000000">PowerFactor</attribute>
67-
<attribute code="0x0012" side="server" type="amperage_ma" define="NEUTRAL_CURRENT" isNullable="true" min="-2" max="2" optional="true" default="0x8000000000000000">NeutralCurrent</attribute>
68-
<event code="0x0000" name="MeasurementPeriodRanges" priority="info" apiMaturity="provisional" optional="true">
67+
<attribute code="0x0012" side="server" type="amperage_ma" define="NEUTRAL_CURRENT" isNullable="true" min="0xC000000000000000" max="0x4000000000000000" optional="true" default="0x8000000000000000">NeutralCurrent</attribute>
68+
<event code="0x0000" name="MeasurementPeriodRanges" priority="info" apiMaturity="provisional" optional="true" side="server">
6969
<description>MeasurementPeriodRanges</description>
7070
<field id="0" name="Ranges" array="true" type="MeasurementRangeStruct"/>
7171
</event>

0 commit comments

Comments
 (0)