Skip to content

Commit 065118f

Browse files
Apply comment suggestions from code review
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
1 parent 42570fa commit 065118f

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/app/ReadClient.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -462,7 +462,7 @@ CHIP_ERROR ReadClient::GenerateDataVersionFilterList(DataVersionFilterIBs::Build
462462
const Span<DataVersionFilter> & aDataVersionFilters,
463463
bool & aEncodedDataVersionList)
464464
{
465-
// Give the callback a chance first, otherwise use the list we have.
465+
// Give the callback a chance first, otherwise use the list we have, if any.
466466
ReturnErrorOnFailure(
467467
mpCallback.OnUpdateDataVersionFilterList(aDataVersionFilterIBsBuilder, aAttributePaths, aEncodedDataVersionList));
468468

src/app/ReadClient.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -339,7 +339,7 @@ class ReadClient : public Messaging::ExchangeDelegate
339339
* This will send either a Read Request or a Subscribe Request depending on
340340
* the InteractionType this read client was initialized with.
341341
*
342-
* If the requests contains more data version filters than can fit in the request packet
342+
* If the params contain more data version filters than can fit in the request packet
343343
* the list will be truncated as needed, i.e. filter inclusion is on a best effort basis.
344344
*
345345
* @retval #others fail to send read request

0 commit comments

Comments
 (0)