Fixed unit test issues

Author: silabs-olivierb

src/app/clusters/ota-requestor/DefaultOTARequestorStorage.h

@@ -49,6 +49,9 @@ class DefaultOTARequestorStorage : public OTARequestorStorage
     CHIP_ERROR ClearTargetVersion() override;
 
 private:
+    /**
+     * Check if a provider is in the lists
+     */
     bool ProviderAlreadyInList(ProviderLocationList & listProviders, ProviderLocationType provider);
     CHIP_ERROR Load(const char * key, MutableByteSpan & buffer);
     PersistentStorageDelegate * mPersistentStorage = nullptr;

src/app/clusters/ota-requestor/OTARequestorInterface.h

@@ -131,6 +131,14 @@ class ProviderLocationList
         return CHIP_ERROR_NOT_FOUND;
     }
 
+    /**
+     * Get the list size
+     */
+    size_t GetListSize()
+    {
+        return mListSize;
+    }
+
 private:
     Optional<app::Clusters::OtaSoftwareUpdateRequestor::Structs::ProviderLocation::Type> mList[CHIP_CONFIG_MAX_FABRICS];
     size_t mListSize = 0;

src/app/tests/TestDefaultOTARequestorStorage.cpp

@@ -123,7 +123,7 @@ TEST(TestDefaultOTARequestorStorage, TestDefaultProvidersDuplicated)
     providers = {};
     EXPECT_EQ(CHIP_NO_ERROR, otaStorage.LoadDefaultProviders(providers));
 
-    EXPECT_TRUE(providers.mListSize == 3U);
+    EXPECT_TRUE(providers.GetListSize() == 3U);
 }
 
 TEST(TestDefaultOTARequestorStorage, TestCurrentProviderLocation)