For unknownd effect variant, Default to the respective 0 value enum variant

Author: jmartinez-silabs

src/app/clusters/on-off-server/on-off-server.cpp

@@ -620,12 +620,17 @@ bool OnOffServer::offWithEffectCommand(app::CommandHandler * commandObj, const a
         // Depending on effectId value, effectVariant enum type varies.
         // The following check validates that effectVariant value is valid in relation to the applicable enum type.
         // DelayedAllOffEffectVariantEnum or DyingLightEffectVariantEnum
-        if ((effectId == EffectIdentifierEnum::kDelayedAllOff &&
-             !isKnownEnumValue(static_cast<DelayedAllOffEffectVariantEnum>(effectVariant))) ||
-            (effectId == EffectIdentifierEnum::kDyingLight &&
-             !isKnownEnumValue(static_cast<DyingLightEffectVariantEnum>(effectVariant))))
+        if (effectId == EffectIdentifierEnum::kDelayedAllOff &&
+            !isKnownEnumValue(static_cast<DelayedAllOffEffectVariantEnum>(effectVariant)))
         {
-            status = Status::ConstraintError;
+            // The server does not support the given variant, it SHALL use the default variant.
+            effectVariant = to_underlying(DelayedAllOffEffectVariantEnum::kDelayedOffFastFade);
+        }
+        else if (effectId == EffectIdentifierEnum::kDyingLight &&
+                 !isKnownEnumValue(static_cast<DyingLightEffectVariantEnum>(effectVariant)))
+        {
+            // The server does not support the given variant, it SHALL use the default variant.
+            effectVariant = to_underlying(DyingLightEffectVariantEnum::kDyingLightFadeOff);
         }
     }
     else