Skip to content

Commit 104ab9c

Browse files
committed
[doxygen] Review fixes.
- Move directory back to docs - Move doxygen-format-check.sh to scripts/helpers. - Clean up CHIP naming.
1 parent 51a2ec7 commit 104ab9c

15 files changed

+19
-28
lines changed

Makefile.am

+2-2
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ SUBDIRS = \
3434
examples \
3535
third_party \
3636
src \
37-
doc \
37+
docs \
3838
tests \
3939
$(NULL)
4040

@@ -212,7 +212,7 @@ distclean-local:
212212

213213
.PHONY: docdist
214214
docdist: $(BUILT_SOURCES)
215-
$(MAKE) -C doc docdistdir=$(abs_builddir) $(@)
215+
$(MAKE) -C docs docdistdir=$(abs_builddir) $(@)
216216

217217
#
218218
# Top-level convenience target for making a tools-only distribution

configure.ac

+1-1
Original file line numberDiff line numberDiff line change
@@ -2080,7 +2080,7 @@ src/lib/support/Makefile
20802080
src/lib/support/tests/Makefile
20812081
src/platform/Makefile
20822082
tests/Makefile
2083-
doc/Makefile
2083+
docs/Makefile
20842084
])
20852085

20862086
#

doc/BUILDING.md docs/BUILDING.md

File renamed without changes.
File renamed without changes.

doc/Doxyfile.in docs/Doxyfile.in

+1-1
Original file line numberDiff line numberDiff line change
@@ -914,7 +914,7 @@ IMAGE_PATH =
914914
# code is scanned, but not when the output code is generated. If lines are added
915915
# or removed, the anchors will not be placed correctly.
916916

917-
INPUT_FILTER = @abs_srcdir@/format-file.sh
917+
INPUT_FILTER = @abs_top_srcdir@/scripts/helpers/doxygen-format-check.sh
918918

919919
# The FILTER_PATTERNS tag can be used to specify filters on a per file pattern
920920
# basis. Doxygen will compare the file name with each pattern and apply the

doc/Makefile.am docs/Makefile.am

+7-7
Original file line numberDiff line numberDiff line change
@@ -18,17 +18,17 @@
1818

1919
#
2020
# Description:
21-
# This file is the GNU automake template for the Nest Weave
21+
# This file is the GNU automake template for the CHIP
2222
# API and stack documentation.
2323
#
2424

2525
include $(abs_top_nlbuild_autotools_dir)/automake/pre.am
2626

27-
EXTRA_DIST = \
28-
$(srcdir)/Doxyfile.in \
29-
$(srcdir)/ChipDoxygenLayout.xml \
30-
$(srcdir)/format-file.sh \
31-
$(srcdir)/namespaces.dox \
27+
EXTRA_DIST = \
28+
$(srcdir)/Doxyfile.in \
29+
$(srcdir)/ChipDoxygenLayout.xml \
30+
$(top_srcdir)/scripts/helpers/doxygen-format-check.sh \
31+
$(srcdir)/namespaces.dox \
3232
$(NULL)
3333

3434
#
@@ -88,7 +88,7 @@ html/index.html: Doxyfile
8888

8989
#
9090
# Addition rules and commands to create a documentation-only
91-
# distribution of Weave
91+
# distribution of Chip
9292
#
9393

9494
$(chip_docdist_name): $(EXTRA_DOCS) html/index.html
File renamed without changes.

doc/README.md docs/README.md

File renamed without changes.
File renamed without changes.
File renamed without changes.

doc/namespaces.dox docs/namespaces.dox

+5-14
Original file line numberDiff line numberDiff line change
@@ -19,28 +19,19 @@
1919

2020
/*
2121
* Description:
22-
* This file documents all C++ namespaces used within the Weave
22+
* This file documents all C++ namespaces used within the CHIP
2323
* Core SDK that are not otherwise documented in an umbrella
2424
* header encompassing that namespace.
2525
*
2626
*/
2727

2828
/**
29-
* @namespace nl
29+
* @namespace chip
3030
*
3131
* @brief
32-
* This namespace is the outermost namespace for all Weave interfaces.
32+
* This namespace is the outermost namespace for all CHIP interfaces.
3333
*
34-
* @note All Nest Labs interfaces shall appear within this namespace.
35-
*
36-
* @note No third-party interfaces shall appear within this namespace.
37-
*/
38-
39-
/**
40-
* @namespace nl::Weave
41-
*
42-
* @brief
43-
* This namespace includes interfaces within the Weave Core SDK
44-
* that cover the Core stack, the Common and Nest vendor-specific
34+
* This namespace includes interfaces within the CHIP Core SDK
35+
* that cover the Core stack, the Common and vendor-specific
4536
* profiles, and the support interfaces.
4637
*/
File renamed without changes.
File renamed without changes.
File renamed without changes.

doc/format-file.sh scripts/helpers/doxygen-format-check.sh

+3-3
Original file line numberDiff line numberDiff line change
@@ -18,19 +18,19 @@
1818
# limitations under the License.
1919
#
2020

21-
# Managed namespace constructs within Weave ended up seriously
21+
# Managed namespace constructs within CHIP ended up seriously
2222
# confusing Doxygen, and I could not find a nicer way to evaluate
2323
# those macros via Doxygen's PREDEFINED directives. Instead, we
2424
# process the incoming files via this script file.
2525

2626
SED=/bin/sed
2727
FILENAME=${1}
2828
# clang format has difficulty recognizing the
29-
# WeaveMakeManagedNamespaceIdentifier() macro as a valid namespace;
29+
# ChipMakeManagedNamespaceIdentifier() macro as a valid namespace;
3030
# temporarily change the namespace name to something more palatable to
3131
# clang-format
3232

33-
sed -e 's:^[ ]*namespace[ ]\+WeaveMakeManagedNamespaceIdentifier(\([^ ,()]\+\),[ ]*kWeaveManagedNamespaceDesignation_\([^ ,()]\+\))[ ]*{[ ]*$:namespace \1_\2 {:g' \
33+
sed -e 's:^[ ]*namespace[ ]\+ChipMakeManagedNamespaceIdentifier(\([^ ,()]\+\),[ ]*kChipManagedNamespaceDesignation_\([^ ,()]\+\))[ ]*{[ ]*$:namespace \1_\2 {:g' \
3434
-e 's/NS_ENUM(\([_a-zA-Z0-9][_a-zA-Z0-9]*\)[ ]*,[ ]*\([_a-zA-Z0-9][_a-zA-Z0-9]*\))/ enum \2 : \1 \2; enum \2 : \1/g' \
3535
-e 's/__attribute__(([^)]*))//g' \
3636
-e 's/__attribute__([^)]*)//g' "$FILENAME"

0 commit comments

Comments
 (0)