File tree 2 files changed +3
-48
lines changed
darwin/Framework/CHIPTests
2 files changed +3
-48
lines changed Original file line number Diff line number Diff line change @@ -137,9 +137,9 @@ - (void)testBleCommissionAfterStopBrowseUAF
137
137
XCTAssertTrue ([sController stopBrowseForCommissionables ]);
138
138
139
139
// Attempt to use the MTRCommissionableBrowserResult after we stopped browsing
140
- // TODO: This currently results in a UAF because BLE_CONNECTION_OBJECT is a void*
140
+ // This used to result in a UAF because BLE_CONNECTION_OBJECT is a void*
141
141
// carrying a CBPeripheral without retaining it. When browsing is stopped,
142
- // BleConnectionDelegateImpl release all cached CBPeripherals.
142
+ // BleConnectionDelegateImpl releases all cached CBPeripherals.
143
143
MTRSetupPayload * payload = [[MTRSetupPayload alloc ] initWithSetupPasscode: @54321 discriminator: @0x444 ];
144
144
[sController setupCommissioningSessionWithDiscoveredDevice: device
145
145
payload: payload
@@ -157,7 +157,7 @@ - (void)testShutdownBlePowerOffRaceUAF
157
157
XCTAssertTrue ([sController setupCommissioningSessionWithPayload: payload newNodeID: @999 error: &error],
158
158
" setupCommissioningSessionWithPayload failed: %@" , error);
159
159
160
- // Create a race between shutdown and a CBManager callback that provokes a UAF
160
+ // Create a race between shutdown and a CBManager callback that used to provoke a UAF.
161
161
// Note that on the order of 100 iterations can be necessary to reproduce the crash.
162
162
__block atomic_int tasks = 2 ;
163
163
dispatch_semaphore_t done = dispatch_semaphore_create (0 );
Load Diff This file was deleted.
You can’t perform that action at this time.
0 commit comments