Skip to content

Commit 10eed39

Browse files
Final round of review comments
1 parent 6f90e68 commit 10eed39

File tree

2 files changed

+3
-48
lines changed

2 files changed

+3
-48
lines changed

src/darwin/Framework/CHIPTests/MTRBleTests.m

+3-3
Original file line numberDiff line numberDiff line change
@@ -137,9 +137,9 @@ - (void)testBleCommissionAfterStopBrowseUAF
137137
XCTAssertTrue([sController stopBrowseForCommissionables]);
138138

139139
// Attempt to use the MTRCommissionableBrowserResult after we stopped browsing
140-
// TODO: This currently results in a UAF because BLE_CONNECTION_OBJECT is a void*
140+
// This used to result in a UAF because BLE_CONNECTION_OBJECT is a void*
141141
// carrying a CBPeripheral without retaining it. When browsing is stopped,
142-
// BleConnectionDelegateImpl release all cached CBPeripherals.
142+
// BleConnectionDelegateImpl releases all cached CBPeripherals.
143143
MTRSetupPayload * payload = [[MTRSetupPayload alloc] initWithSetupPasscode:@54321 discriminator:@0x444];
144144
[sController setupCommissioningSessionWithDiscoveredDevice:device
145145
payload:payload
@@ -157,7 +157,7 @@ - (void)testShutdownBlePowerOffRaceUAF
157157
XCTAssertTrue([sController setupCommissioningSessionWithPayload:payload newNodeID:@999 error:&error],
158158
"setupCommissioningSessionWithPayload failed: %@", error);
159159

160-
// Create a race between shutdown and a CBManager callback that provokes a UAF
160+
// Create a race between shutdown and a CBManager callback that used to provoke a UAF.
161161
// Note that on the order of 100 iterations can be necessary to reproduce the crash.
162162
__block atomic_int tasks = 2;
163163
dispatch_semaphore_t done = dispatch_semaphore_create(0);

src/platform/Darwin/BlePeripheral.h

-45
This file was deleted.

0 commit comments

Comments
 (0)