Skip to content

Commit 19d1e12

Browse files
committed
unwind premature optimization placeholders/comments
1 parent 1bbb9ef commit 19d1e12

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

src/darwin/Framework/CHIP/MTRDevice.mm

-6
Original file line numberDiff line numberDiff line change
@@ -354,10 +354,6 @@ @interface MTRDevice ()
354354

355355
@property (nonatomic) MTRInternalDeviceState internalDeviceState;
356356

357-
// TODO: cache this once I understand the point in the MTRDevice lifecycle that the relevant attributes will be present.
358-
// kmo 22 may 2024 14h55
359-
// @property (nonatomic) MTRDeviceEssentialAttributes * essentialAttributes;
360-
361357
#define MTRDEVICE_SUBSCRIPTION_ATTEMPT_MIN_WAIT_SECONDS (1)
362358
#define MTRDEVICE_SUBSCRIPTION_ATTEMPT_MAX_WAIT_SECONDS (3600)
363359
@property (nonatomic) uint32_t lastSubscriptionAttemptWait;
@@ -1734,8 +1730,6 @@ - (void)_handleEventReport:(NSArray<NSDictionary<NSString *, id> *> *)eventRepor
17341730
BOOL isStartUpEvent = (eventPath.cluster.unsignedLongValue == MTRClusterIDTypeBasicInformationID)
17351731
&& (eventPath.event.unsignedLongValue == MTREventIDTypeClusterBasicInformationEventStartUpID);
17361732
if (isStartUpEvent) {
1737-
// REVIEWERS: this seems like a good place to set up / cache
1738-
// the essential device attributes - is it?
17391733
if (_estimatedStartTimeFromGeneralDiagnosticsUpTime) {
17401734
// If UpTime was received, make use of it as mark of system start time
17411735
MTR_LOG("%@ StartUp event: set estimated start time forward to %@", self,

0 commit comments

Comments
 (0)