Code review notes fixes

Author: popovdg

src/app/clusters/meter-identification-server/MeterIdentificationTestEventTriggerHandler.h

@@ -44,7 +44,7 @@ namespace chip {
 enum class MeterIdentificationTrigger : uint64_t
 {
     // Scenarios
-    // Attributes Value Update Test Event | Increment attribute values
+    // Attributes Value Update Test Event | Increment all attributes values
     kAttributesValueUpdate = 0x0b06000000000000,
     // Attributes Value Test Event Clear | Return the device to pre-test status
     kAttributesValueUpdateClear = 0x0b06000000000001,

src/app/clusters/meter-identification-server/meter-identification-server.cpp

@@ -56,12 +56,6 @@ bool Instance::HasFeature(const Feature & aFeature) const
     return mFeature.Has(aFeature);
 }
 
-// static CHIP_ERROR EncodeStringOnSuccess(CHIP_ERROR status, AttributeValueEncoder & encoder, const char * buf, size_t maxBufSize)
-//{
-//     ReturnErrorOnFailure(status);
-//     return encoder.Encode(chip::CharSpan(buf, strnlen(buf, maxBufSize)));
-// }
-
 // AttributeAccessInterface
 CHIP_ERROR Instance::Read(const ConcreteReadAttributePath & aPath, AttributeValueEncoder & aEncoder)
 {
@@ -98,20 +92,6 @@ CHIP_ERROR Instance::Read(const ConcreteReadAttributePath & aPath, AttributeValu
     return CHIP_NO_ERROR;
 }
 
-CHIP_ERROR Instance::Write(const ConcreteDataAttributePath & aPath, AttributeValueDecoder & aDecoder)
-{
-    /*
-
-        switch (aPath.mAttributeId)
-        {
-
-        default:
-            break;
-        }
-    */
-    return CHIP_NO_ERROR;
-}
-
 } // namespace MeterIdentification
 } // namespace Clusters
 } // namespace app

src/app/clusters/meter-identification-server/meter-identification-server.h

@@ -27,16 +27,15 @@
 #include <app/util/basic-types.h>
 #include <lib/core/CHIPError.h>
 
-using chip::app::Clusters::MeterIdentification::MeterTypeEnum;
-using Feature = chip::app::Clusters::MeterIdentification::Feature;
-
 namespace chip {
 namespace app {
 namespace Clusters {
 namespace MeterIdentification {
 
 struct Delegate
 {
+    EndpointId mEndpointId = 0;
+
 public:
     virtual ~Delegate() = default;
 
@@ -47,9 +46,6 @@ struct Delegate
     virtual DataModel::Nullable<CharSpan> GetMeterSerialNumber()                          = 0;
     virtual DataModel::Nullable<CharSpan> GetProtocolVersion()                            = 0;
     virtual DataModel::Nullable<Structs::PowerThresholdStruct::Type> GetPowerThreshold()  = 0;
-
-protected:
-    EndpointId mEndpointId = 0;
 };
 
 class Instance : public AttributeAccessInterface
@@ -74,7 +70,6 @@ class Instance : public AttributeAccessInterface
 
     // AttributeAccessInterface
     CHIP_ERROR Read(const ConcreteReadAttributePath & aPath, AttributeValueEncoder & aEncoder) override;
-    CHIP_ERROR Write(const ConcreteDataAttributePath & aPath, AttributeValueDecoder & aDecoder) override;
 };
 
 } // namespace MeterIdentification