Code review updates

Author: andy31415

src/app/codegen-data-model/CodegenDataModel_Read.cpp

@@ -92,8 +92,8 @@ struct ShortPascalString
     static size_t GetLength(ByteSpan buffer)
     {
         VerifyOrDie(buffer.size() >= 1);
-        // NOTE: we do NOT use emberAfLongStringLength because that will result in 0 length
-        //       for null sizes (i.e. 0xFF is translated to 0 and we do not want that here)
+        // NOTE: we do NOT use emberAfStringLength from ember-strings.h because that will result in 0
+        //       length for null sizes (i.e. 0xFF is translated to 0 and we do not want that here)
         return buffer[0];
     }
 };
@@ -106,8 +106,8 @@ struct LongPascalString
 
     static size_t GetLength(ByteSpan buffer)
     {
-        // NOTE: we do NOT use emberAfLongStringLength because that will result in 0 length
-        //       for null sizes (i.e. 0xFFFF is translated to 0 and we do not want that here)
+        // NOTE: we do NOT use emberAfLongStringLength from ember-strings.h because that will result in 0
+        //       length for null sizes (i.e. 0xFFFF is translated to 0 and we do not want that here)
         VerifyOrDie(buffer.size() >= 2);
         const uint8_t * data = buffer.data();
         return Encoding::LittleEndian::Read16(data);

src/app/codegen-data-model/CodegenDataModel_Write.cpp

@@ -365,34 +365,38 @@ CHIP_ERROR CodegenDataModel::WriteAttribute(const InteractionModel::WriteAttribu
 
     Protocols::InteractionModel::Status status;
 
+    if (dataBuffer.size() > (*attributeMetadata)->size)
+    {
+        ChipLogDetail(Zcl, "Data to write exceeds the attribute size claimed.");
+        return CHIP_IM_GLOBAL_STATUS(InvalidValue);
+    }
+
     if (request.operationFlags.Has(InteractionModel::OperationFlags::kInternal))
     {
         // Internal requests use the non-External interface that has less enforcement
         // than the external version (e.g. does not check/enforce writable settings, does not
         // validate attribute types) - see attribute-table.h documentation for details.
         status = emberAfWriteAttribute(request.path.mEndpointId, request.path.mClusterId, request.path.mAttributeId,
-                                       gEmberAttributeIOBufferSpan.data(), (*attributeMetadata)->attributeType);
+                                       dataBuffer.data(), (*attributeMetadata)->attributeType);
     }
     else
     {
-        if (dataBuffer.size() > (*attributeMetadata)->size)
-        {
-            ChipLogDetail(Zcl, "Data to write exceeds the attribute size claimed.");
-            return CHIP_IM_GLOBAL_STATUS(InvalidValue);
-        }
-
         status = emAfWriteAttributeExternal(request.path.mEndpointId, request.path.mClusterId, request.path.mAttributeId,
-                                            gEmberAttributeIOBufferSpan.data(), (*attributeMetadata)->attributeType);
+                                            dataBuffer.data(), (*attributeMetadata)->attributeType);
     }
 
     if (status != Protocols::InteractionModel::Status::Success)
     {
         return CHIP_ERROR_IM_GLOBAL_STATUS_VALUE(status);
     }
 
-    // TODO: this may need more refinement:
-    //       - should internal requests be able to decide if something is marked dirty or not?
-    //       - changes-omitted paths should not be marked dirty (ember is not aware of these)
+    // TODO: this WILL requre updates
+    //
+    // - Internal writes may need to be able to decide if to mark things dirty or not (see AAI as well)
+    // - Changes-ommited paths should not be marked dirty (ember is not aware of that flag)
+    // - This likely maps to `MatterReportingAttributeChangeCallback` HOWEVER current ember write functions
+    //   will selectively call that one depending on old attribute state (i.e. calling every time is a
+    //   change in behavior)
     CurrentContext().dataModelChangeListener->MarkDirty(request.path);
     return CHIP_NO_ERROR;
 }