Skip to content

Commit 1f2f6be

Browse files
Add a step timeout for Matter.framework unit tests. (#35530)
If a test hangs, we end up running until job timeout after 6 hours. But that skips later steps, including log uploads, which makes it harder to figure out why the hang happened. The fix is to use a timeout on the test job that is somewhat shorter than the 6-hour job timeout, so we allow time for the log upload too.
1 parent 702fae3 commit 1f2f6be

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

.github/workflows/darwin.yaml

+3-4
Original file line numberDiff line numberDiff line change
@@ -105,10 +105,9 @@ jobs:
105105
run: |
106106
scripts/examples/gn_build_example.sh examples/ota-requestor-app/linux out/debug/ota-requestor-app chip_config_network_layer_ble=false non_spec_compliant_ota_action_delay_floor=0
107107
- name: Run Framework Tests
108-
# For now disable unguarded-availability-new warnings because we
109-
# internally use APIs that we are annotating as only available on
110-
# new enough versions. Maybe we should change out deployment
111-
# target versions instead?
108+
# We want to ensure that our log upload runs on timeout, so use a timeout here shorter
109+
# than the 6-hour overall job timeout. 4.5 hours should be plenty.
110+
timeout-minutes: 270
112111
working-directory: src/darwin/Framework
113112
run: |
114113
mkdir -p /tmp/darwin/framework-tests

0 commit comments

Comments
 (0)