Skip to content

Commit 20a8dde

Browse files
Add OperationalState Global Attributes test to the CI (#27950)
* Add OperationalState Global Attributes test to the CI Steps: - regen all yaml tests - re-build chip-tool, re-build all-clusters - manually run OPSTATE_1_1 via chip-tool - verify resulting logs * Restyled by whitespace * Restyled by prettier-json * Restyled by prettier-yaml * Revert change to manualtests.json * Restyled by whitespace * Restyled by prettier-json * Exclude test from Darwin * Restyled by whitespace * Update with results of regen * Restyled by whitespace --------- Co-authored-by: Restyled.io <commits@restyled.io>
1 parent 1883599 commit 20a8dde

File tree

6 files changed

+293
-13
lines changed

6 files changed

+293
-13
lines changed

examples/darwin-framework-tool/templates/tests/ciTests.json

+2
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,8 @@
115115
"Disabled due to HEPAFilterMonitoring not being enabled in Matter.framework for now:",
116116
"Test_TC_HEPAFREMON_1_1",
117117
"Test_TC_HEPAFREMON_2_1",
118+
"Disabled due to OperationalState not being enabled in Matter.framework for now:",
119+
"Test_TC_OPSTATE_1_1",
118120
"Disabled due to Events verification not supported",
119121
"Test_TC_BINFO_2_2"
120122
]

src/app/tests/suites/certification/PICS.yaml

+24
Original file line numberDiff line numberDiff line change
@@ -9539,3 +9539,27 @@ PICS:
95399539
- label:
95409540
"Does the device implement sending the ChangeToModeResponse command?"
95419541
id: RVCCLEANMS.S.C03.Tx
9542+
9543+
#
9544+
#Operational State
9545+
#
9546+
#Server Attributes
9547+
- label: "Does the device implement the CountdownTime attribute?"
9548+
id: OPSTATE.S.A0002
9549+
9550+
#Events Generated
9551+
- label: "Does the device generate the OperationCompltion event?"
9552+
id: OPSTATE.S.E01
9553+
9554+
#Server Commands Received
9555+
- label: "Does the device implement receiving the Pause command?"
9556+
id: OPSTATE.S.C00
9557+
9558+
- label: "Does the device implement receiving the Stop command?"
9559+
id: OPSTATE.S.C01
9560+
9561+
- label: "Does the device implement receiving the Start command?"
9562+
id: OPSTATE.S.C02
9563+
9564+
- label: "Does the device implement receiving the Resume command?"
9565+
id: OPSTATE.S.C03

src/app/tests/suites/certification/Test_TC_OPSTATE_1_1.yaml

+7-13
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ tests:
3232
value: nodeId
3333

3434
- label: "TH reads the ClusterRevision attribute from the DUT"
35-
PICS: OPSTATE.S.Afffd
3635
command: "readAttribute"
3736
attribute: "ClusterRevision"
3837
response:
@@ -41,7 +40,6 @@ tests:
4140
type: int16u
4241

4342
- label: "TH reads the FeatureMap attribute from the DUT"
44-
PICS: OPSTATE.S.Afffc
4543
command: "readAttribute"
4644
attribute: "FeatureMap"
4745
response:
@@ -50,7 +48,6 @@ tests:
5048
type: bitmap32
5149

5250
- label: "TH reads the AttributeList attribute from the DUT"
53-
PICS: OPSTATE.S.Afffb
5451
command: "readAttribute"
5552
attribute: "AttributeList"
5653
response:
@@ -62,7 +59,7 @@ tests:
6259
- label:
6360
"TH reads from the DUT the optional attribute(CountdownTime) in the
6461
AttributeList from the DUT"
65-
PICS: OPSTATE.S.A0002 && OPSTATE.S.Afffb
62+
PICS: OPSTATE.S.A0002
6663
command: "readAttribute"
6764
attribute: "AttributeList"
6865
response:
@@ -71,7 +68,6 @@ tests:
7168
contains: [2]
7269

7370
- label: "TH reads from the DUT the EventList attribute."
74-
PICS: OPSTATE.S.Afffa
7571
command: "readAttribute"
7672
attribute: "EventList"
7773
response:
@@ -82,7 +78,7 @@ tests:
8278
- label:
8379
"TH reads from the DUT the optional event(OperationCompletion) in
8480
EventList."
85-
PICS: OPSTATE.S.E01 && OPSTATE.S.Afffa
81+
PICS: OPSTATE.S.E01
8682
command: "readAttribute"
8783
attribute: "EventList"
8884
response:
@@ -91,7 +87,7 @@ tests:
9187
contains: [0x01]
9288

9389
- label: "Read the optional command(Start) in AcceptedCommandList"
94-
PICS: OPSTATE.S.C02 && OPSTATE.S.Afff9
90+
PICS: OPSTATE.S.C02
9591
command: "readAttribute"
9692
attribute: "AcceptedCommandList"
9793
response:
@@ -100,7 +96,7 @@ tests:
10096
contains: [1, 2]
10197

10298
- label: "Read the optional command(Stop) in AcceptedCommandList"
103-
PICS: OPSTATE.S.C01 && OPSTATE.S.Afff9
99+
PICS: OPSTATE.S.C01
104100
command: "readAttribute"
105101
attribute: "AcceptedCommandList"
106102
response:
@@ -109,7 +105,7 @@ tests:
109105
contains: [1]
110106

111107
- label: "Read the optional command(Pause) in AcceptedCommandList"
112-
PICS: OPSTATE.S.C00 && OPSTATE.S.Afff9
108+
PICS: OPSTATE.S.C00
113109
command: "readAttribute"
114110
attribute: "AcceptedCommandList"
115111
response:
@@ -118,7 +114,7 @@ tests:
118114
contains: [0, 3]
119115

120116
- label: "Read the optional command(Resume) in AcceptedCommandList"
121-
PICS: OPSTATE.S.C03 && OPSTATE.S.Afff9
117+
PICS: OPSTATE.S.C03
122118
command: "readAttribute"
123119
attribute: "AcceptedCommandList"
124120
response:
@@ -127,9 +123,7 @@ tests:
127123
contains: [0, 3]
128124

129125
- label: "Read the global attribute: GeneratedCommandList"
130-
PICS:
131-
OPSTATE.S.Afff8 && (OPSTATE.S.C00 || OPSTATE.S.C01 || OPSTATE.S.C02 ||
132-
OPSTATE.S.C03)
126+
PICS: (OPSTATE.S.C00 || OPSTATE.S.C01 || OPSTATE.S.C02 || OPSTATE.S.C03)
133127
command: "readAttribute"
134128
attribute: "GeneratedCommandList"
135129
response:

src/app/tests/suites/certification/ci-pics-values

+13
Original file line numberDiff line numberDiff line change
@@ -1828,6 +1828,19 @@ OPCREDS.C.C09.Tx=1
18281828
OPCREDS.C.C0a.Tx=1
18291829
OPCREDS.C.C0b.Tx=1
18301830

1831+
# Operational State
1832+
# Server Attributes
1833+
OPSTATE.S.A0002=1
1834+
1835+
# Server Events
1836+
OPSTATE.S.E01=1
1837+
1838+
# Server Commands
1839+
OPSTATE.S.C00=1
1840+
OPSTATE.S.C01=1
1841+
OPSTATE.S.C02=1
1842+
OPSTATE.S.C03=1
1843+
18311844
# Thermostat
18321845
# Server
18331846
TSTAT.S=1

src/app/tests/suites/ciTests.json

+2
Original file line numberDiff line numberDiff line change
@@ -157,6 +157,7 @@
157157
"Test_TC_OO_2_2",
158158
"Test_TC_OO_2_4"
159159
],
160+
"OperationalState": ["Test_TC_OPSTATE_1_1"],
160161
"PowerSource": ["Test_TC_PS_1_1", "Test_TC_PS_2_1"],
161162
"PressureMeasurement": [
162163
"Test_TC_PRS_1_1",
@@ -367,6 +368,7 @@
367368
"OTASoftwareUpdate",
368369
"OccupancySensing",
369370
"OnOff",
371+
"OperationalState",
370372
"PowerSource",
371373
"PressureMeasurement",
372374
"PumpConfigurationControl",

0 commit comments

Comments
 (0)