Update Session.h

andy31415 · web-flow · commit 210a171d1b8b · 2024-05-03T12:11:35.000-04:00
Add explanation that even `move` was not fully intentionally allowed for SessionHandle.
diff --git a/src/transport/Session.h b/src/transport/Session.h
@@ -84,6 +84,8 @@ class Session;
  *
  *   To meet the requirements of "you should not store this", the Handle has additional restrictions
  *   preventing modification (no assignment or copy constructor) and allows only move.
+ *   NOTE: `move` should likely also not be allowed, however we need to have the ability to
+ *         return such objects from method calls, so it is currently allowed.
  *
  */
 class SessionHandle

Original file line number	Diff line number	Diff line change
`@@ -84,6 +84,8 @@ class Session;`
`84`	`84`	`*`
`85`	`85`	`* To meet the requirements of "you should not store this", the Handle has additional restrictions`
`86`	`86`	`* preventing modification (no assignment or copy constructor) and allows only move.`
	`87`	+ * NOTE: `move` should likely also not be allowed, however we need to have the ability to
	`88`	`+ * return such objects from method calls, so it is currently allowed.`
`87`	`89`	`*`
`88`	`90`	`*/`
`89`	`91`	`class SessionHandle`