Skip to content

Commit 2685ef2

Browse files
committed
Cleanup code
1 parent d8bb72c commit 2685ef2

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

scripts/tests/chiptest/linux.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -277,8 +277,7 @@ def _set_interface_ip_in_netns(netns: str, dev: str, ip: str):
277277
def start(self):
278278
hostapd_cmd = ["ip", "netns", "exec", "tool", self._hostapd_path, self._hostapd_conf]
279279
dnsmaq_cmd = ["ip", "netns", "exec", "tool", self._dnsmasq_path, "-d", "-C", self._dnsmasq_conf]
280-
# TODO: change wlan0 to the actual interface name
281-
dhclient_cmd = ["ip", "netns", "exec", "app", "dhclient", "wlan0"]
280+
dhclient_cmd = ["ip", "netns", "exec", "app", "dhclient", self._wlan_app]
282281
wpa_cmd = [
283282
"ip",
284283
"netns",

scripts/tests/chiptest/test_definition.py

+2-3
Original file line numberDiff line numberDiff line change
@@ -389,8 +389,8 @@ def Run(self, runner, apps_register, paths: ApplicationPaths, pics_file: str,
389389
"--ble-adapter", str(tool_hci_number)]
390390
else:
391391
pairing_cmd = paths.chip_tool_with_python_cmd + ['pairing', 'code', TEST_NODE_ID, setupCode]
392-
if self.target == TestTarget.LIT_ICD and test_runtime == TestRunTime.CHIP_TOOL_PYTHON:
393-
pairing_cmd += ['--icd-registration', 'true']
392+
if self.target == TestTarget.LIT_ICD and test_runtime == TestRunTime.CHIP_TOOL_PYTHON:
393+
pairing_cmd += ['--icd-registration', 'true']
394394
test_cmd = paths.chip_tool_with_python_cmd + ['tests', self.run_name] + ['--PICS', pics_file]
395395
server_args = ['--server_path', paths.chip_tool[-1]] + \
396396
['--server_arguments', 'interactive server' +
@@ -412,7 +412,6 @@ def quoter(arg): return f"'{arg}'" if ' ' in arg else arg
412412
test_cmd,
413413
name='TEST', dependencies=[apps_register],
414414
timeout_seconds=timeout_seconds)
415-
runner.capture_delegate.LogContents()
416415

417416
except Exception:
418417
logging.error("!!!!!!!!!!!!!!!!!!!! ERROR !!!!!!!!!!!!!!!!!!!!!!")

0 commit comments

Comments
 (0)