Skip to content

Commit 26e8a9f

Browse files
committed
addressed review comments
1 parent cfea9f4 commit 26e8a9f

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

examples/lighting-app/tizen/src/DBusInterface.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ void DBusInterface::InitOnOff()
217217
void DBusInterface::InitColor()
218218
{
219219
{
220-
auto value = Clusters::ColorControl::ColorModeEnum::kCurrentHueAndCurrentSaturation;
220+
uint8_t value = 0;
221221
auto status = Clusters::ColorControl::Attributes::ColorMode::Get(mEndpointId, &value);
222222
VerifyOrReturn(status == Protocols::InteractionModel::Status::Success,
223223
ChipLogError(NotSpecified, "Error getting ColorMode: 0x%x", to_underlying(status)));

src/app/clusters/color-control-server/color-control-server.cpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -570,7 +570,7 @@ void ColorControlServer::handleModeSwitch(EndpointId endpoint, EnhancedColorMode
570570
uint8_t colorModeTransition;
571571

572572
// Convert ColorMode to EnhancedColorMode
573-
EnhancedColorMode enhancedColorMode;
573+
EnhancedColorModeEnum enhancedColorMode = EnhancedColorModeEnum::kUnknownEnumValue;
574574
switch (oldColorMode)
575575
{
576576
case ColorMode::kCurrentHueAndCurrentSaturation:
@@ -2620,7 +2620,7 @@ void ColorControlServer::startUpColorTempCommand(EndpointId endpoint)
26202620
auto updateColorMode = ColorMode::kColorTemperatureMireds;
26212621
Attributes::ColorMode::Set(endpoint, updateColorMode);
26222622
// Convert ColorMode to EnhancedColorMode
2623-
EnhancedColorModeEnum enhancedColorMode;
2623+
EnhancedColorModeEnum enhancedColorMode = EnhancedColorModeEnum::kUnknownEnumValue;
26242624
switch (updateColorMode)
26252625
{
26262626
case ColorModeEnum::kCurrentHueAndCurrentSaturation:
@@ -2966,7 +2966,7 @@ void ColorControlServer::levelControlColorTempChangeCommand(EndpointId endpoint)
29662966
Attributes::ColorMode::Get(endpoint, &colorMode);
29672967

29682968
// Convert ColorMode to EnhancedColorMode
2969-
EnhancedColorModeEnum enhancedColorMode;
2969+
EnhancedColorModeEnum enhancedColorMode = EnhancedColorModeEnum::kUnknownEnumValue;
29702970
switch (colorMode)
29712971
{
29722972
case ColorModeEnum::kCurrentHueAndCurrentSaturation:

0 commit comments

Comments
 (0)