Skip to content

Commit 27aa108

Browse files
committed
Removing these errors
1 parent 8ba371a commit 27aa108

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

src/darwin/Framework/CHIP/MTRDevice.mm

+5-3
Original file line numberDiff line numberDiff line change
@@ -173,8 +173,8 @@ - (void)_deviceInternalStateChanged:(MTRDevice *)device;
173173
UnsolicitedMessageFromPublisherHandler unsolicitedMessageFromPublisherHandler, ReportBeginHandler reportBeginHandler,
174174
ReportEndHandler reportEndHandler)
175175
: MTRBaseSubscriptionCallback(attributeReportCallback, eventReportCallback, errorCallback, resubscriptionCallback,
176-
subscriptionEstablishedHandler, onDoneHandler, unsolicitedMessageFromPublisherHandler, reportBeginHandler,
177-
reportEndHandler)
176+
subscriptionEstablishedHandler, onDoneHandler, unsolicitedMessageFromPublisherHandler, reportBeginHandler,
177+
reportEndHandler)
178178
{
179179
}
180180

@@ -3619,7 +3619,9 @@ - (NSArray *)_getAttributesToReportWithReportedValues:(NSArray<NSDictionary<NSSt
36193619
}
36203620
}
36213621

3622-
MTR_LOG("%@ report from reported values %@", self, attributePathsToReport);
3622+
if (attributePathsToReport.count > 0) {
3623+
MTR_LOG("%@ report from reported values %@", self, attributePathsToReport);
3624+
}
36233625

36243626
return attributesToReport;
36253627
}

src/darwin/Framework/CHIP/MTRDeviceStorageBehaviorConfiguration.mm

+1-1
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ - (void)checkValuesAndResetToDefaultIfNecessary
7575

7676
// Sanity check all the values, and if any is out of range, reset to default values
7777
if ((_reportToPersistenceDelayTime <= 0) || (_reportToPersistenceDelayTimeMax <= 0) || (_reportToPersistenceDelayTimeMax < _reportToPersistenceDelayTime) || (_recentReportTimesMaxCount < 2) || (_timeBetweenReportsTooShortThreshold <= 0) || (_timeBetweenReportsTooShortMinThreshold <= 0) || (_timeBetweenReportsTooShortMinThreshold > _timeBetweenReportsTooShortThreshold) || (_reportToPersistenceDelayMaxMultiplier <= 1) || (_deviceReportingExcessivelyIntervalThreshold <= 0)) {
78-
MTR_LOG_ERROR("%@ storage behavior: MTRDeviceStorageBehaviorConfiguration values out of bounds - resetting to default", self);
78+
MTR_LOG("%@ storage behavior: MTRDeviceStorageBehaviorConfiguration values out of bounds - resetting to default", self);
7979

8080
_reportToPersistenceDelayTime = kReportToPersistenceDelayTimeDefault;
8181
_reportToPersistenceDelayTimeMax = kReportToPersistenceDelayTimeMaxDefault;

0 commit comments

Comments
 (0)