breadcrumb field in SetActiveDataset command should be optional

Author: wqx6

src/app/zap-templates/zcl/data-model/chip/thread-border-router-management-cluster.xml

@@ -62,7 +62,7 @@ limitations under the License.
     <command source="client" code="0x03" name="SetActiveDatasetRequest" optional="false">
       <description>On receipt of this command, the Thread Border Router will set or update the active Dataset of the Thread network that the Stub Router is connected to.</description>
       <arg name="ActiveDataset" type="octet_string" length="254"/>
-      <arg name="Breadcrumb" type="int64u"/>
+      <arg name="Breadcrumb" type="int64u" optional="true"/>
       <access op="invoke" privilege="manage"/>
     </command>
 

src/controller/data_model/controller-clusters.matter

@@ -7700,7 +7700,7 @@ cluster ThreadBorderRouterManagement = 1106 {
 
   request struct SetActiveDatasetRequestRequest {
     octet_string<254> activeDataset = 0;
-    int64u breadcrumb = 1;
+    optional int64u breadcrumb = 1;
   }
 
   request struct SetPendingDatasetRequestRequest {

src/controller/java/generated/java/chip/devicecontroller/ChipClusters.java

@@ -53160,11 +53160,11 @@ public void onResponse(StructType invokeStructValue) {
         }}, commandId, commandArgs, timedInvokeTimeoutMs);
     }
 
-    public void setActiveDatasetRequest(DefaultClusterCallback callback, byte[] activeDataset, Long breadcrumb) {
+    public void setActiveDatasetRequest(DefaultClusterCallback callback, byte[] activeDataset, Optional<Long> breadcrumb) {
       setActiveDatasetRequest(callback, activeDataset, breadcrumb, 0);
     }
 
-    public void setActiveDatasetRequest(DefaultClusterCallback callback, byte[] activeDataset, Long breadcrumb, int timedInvokeTimeoutMs) {
+    public void setActiveDatasetRequest(DefaultClusterCallback callback, byte[] activeDataset, Optional<Long> breadcrumb, int timedInvokeTimeoutMs) {
       final long commandId = 3L;
 
       ArrayList<StructElement> elements = new ArrayList<>();
@@ -53173,7 +53173,7 @@ public void setActiveDatasetRequest(DefaultClusterCallback callback, byte[] acti
       elements.add(new StructElement(activeDatasetFieldID, activeDatasettlvValue));
 
       final long breadcrumbFieldID = 1L;
-      BaseTLVType breadcrumbtlvValue = new UIntType(breadcrumb);
+      BaseTLVType breadcrumbtlvValue = breadcrumb.<BaseTLVType>map((nonOptionalbreadcrumb) -> new UIntType(nonOptionalbreadcrumb)).orElse(new EmptyType());
       elements.add(new StructElement(breadcrumbFieldID, breadcrumbtlvValue));
 
       StructType commandArgs = new StructType(elements);

src/controller/java/generated/java/chip/devicecontroller/ClusterInfoMapping.java

@@ -26670,15 +26670,15 @@ public Map<String, Map<String, InteractionInfo>> getCommandMap() {
     CommandParameterInfo threadBorderRouterManagementsetActiveDatasetRequestactiveDatasetCommandParameterInfo = new CommandParameterInfo("activeDataset", byte[].class, byte[].class);
     threadBorderRouterManagementsetActiveDatasetRequestCommandParams.put("activeDataset",threadBorderRouterManagementsetActiveDatasetRequestactiveDatasetCommandParameterInfo);
 
-    CommandParameterInfo threadBorderRouterManagementsetActiveDatasetRequestbreadcrumbCommandParameterInfo = new CommandParameterInfo("breadcrumb", Long.class, Long.class);
+    CommandParameterInfo threadBorderRouterManagementsetActiveDatasetRequestbreadcrumbCommandParameterInfo = new CommandParameterInfo("breadcrumb", Optional.class, Long.class);
     threadBorderRouterManagementsetActiveDatasetRequestCommandParams.put("breadcrumb",threadBorderRouterManagementsetActiveDatasetRequestbreadcrumbCommandParameterInfo);
     InteractionInfo threadBorderRouterManagementsetActiveDatasetRequestInteractionInfo = new InteractionInfo(
       (cluster, callback, commandArguments) -> {
         ((ChipClusters.ThreadBorderRouterManagementCluster) cluster)
         .setActiveDatasetRequest((DefaultClusterCallback) callback
         , (byte[])
         commandArguments.get("activeDataset")
-        , (Long)
+        , (Optional<Long>)
         commandArguments.get("breadcrumb")
         );
       },

src/controller/java/generated/java/matter/controller/cluster/clusters/ThreadBorderRouterManagementCluster.kt

@@ -182,7 +182,7 @@ class ThreadBorderRouterManagementCluster(
 
   suspend fun setActiveDatasetRequest(
     activeDataset: ByteArray,
-    breadcrumb: ULong,
+    breadcrumb: ULong?,
     timedInvokeTimeout: Duration? = null
   ) {
     val commandId: UInt = 3u
@@ -194,7 +194,7 @@ class ThreadBorderRouterManagementCluster(
     tlvWriter.put(ContextSpecificTag(TAG_ACTIVE_DATASET_REQ), activeDataset)
 
     val TAG_BREADCRUMB_REQ: Int = 1
-    tlvWriter.put(ContextSpecificTag(TAG_BREADCRUMB_REQ), breadcrumb)
+    breadcrumb?.let { tlvWriter.put(ContextSpecificTag(TAG_BREADCRUMB_REQ), breadcrumb) }
     tlvWriter.endStructure()
 
     val request: InvokeRequest =