Restyle and unit test for expansion

Author: andreilitvin

src/app/codegen-data-model/tests/TestCodegenModelViaMocks.cpp

@@ -1031,6 +1031,24 @@ TEST(TestCodegenModelViaMocks, EmberAttributeInvalidRead)
     }
 }
 
+TEST(TestCodegenModelViaMocks, EmberAttributePathExpansionAccessDeniedRead)
+{
+    UseMockNodeConfig config(gTestNodeConfig);
+    chip::app::CodegenDataModel model;
+    ScopedMockAccessControl accessControl;
+
+    TestReadRequest testRequest(kDenySubjectDescriptor,
+                                ConcreteAttributePath(kMockEndpoint1, MockClusterId(1), MockAttributeId(10)));
+    std::unique_ptr<AttributeValueEncoder> encoder = testRequest.StartEncoding(&model);
+
+    testRequest.request.path.mExpanded = true;
+
+    // For expanded paths, access control failures succeed without encoding anything
+    // This is temporary until ACL checks are moved inside the IM/ReportEngine
+    ASSERT_EQ(model.ReadAttribute(testRequest.request, *encoder), CHIP_NO_ERROR);
+    ASSERT_FALSE(encoder->TriedEncode());
+}
+
 TEST(TestCodegenModelViaMocks, EmberAttributeReadInt32S)
 {
     TestEmberScalarTypeRead<int32_t, ZCL_INT32S_ATTRIBUTE_TYPE>(-1234);

src/app/data-model-interface/DataModel.h

@@ -61,7 +61,7 @@ class DataModel : public DataModelMetadataTree
     ///     - Validation of readability/writability
     ///     - use request.path.mExpanded to skip encoding replies for data according
     ///       to 8.4.3.2 of the spec:
-    ///         > If the path indicates attribute data that is not readable, then the path SHALL 
+    ///         > If the path indicates attribute data that is not readable, then the path SHALL
     ///           be discarded.
     ///         > Else if reading from the attribute in the path requires a privilege that is not
     ///           granted to access the cluster in the path, then the path SHALL be discarded.