Skip to content

Commit 39e83c9

Browse files
authored
Removal of 2 redundant attributes in CameraAVStreamMgmt cluster. (#36478)
SDK update for corresponding Spec change. Remove the CurrentSnapshotConfig and CurrentVideoCodecs as they are captured by the Allocated Video and Snapshot stream attributes. Also, fix a field name in the Snapshotstream allocation command. Run ZAP regen for the corresponding changes.
1 parent 11b6ee7 commit 39e83c9

29 files changed

+423
-1519
lines changed

src/app/zap-templates/zcl/data-model/chip/camera-av-stream-management-cluster.xml

+29-43
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ limitations under the License.
1818
XML generated by Alchemy; DO NOT EDIT.
1919
Source: src/app_clusters/CameraAVStreamManagement.adoc
2020
Parameters: in-progress
21-
Git: 1.3-3824-g29c49ca54
21+
Git: 1.3-3830-g1f08d6f40
2222
-->
2323
<configurator xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../zcl.xsd">
2424
<domain name="Cameras"/>
@@ -239,62 +239,48 @@ Git: 1.3-3824-g29c49ca54
239239
<feature name="VDO"/>
240240
</optionalConform>
241241
</attribute>
242-
<attribute code="0x000E" side="server" define="CURRENT_VIDEO_CODECS" type="array" entryType="VideoCodecEnum" optional="true">
243-
<description>CurrentVideoCodecs</description>
244-
<mandatoryConform>
245-
<feature name="VDO"/>
246-
</mandatoryConform>
247-
</attribute>
248-
<attribute code="0x000F" side="server" define="CURRENT_SNAPSHOT_CONFIG" type="SnapshotParamsStruct" optional="true">
249-
<description>CurrentSnapshotConfig</description>
250-
<mandatoryConform>
251-
<feature name="SNP"/>
252-
</mandatoryConform>
253-
</attribute>
254-
<attribute code="0x0010" side="server" define="FABRICS_USING_CAMERA" type="array" entryType="fabric_idx">FabricsUsingCamera</attribute>
255-
<attribute code="0x0011" side="server" define="ALLOCATED_VIDEO_STREAMS" type="array" entryType="VideoStreamStruct" optional="true">
242+
<attribute code="0x000E" side="server" define="FABRICS_USING_CAMERA" type="array" entryType="fabric_idx">FabricsUsingCamera</attribute>
243+
<attribute code="0x000F" side="server" define="ALLOCATED_VIDEO_STREAMS" type="array" entryType="VideoStreamStruct" optional="true">
256244
<description>AllocatedVideoStreams</description>
257245
<mandatoryConform>
258246
<feature name="VDO"/>
259247
</mandatoryConform>
260248
</attribute>
261-
<attribute code="0x0012" side="server" define="ALLOCATED_AUDIO_STREAMS" type="array" entryType="AudioStreamStruct" optional="true">
249+
<attribute code="0x0010" side="server" define="ALLOCATED_AUDIO_STREAMS" type="array" entryType="AudioStreamStruct" optional="true">
262250
<description>AllocatedAudioStreams</description>
263251
<mandatoryConform>
264252
<feature name="ADO"/>
265253
</mandatoryConform>
266254
</attribute>
267-
<attribute code="0x0013" side="server" define="ALLOCATED_SNAPSHOT_STREAMS" type="array" entryType="SnapshotStreamStruct" optional="true">
255+
<attribute code="0x0011" side="server" define="ALLOCATED_SNAPSHOT_STREAMS" type="array" entryType="SnapshotStreamStruct" optional="true">
268256
<description>AllocatedSnapshotStreams</description>
269257
<mandatoryConform>
270258
<feature name="SNP"/>
271259
</mandatoryConform>
272260
</attribute>
273-
<attribute code="0x0014" side="server" define="RANKED_VIDEO_STREAM_PRIORITIES_LIST" type="array" entryType="StreamTypeEnum" writable="true" optional="true">
261+
<attribute code="0x0012" side="server" define="RANKED_VIDEO_STREAM_PRIORITIES_LIST" type="array" entryType="StreamTypeEnum" optional="true">
274262
<description>RankedVideoStreamPrioritiesList</description>
275-
<access op="read" privilege="administer"/>
276-
<access op="write" privilege="administer"/>
277263
<mandatoryConform>
278264
<feature name="VDO"/>
279265
</mandatoryConform>
280266
</attribute>
281-
<attribute code="0x0015" side="server" define="SOFT_RECORDING_PRIVACY_MODE_ENABLED" type="boolean" default="0" writable="true" optional="true">
267+
<attribute code="0x0013" side="server" define="SOFT_RECORDING_PRIVACY_MODE_ENABLED" type="boolean" default="0" writable="true" optional="true">
282268
<description>SoftRecordingPrivacyModeEnabled</description>
283269
<mandatoryConform>
284270
<feature name="PRIV"/>
285271
</mandatoryConform>
286272
</attribute>
287-
<attribute code="0x0016" side="server" define="SOFT_LIVESTREAM_PRIVACY_MODE_ENABLED" type="boolean" default="0" writable="true" optional="true">
273+
<attribute code="0x0014" side="server" define="SOFT_LIVESTREAM_PRIVACY_MODE_ENABLED" type="boolean" default="0" writable="true" optional="true">
288274
<description>SoftLivestreamPrivacyModeEnabled</description>
289275
<mandatoryConform>
290276
<feature name="PRIV"/>
291277
</mandatoryConform>
292278
</attribute>
293-
<attribute code="0x0017" side="server" define="HARD_PRIVACY_MODE_ON" type="boolean" default="0" optional="true">
279+
<attribute code="0x0015" side="server" define="HARD_PRIVACY_MODE_ON" type="boolean" default="0" optional="true">
294280
<description>HardPrivacyModeOn</description>
295281
<optionalConform/>
296282
</attribute>
297-
<attribute code="0x0018" side="server" define="NIGHT_VISION" type="TriStateAutoEnum" min="0x00" max="0x02" writable="true" optional="true">
283+
<attribute code="0x0016" side="server" define="NIGHT_VISION" type="TriStateAutoEnum" min="0x00" max="0x02" writable="true" optional="true">
298284
<description>NightVision</description>
299285
<access op="read" privilege="manage"/>
300286
<access op="write" privilege="manage"/>
@@ -305,7 +291,7 @@ Git: 1.3-3824-g29c49ca54
305291
</orTerm>
306292
</optionalConform>
307293
</attribute>
308-
<attribute code="0x0019" side="server" define="NIGHT_VISION_ILLUM" type="TriStateAutoEnum" min="0x00" max="0x02" writable="true" optional="true">
294+
<attribute code="0x0017" side="server" define="NIGHT_VISION_ILLUM" type="TriStateAutoEnum" min="0x00" max="0x02" writable="true" optional="true">
309295
<description>NightVisionIllum</description>
310296
<access op="read" privilege="manage"/>
311297
<access op="write" privilege="manage"/>
@@ -316,15 +302,15 @@ Git: 1.3-3824-g29c49ca54
316302
</orTerm>
317303
</optionalConform>
318304
</attribute>
319-
<attribute code="0x001A" side="server" define="VIEWPORT" type="ViewportStruct" writable="true" optional="true">
305+
<attribute code="0x0018" side="server" define="VIEWPORT" type="ViewportStruct" writable="true" optional="true">
320306
<description>Viewport</description>
321307
<access op="read" privilege="manage"/>
322308
<access op="write" privilege="manage"/>
323309
<mandatoryConform>
324310
<feature name="VDO"/>
325311
</mandatoryConform>
326312
</attribute>
327-
<attribute code="0x001B" side="server" define="SPEAKER_MUTED" type="boolean" default="0" writable="true" optional="true">
313+
<attribute code="0x0019" side="server" define="SPEAKER_MUTED" type="boolean" default="0" writable="true" optional="true">
328314
<description>SpeakerMuted</description>
329315
<access op="read" privilege="manage"/>
330316
<access op="write" privilege="manage"/>
@@ -335,7 +321,7 @@ Git: 1.3-3824-g29c49ca54
335321
</andTerm>
336322
</mandatoryConform>
337323
</attribute>
338-
<attribute code="0x001C" side="server" define="SPEAKER_VOLUME_LEVEL" type="int8u" max="254" writable="true" optional="true">
324+
<attribute code="0x001A" side="server" define="SPEAKER_VOLUME_LEVEL" type="int8u" max="254" writable="true" optional="true">
339325
<description>SpeakerVolumeLevel</description>
340326
<access op="read" privilege="manage"/>
341327
<access op="write" privilege="manage"/>
@@ -346,7 +332,7 @@ Git: 1.3-3824-g29c49ca54
346332
</andTerm>
347333
</mandatoryConform>
348334
</attribute>
349-
<attribute code="0x001D" side="server" define="SPEAKER_MAX_LEVEL" type="int8u" max="254" optional="true">
335+
<attribute code="0x001B" side="server" define="SPEAKER_MAX_LEVEL" type="int8u" max="254" optional="true">
350336
<description>SpeakerMaxLevel</description>
351337
<access op="read" privilege="manage"/>
352338
<mandatoryConform>
@@ -356,7 +342,7 @@ Git: 1.3-3824-g29c49ca54
356342
</andTerm>
357343
</mandatoryConform>
358344
</attribute>
359-
<attribute code="0x001E" side="server" define="SPEAKER_MIN_LEVEL" type="int8u" max="254" optional="true">
345+
<attribute code="0x001C" side="server" define="SPEAKER_MIN_LEVEL" type="int8u" max="254" optional="true">
360346
<description>SpeakerMinLevel</description>
361347
<access op="read" privilege="manage"/>
362348
<mandatoryConform>
@@ -366,69 +352,69 @@ Git: 1.3-3824-g29c49ca54
366352
</andTerm>
367353
</mandatoryConform>
368354
</attribute>
369-
<attribute code="0x001F" side="server" define="MICROPHONE_MUTED" type="boolean" default="0" writable="true" optional="true">
355+
<attribute code="0x001D" side="server" define="MICROPHONE_MUTED" type="boolean" default="0" writable="true" optional="true">
370356
<description>MicrophoneMuted</description>
371357
<access op="read" privilege="manage"/>
372358
<access op="write" privilege="manage"/>
373359
<mandatoryConform>
374360
<feature name="ADO"/>
375361
</mandatoryConform>
376362
</attribute>
377-
<attribute code="0x0020" side="server" define="MICROPHONE_VOLUME_LEVEL" type="int8u" max="254" writable="true" optional="true">
363+
<attribute code="0x001E" side="server" define="MICROPHONE_VOLUME_LEVEL" type="int8u" max="254" writable="true" optional="true">
378364
<description>MicrophoneVolumeLevel</description>
379365
<access op="read" privilege="manage"/>
380366
<access op="write" privilege="manage"/>
381367
<mandatoryConform>
382368
<feature name="ADO"/>
383369
</mandatoryConform>
384370
</attribute>
385-
<attribute code="0x0021" side="server" define="MICROPHONE_MAX_LEVEL" type="int8u" max="254" optional="true">
371+
<attribute code="0x001F" side="server" define="MICROPHONE_MAX_LEVEL" type="int8u" max="254" optional="true">
386372
<description>MicrophoneMaxLevel</description>
387373
<access op="read" privilege="manage"/>
388374
<mandatoryConform>
389375
<feature name="ADO"/>
390376
</mandatoryConform>
391377
</attribute>
392-
<attribute code="0x0022" side="server" define="MICROPHONE_MIN_LEVEL" type="int8u" max="254" optional="true">
378+
<attribute code="0x0020" side="server" define="MICROPHONE_MIN_LEVEL" type="int8u" max="254" optional="true">
393379
<description>MicrophoneMinLevel</description>
394380
<access op="read" privilege="manage"/>
395381
<mandatoryConform>
396382
<feature name="ADO"/>
397383
</mandatoryConform>
398384
</attribute>
399-
<attribute code="0x0023" side="server" define="MICROPHONE_AGCENABLED" type="boolean" default="1" writable="true" optional="true">
385+
<attribute code="0x0021" side="server" define="MICROPHONE_AGCENABLED" type="boolean" default="1" writable="true" optional="true">
400386
<description>MicrophoneAGCEnabled</description>
401387
<access op="read" privilege="manage"/>
402388
<access op="write" privilege="manage"/>
403389
<optionalConform>
404390
<feature name="ADO"/>
405391
</optionalConform>
406392
</attribute>
407-
<attribute code="0x0024" side="server" define="IMAGE_ROTATION" type="int16u" max="359" writable="true" optional="true">
393+
<attribute code="0x0022" side="server" define="IMAGE_ROTATION" type="int16u" max="359" writable="true" optional="true">
408394
<description>ImageRotation</description>
409395
<access op="read" privilege="manage"/>
410396
<access op="write" privilege="manage"/>
411397
<optionalConform choice="b" more="true" min="1">
412398
<feature name="ICTL"/>
413399
</optionalConform>
414400
</attribute>
415-
<attribute code="0x0025" side="server" define="IMAGE_FLIP_HORIZONTAL" type="boolean" default="0" writable="true" optional="true">
401+
<attribute code="0x0023" side="server" define="IMAGE_FLIP_HORIZONTAL" type="boolean" default="0" writable="true" optional="true">
416402
<description>ImageFlipHorizontal</description>
417403
<access op="read" privilege="manage"/>
418404
<access op="write" privilege="manage"/>
419405
<optionalConform choice="b" more="true" min="1">
420406
<feature name="ICTL"/>
421407
</optionalConform>
422408
</attribute>
423-
<attribute code="0x0026" side="server" define="IMAGE_FLIP_VERTICAL" type="boolean" default="0" writable="true" optional="true">
409+
<attribute code="0x0024" side="server" define="IMAGE_FLIP_VERTICAL" type="boolean" default="0" writable="true" optional="true">
424410
<description>ImageFlipVertical</description>
425411
<access op="read" privilege="manage"/>
426412
<access op="write" privilege="manage"/>
427413
<optionalConform choice="b" more="true" min="1">
428414
<feature name="ICTL"/>
429415
</optionalConform>
430416
</attribute>
431-
<attribute code="0x0027" side="server" define="LOCAL_VIDEO_RECORDING_ENABLED" type="boolean" default="0" writable="true" optional="true">
417+
<attribute code="0x0025" side="server" define="LOCAL_VIDEO_RECORDING_ENABLED" type="boolean" default="0" writable="true" optional="true">
432418
<description>LocalVideoRecordingEnabled</description>
433419
<access op="read" privilege="manage"/>
434420
<access op="write" privilege="manage"/>
@@ -439,7 +425,7 @@ Git: 1.3-3824-g29c49ca54
439425
</andTerm>
440426
</mandatoryConform>
441427
</attribute>
442-
<attribute code="0x0028" side="server" define="LOCAL_SNAPSHOT_RECORDING_ENABLED" type="boolean" default="0" writable="true" optional="true">
428+
<attribute code="0x0026" side="server" define="LOCAL_SNAPSHOT_RECORDING_ENABLED" type="boolean" default="0" writable="true" optional="true">
443429
<description>LocalSnapshotRecordingEnabled</description>
444430
<access op="read" privilege="manage"/>
445431
<access op="write" privilege="manage"/>
@@ -450,13 +436,13 @@ Git: 1.3-3824-g29c49ca54
450436
</andTerm>
451437
</mandatoryConform>
452438
</attribute>
453-
<attribute code="0x0029" side="server" define="STATUS_LIGHT_ENABLED" type="boolean" default="1" writable="true" optional="true">
439+
<attribute code="0x0027" side="server" define="STATUS_LIGHT_ENABLED" type="boolean" default="1" writable="true" optional="true">
454440
<description>StatusLightEnabled</description>
455441
<access op="read" privilege="manage"/>
456442
<access op="write" privilege="manage"/>
457443
<optionalConform/>
458444
</attribute>
459-
<attribute code="0x002A" side="server" define="STATUS_LIGHT_BRIGHTNESS" type="ThreeLevelAutoEnum" min="0x00" max="0x03" writable="true" optional="true">
445+
<attribute code="0x0028" side="server" define="STATUS_LIGHT_BRIGHTNESS" type="ThreeLevelAutoEnum" min="0x00" max="0x03" writable="true" optional="true">
460446
<description>StatusLightBrightness</description>
461447
<access op="read" privilege="manage"/>
462448
<access op="write" privilege="manage"/>
@@ -546,7 +532,7 @@ Git: 1.3-3824-g29c49ca54
546532
<description>This command SHALL allocate a snapshot stream on the device and return an allocated snapshot stream identifier.</description>
547533
<access op="invoke" privilege="manage"/>
548534
<arg id="1" name="ImageCodec" type="ImageCodecEnum" min="0x00" max="0x00"/>
549-
<arg id="2" name="FrameRate" type="int16u" min="1"/>
535+
<arg id="2" name="MaxFrameRate" type="int16u" min="1"/>
550536
<arg id="3" name="BitRate" type="int32u" min="1"/>
551537
<arg id="4" name="MinResolution" type="VideoResolutionStruct"/>
552538
<arg id="5" name="MaxResolution" type="VideoResolutionStruct"/>

src/app/zap-templates/zcl/zcl-with-test-extensions.json

-1
Original file line numberDiff line numberDiff line change
@@ -677,7 +677,6 @@
677677
"MinViewport",
678678
"MicrophoneCapabilities",
679679
"SpeakerCapabilities",
680-
"CurrentSnapshotConfig",
681680
"Viewport"
682681
]
683682
},

src/app/zap-templates/zcl/zcl.json

-1
Original file line numberDiff line numberDiff line change
@@ -671,7 +671,6 @@
671671
"MinViewport",
672672
"MicrophoneCapabilities",
673673
"SpeakerCapabilities",
674-
"CurrentSnapshotConfig",
675674
"Viewport"
676675
]
677676
},

0 commit comments

Comments
 (0)