Skip to content

Commit 3c53619

Browse files
committed
unwind premature optimization placeholders/comments
1 parent a8c9851 commit 3c53619

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

src/darwin/Framework/CHIP/MTRDevice.mm

-6
Original file line numberDiff line numberDiff line change
@@ -359,10 +359,6 @@ @interface MTRDevice ()
359359

360360
@property (nonatomic) MTRInternalDeviceState internalDeviceState;
361361

362-
// TODO: cache this once I understand the point in the MTRDevice lifecycle that the relevant attributes will be present.
363-
// kmo 22 may 2024 14h55
364-
// @property (nonatomic) MTRDeviceEssentialAttributes * essentialAttributes;
365-
366362
#define MTRDEVICE_SUBSCRIPTION_ATTEMPT_MIN_WAIT_SECONDS (1)
367363
#define MTRDEVICE_SUBSCRIPTION_ATTEMPT_MAX_WAIT_SECONDS (3600)
368364
@property (nonatomic) uint32_t lastSubscriptionAttemptWait;
@@ -1754,8 +1750,6 @@ - (void)_handleEventReport:(NSArray<NSDictionary<NSString *, id> *> *)eventRepor
17541750
BOOL isStartUpEvent = (eventPath.cluster.unsignedLongValue == MTRClusterIDTypeBasicInformationID)
17551751
&& (eventPath.event.unsignedLongValue == MTREventIDTypeClusterBasicInformationEventStartUpID);
17561752
if (isStartUpEvent) {
1757-
// REVIEWERS: this seems like a good place to set up / cache
1758-
// the essential device attributes - is it?
17591753
if (_estimatedStartTimeFromGeneralDiagnosticsUpTime) {
17601754
// If UpTime was received, make use of it as mark of system start time
17611755
MTR_LOG("%@ StartUp event: set estimated start time forward to %@", self,

0 commit comments

Comments
 (0)