Added TODO for FakeMethods. Updated naming for Status to DoorOpen. Updated to boolean as we only have 2 status and int is not needed.

Author: Juan Erasmo Trejo

examples/all-clusters-app/linux/AllClustersCommandDelegate.cpp

@@ -287,41 +287,41 @@ void HandleSimulateLatchPosition(Json::Value & jsonValue)
 }
 
 /**
- * Named pipe handler for simulating a latched switch movement.
+ * Named pipe handler for simulating a Door Opening.
  *
  * Usage example:
  *   echo '{"Name":"SetRefDoorStatus", "EndpointId": 1, "Status": 1}' > /tmp/chip_all_clusters_fifo_1146610
  *
  * JSON Arguments:
  *   - "Name": Must be "SetRefDoorStatus"
- *   - "EndpointId": ID of endpoint having a switch cluster
- *   - "Status": Status of the door, open or closed.
+ *   - "EndpointId": ID of endpoint
+ *   - "DoorOpen": Status of the door, open or closed.
  *
  * @param jsonValue - JSON payload from named pipe
  */
 void SetRefrigetatorDoorStatusHandler(Json::Value & jsonValue)
 {
     bool hasEndpointId = HasNumericField(jsonValue, "EndpointId");
-    bool hasDoorStatus = HasNumericField(jsonValue, "Status");
+    bool hasDoorStatus = HasNumericField(jsonValue, "DoorOpen");
 
     if (!hasEndpointId || !hasDoorStatus)
     {
         std::string inputJson = jsonValue.toStyledString();
         ChipLogError(NotSpecified, "Missing or invalid value for one of EndpointId, Status in %s", inputJson.c_str());
         return;
     }
-    // values to updatethe state
+    // values to update the door status
     EndpointId endpointId = static_cast<EndpointId>(jsonValue["EndpointId"].asUInt());
-    uint8_t doorStatus    = static_cast<uint8_t>(jsonValue["Status"].asUInt());
+    bool doorStatus    = static_cast<bool>(jsonValue["DoorOpen"].asBool());
     ChipLogDetail(NotSpecified, "SetRefrigetatorDoorStatusHandler State -> %d.",doorStatus);
-     if ( doorStatus == 0 ) {        
+     if ( !doorStatus  ) {
         RefrigeratorAlarmServer::Instance().SetMaskValue(endpointId,doorStatus);
         ChipLogDetail(NotSpecified, "Refrigeratoralarm status updated to :%d", doorStatus);
-    }else if (doorStatus == 1){
+    }else if (doorStatus){
         RefrigeratorAlarmServer::Instance().SetMaskValue(endpointId,doorStatus);
         RefrigeratorAlarmServer::Instance().SetStateValue(endpointId,doorStatus);
     }else {
-        ChipLogError(NotSpecified, "Invalid State value to set.");
+        ChipLogError(NotSpecified, "Invalid value to set.");
         return;
     }
 }

src/python_testing/TC_REFALM_2_2.py

@@ -52,7 +52,9 @@
 
 logger = logging.getLogger(__name__)
 
-# Implement fake commands for the RefrigeratorAlarm Cluster #
+# TODO(#37217)  Refactor using generic method.
+# Implement fake commands for the RefrigeratorAlarm Cluster
+# These comands are Disallowed (X) in the spec. 
 # When running those commands must return 0x81 (UNSUPPORTED COMMAND)
 @dataclass
 class FakeReset(ClusterCommand):
@@ -185,11 +187,11 @@ def _send_named_pipe_command(self, command_dict: dict[str, Any]):
         sleep(0.1)
 
     def _send_open_door_command(self):
-        command_dict  = {"Name":"SetRefrigeratorDoorStatus", "EndpointId": self.endpoint, "Status": Clusters.RefrigeratorAlarm.Bitmaps.AlarmBitmap.kDoorOpen}
+        command_dict  = {"Name":"SetRefrigeratorDoorStatus", "EndpointId": self.endpoint, "DoorOpen": Clusters.RefrigeratorAlarm.Bitmaps.AlarmBitmap.kDoorOpen}
         self._send_named_pipe_command(command_dict)
 
     def _send_close_door_commnad(self):
-        command_dict  = {"Name":"SetRefrigeratorDoorStatus", "EndpointId": self.endpoint, "Status": 0}
+        command_dict  = {"Name":"SetRefrigeratorDoorStatus", "EndpointId": self.endpoint, "DoorOpen": 0}
         self._send_named_pipe_command(command_dict)
 
     @async_test_body