You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix python Wi-Fi/Thread setup with manual code (#33933)
* Fix python Wi-Fi/Thread setup with manual code
- Plumbing was missing to pass down the short discriminator
- Passing `--manual-code 1234-567-8901` which only has short
discriminator, would always fail to find device over BLE
Fixes#26907
This PR:
- Adds plumbing to detect short discriminator in Python controller
- Improves code-based setup in CHIPDeviceController to honor the
SetupDiscriminator value, including whether short/long.
Testing done:
- Ran `python3 src/python_testing/TC_SC_3_6.py --commissioning-method ble-wifi --wifi-ssid MySsid --wifi-passphrase Secret123 --manual-code 2168-374-4904 --storage-path kvs1`
- Before fix, discriminator always mismatched.
- After fix, commissioning succeeds.
- Unit tests and other integration tests still pass
* Restyled by clang-format
* Restyled by autopep8
* Add warning about GetDiscriminator
* Improve unit test
* Fix tests
* Address review comments
* Restyled by clang-format
---------
Co-authored-by: Restyled.io <commits@restyled.io>
0 commit comments