Skip to content

Commit 3dc64b8

Browse files
committed
[Docker] Add terms and conditions app to chip-cert-bins image
Add the terms and conditions application binary to the chip-cert-bins Docker image build for both x64 and arm64 architectures. This change includes: - Adding build target for terms-and-conditions app - Copying the built binary to the final image - Adding environment variable reference in CI test configuration This addition will support upcoming CI test requirements for the terms and conditions functionality.
1 parent 87de90d commit 3dc64b8

File tree

4 files changed

+10
-2
lines changed

4 files changed

+10
-2
lines changed

.github/workflows/tests.yaml

+2
Original file line numberDiff line numberDiff line change
@@ -502,6 +502,7 @@ jobs:
502502
--target linux-x64-fabric-bridge-rpc-ipv6only-no-ble-no-wifi-clang \
503503
--target linux-x64-fabric-sync-ipv6only-no-ble-no-wifi-clang \
504504
--target linux-x64-light-data-model-no-unique-id-ipv6only-no-ble-no-wifi-clang \
505+
--target linux-x64-terms-and-conditions \
505506
--target linux-x64-python-bindings \
506507
build \
507508
--copy-artifacts-to objdir-clone \
@@ -520,6 +521,7 @@ jobs:
520521
echo "FABRIC_BRIDGE_APP: out/linux-x64-fabric-bridge-rpc-ipv6only-no-ble-no-wifi-clang/fabric-bridge-app" >> /tmp/test_env.yaml
521522
echo "FABRIC_SYNC_APP: out/linux-x64-fabric-sync-ipv6only-no-ble-no-wifi-clang/fabric-sync" >> /tmp/test_env.yaml
522523
echo "LIGHTING_APP_NO_UNIQUE_ID: out/linux-x64-light-data-model-no-unique-id-ipv6only-no-ble-no-wifi-clang/chip-lighting-app" >> /tmp/test_env.yaml
524+
echo "TERMS_AND_CONDITIONS_APP: out/linux-x64-terms-and-conditions/chip-terms-and-conditions-app" >> /tmp/test_env.yaml
523525
echo "TRACE_APP: out/trace_data/app-{SCRIPT_BASE_NAME}" >> /tmp/test_env.yaml
524526
echo "TRACE_TEST_JSON: out/trace_data/test-{SCRIPT_BASE_NAME}" >> /tmp/test_env.yaml
525527
echo "TRACE_TEST_PERFETTO: out/trace_data/test-{SCRIPT_BASE_NAME}" >> /tmp/test_env.yaml

integrations/docker/images/chip-cert-bins/Dockerfile

+5
Original file line numberDiff line numberDiff line change
@@ -168,6 +168,7 @@ RUN case ${TARGETPLATFORM} in \
168168
--target linux-x64-fabric-admin-rpc-ipv6only \
169169
--target linux-x64-light-data-model-no-unique-id-ipv6only \
170170
--target linux-x64-network-manager-ipv6only \
171+
--target linux-x64-terms-and-conditions \
171172
build \
172173
&& mv out/linux-x64-chip-tool-ipv6only-platform-mdns/chip-tool out/chip-tool \
173174
&& mv out/linux-x64-shell-ipv6only-platform-mdns/chip-shell out/chip-shell \
@@ -192,6 +193,7 @@ RUN case ${TARGETPLATFORM} in \
192193
&& mv out/linux-x64-fabric-admin-rpc-ipv6only/fabric-admin out/fabric-admin \
193194
&& mv out/linux-x64-light-data-model-no-unique-id-ipv6only/chip-lighting-app out/chip-lighting-data-model-no-unique-id-app \
194195
&& mv out/linux-x64-network-manager-ipv6only/matter-network-manager-app out/matter-network-manager-app \
196+
&& mv out/linux-x64-terms-and-conditions/chip-terms-and-conditions-app out/chip-terms-and-conditions-app \
195197
;; \
196198
"linux/arm64")\
197199
set -x \
@@ -220,6 +222,7 @@ RUN case ${TARGETPLATFORM} in \
220222
--target linux-arm64-fabric-admin-rpc-ipv6only \
221223
--target linux-arm64-light-data-model-no-unique-id-ipv6only \
222224
--target linux-arm64-network-manager-ipv6only \
225+
--target linux-arm64-terms-and-conditions \
223226
build \
224227
&& mv out/linux-arm64-chip-tool-ipv6only-platform-mdns/chip-tool out/chip-tool \
225228
&& mv out/linux-arm64-shell-ipv6only-platform-mdns/chip-shell out/chip-shell \
@@ -244,6 +247,7 @@ RUN case ${TARGETPLATFORM} in \
244247
&& mv out/linux-arm64-fabric-admin-rpc-ipv6only/fabric-admin out/fabric-admin \
245248
&& mv out/linux-arm64-light-data-model-no-unique-id-ipv6only/chip-lighting-app out/chip-lighting-data-model-no-unique-id-app \
246249
&& mv out/linux-arm64-network-manager-ipv6only/matter-network-manager-app out/matter-network-manager-app \
250+
&& mv out/linux-arm64-terms-and-conditions/chip-terms-and-conditions-app out/chip-terms-and-conditions-app \
247251
;; \
248252
*) ;; \
249253
esac
@@ -283,6 +287,7 @@ COPY --from=chip-build-cert-bins /root/connectedhomeip/out/fabric-bridge-app app
283287
COPY --from=chip-build-cert-bins /root/connectedhomeip/out/fabric-admin apps/fabric-admin
284288
COPY --from=chip-build-cert-bins /root/connectedhomeip/out/chip-lighting-data-model-no-unique-id-app apps/chip-lighting-data-model-no-unique-id-app
285289
COPY --from=chip-build-cert-bins /root/connectedhomeip/out/matter-network-manager-app apps/matter-network-manager-app
290+
COPY --from=chip-build-cert-bins /root/connectedhomeip/out/chip-terms-and-conditions-app apps/chip-terms-and-conditions-app
286291

287292
# Create symbolic links for now since this allows users to use existing configurations
288293
# for running just `app-name` instead of `apps/app-name`

scripts/build/builders/host.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -282,8 +282,8 @@ def OutputNames(self):
282282
yield 'water-leak-detector-app'
283283
yield 'water-leak-detector-app.map'
284284
elif self == HostApp.TERMS_AND_CONDITIONS:
285-
yield 'terms-and-conditions-app'
286-
yield 'terms-and-conditions-app.map'
285+
yield 'chip-terms-and-conditions-app'
286+
yield 'chip-terms-and-conditions-app.map'
287287
else:
288288
raise Exception('Unknown app type: %r' % self)
289289

scripts/tests/local.py

+1
Original file line numberDiff line numberDiff line change
@@ -387,6 +387,7 @@ def as_runner(path):
387387
FABRIC_SYNC_APP: {
388388
as_runner(f'out/{target_prefix}-fabric-sync-no-ble-no-wifi-ipv6only-clang-boringssl/fabric-sync')}
389389
LIGHTING_APP_NO_UNIQUE_ID: {as_runner(f'out/{target_prefix}-light-data-model-no-unique-id-ipv6only-no-ble-no-wifi-clang/chip-lighting-app')}
390+
TERMS_AND_CONDITIONS_APP: {as_runner(f'out/{target_prefix}-terms-and-conditions/chip-terms-and-conditions-app')}
390391
TRACE_APP: out/trace_data/app-{{SCRIPT_BASE_NAME}}
391392
TRACE_TEST_JSON: out/trace_data/test-{{SCRIPT_BASE_NAME}}
392393
TRACE_TEST_PERFETTO: out/trace_data/test-{{SCRIPT_BASE_NAME}}

0 commit comments

Comments
 (0)