Refactor Logging and Clean Up Redundant Code

Author: brosahay

examples/platform/silabs/BaseApplication.cpp

@@ -820,7 +820,7 @@ void BaseApplication::DoProvisioningReset()
         CHIP_ERROR err = Server::GetInstance().GetCommissioningWindowManager().OpenBasicCommissioningWindow();
         if (err != CHIP_NO_ERROR)
         {
-            SILABS_LOG("Failed to open the Basic Commissioning Window");
+            ChipLogError(AppServer, "Failed to open the Basic Commissioning Window");
         }
     });
 }
@@ -838,7 +838,7 @@ void BaseApplication::OnPlatformEvent(const ChipDeviceEvent * event, intptr_t)
         VerifyOrReturn(event->InternetConnectivityChange.IPv4 == kConnectivity_Established);
         if (DIC_OK != dic_init(dic::control::subscribeCB))
         {
-            SILABS_LOG("Failed to initialize DIC module\n");
+            ChipLogError(AppServer, "dic_init failed");
         }
 #endif // DIC_ENABLE
         break;
@@ -855,16 +855,6 @@ void BaseApplication::OnPlatformEvent(const ChipDeviceEvent * event, intptr_t)
     default:
         break;
     }
-#ifdef DIC_ENABLE
-    else if (event->Type == DeviceEventType::kInternetConnectivityChange)
-    {
-        VerifyOrReturn(event->InternetConnectivityChange.IPv4 == kConnectivity_Established);
-        if (DIC_OK != dic_init(dic::control::subscribeCB))
-        {
-            ChipLogDetail(AppServer, "Failed to initialize DIC module");
-        }
-    }
-#endif // DIC_ENABLE
 }
 
 void BaseApplication::OutputQrCode(bool refreshLCD)

examples/platform/silabs/SiWx917/SiWx917/sl_wifi_if.cpp

@@ -306,25 +306,6 @@ void sl_si91x_invoke_btn_press_event()
     }
 #endif // ENABLE_CHIP_SHELL
 }
-
-/******************************************************************
- * @fn   sl_app_sleep_ready()
- * @brief
- *       Called from the supress ticks from tickless to check if it
- *       is ok to go to sleep
- * @param[in] None
- * @return
- *        None
- *********************************************************************/
-uint32_t sl_app_sleep_ready()
-{
-    VerifyOrReturnError(wfx_rsi.dev_state & WFX_RSI_ST_SLEEP_READY, false);
-#if DISPLAY_ENABLED
-    // Powering down the LCD
-    sl_memlcd_power_on(NULL, false);
-#endif /* DISPLAY_ENABLED */
-    return true;
-}
 #endif // SLI_SI91X_MCU_INTERFACE
 
 /******************************************************************