Ensure SYSTEM_STATS_INCREMENT only on successful Timer allocation in SystemTimer.h (#36690)

BoB13-Matter · web-flow · commit 4c69001a0ace · 2024-12-02T15:26:18.000Z
* Fix: Ensure SYSTEM_STATS_INCREMENT only on successful Timer allocation

* Update SystemTimer.h
diff --git a/src/system/SystemTimer.h b/src/system/SystemTimer.h
@@ -204,7 +204,11 @@ class TimerPool
     Timer * Create(Layer & systemLayer, System::Clock::Timestamp awakenTime, TimerCompleteCallback onComplete, void * appState)
     {
         Timer * timer = mTimerPool.CreateObject(systemLayer, awakenTime, onComplete, appState);
-        SYSTEM_STATS_INCREMENT(Stats::kSystemLayer_NumTimers);
+        if (timer != nullptr)
+        {
+            SYSTEM_STATS_INCREMENT(Stats::kSystemLayer_NumTimers);
+        }
+
         return timer;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -204,7 +204,11 @@ class TimerPool`
`204`	`204`	`Timer * Create(Layer & systemLayer, System::Clock::Timestamp awakenTime, TimerCompleteCallback onComplete, void * appState)`
`205`	`205`	`{`
`206`	`206`	`Timer * timer = mTimerPool.CreateObject(systemLayer, awakenTime, onComplete, appState);`
`207`		`- SYSTEM_STATS_INCREMENT(Stats::kSystemLayer_NumTimers);`
	`207`	`+ if (timer != nullptr)`
	`208`	`+ {`
	`209`	`+ SYSTEM_STATS_INCREMENT(Stats::kSystemLayer_NumTimers);`
	`210`	`+ }`
	`211`	`+`
`208`	`212`	`return timer;`
`209`	`213`	`}`
`210`	`214`