[ESP32] Backport nimble and bluedroid fixes to v1.4-branch. (#37800)

* [ESP32]: Added the missing ble_store_config_init api to fix ble_bonding (#37705)

* [ESP32]: Fixed the crash due to ble_hs_is_enabled check bypass (#37354)

* [ESP32]: Fixed the bluedroid commissioning with latest chip-tool (#37786)

- Added the indicate flag instead of notify as per spec in
  bluedroid implementation.
- Fixes the commissioning failure due to "No valid C2" error.

Author: shripad621git

src/platform/ESP32/BLEManagerImpl.h

@@ -227,6 +227,7 @@ class BLEManagerImpl final : public BLEManager,
         kUseCustomDeviceName      = 0x0400, /**< The application has configured a custom BLE device name. */
         kAdvertisingRefreshNeeded = 0x0800, /**< The advertising configuration/state in ESP BLE layer needs to be updated. */
         kExtAdvertisingEnabled    = 0x1000, /**< The application has enabled Extended BLE announcement. */
+        kBleDeinitAndMemReleased  = 0x2000, /**< The ble is deinitialized and memory is reclaimed. */
     };
 
     enum

src/platform/ESP32/bluedroid/BLEManagerImpl.cpp

@@ -100,8 +100,8 @@ const uint8_t UUID_CHIPoBLEChar_TX[]      = { 0x12, 0x9D, 0x9F, 0x42, 0x9C, 0x4F
 const uint8_t ShortUUID_CHIPoBLE_CharTx_Desc[] = { 0x02, 0x29 };
 #endif
 
-const uint8_t CharProps_ReadNotify = ESP_GATT_CHAR_PROP_BIT_READ | ESP_GATT_CHAR_PROP_BIT_NOTIFY;
-const uint8_t CharProps_Write      = ESP_GATT_CHAR_PROP_BIT_WRITE;
+const uint8_t CharProps_ReadIndicate = ESP_GATT_CHAR_PROP_BIT_READ | ESP_GATT_CHAR_PROP_BIT_INDICATE;
+const uint8_t CharProps_Write        = ESP_GATT_CHAR_PROP_BIT_WRITE;
 
 // Offsets into CHIPoBLEGATTAttrs for specific attributes.
 enum
@@ -131,7 +131,7 @@ const esp_gatts_attr_db_t CHIPoBLEGATTAttrs[] = {
 
     // Characteristic declaration
     { { ESP_GATT_AUTO_RSP },
-      { ESP_UUID_LEN_16, (uint8_t *) UUID_CharDecl, ESP_GATT_PERM_READ, 1, 1, (uint8_t *) &CharProps_ReadNotify } },
+      { ESP_UUID_LEN_16, (uint8_t *) UUID_CharDecl, ESP_GATT_PERM_READ, 1, 1, (uint8_t *) &CharProps_ReadIndicate } },
     // Characteristic value
     { { ESP_GATT_RSP_BY_APP }, { ESP_UUID_LEN_128, (uint8_t *) UUID_CHIPoBLEChar_TX, ESP_GATT_PERM_READ, 512, 0, NULL } },
     // Client characteristic configuration description (CCCD) value
@@ -568,7 +568,7 @@ void BLEManagerImpl::gattc_profile_event_handler(esp_gattc_cb_event_t event, esp
                         {
                             gl_profile_tab[PROFILE_A_APP_ID].write_char_handle = char_elem_result[i].char_handle;
                         }
-                        else if (char_elem_result[i].properties & CharProps_ReadNotify)
+                        else if (char_elem_result[i].properties & CharProps_ReadIndicate)
                         {
                             gl_profile_tab[PROFILE_A_APP_ID].notify_char_handle = char_elem_result[i].char_handle;
                             esp_ble_gattc_register_for_notify(gattc_if, gl_profile_tab[PROFILE_A_APP_ID].remote_bda,

src/platform/ESP32/nimble/BLEManagerImpl.cpp

@@ -70,6 +70,9 @@
 #include "services/gap/ble_svc_gap.h"
 #include "services/gatt/ble_svc_gatt.h"
 
+// Not declared in any header file, hence requires a forward declaration.
+extern "C" void ble_store_config_init(void);
+
 #define MAX_ADV_DATA_LEN 31
 #define CHIP_ADV_DATA_TYPE_FLAGS 0x01
 #define CHIP_ADV_DATA_FLAGS 0x06
@@ -244,6 +247,12 @@ CHIP_ERROR BLEManagerImpl::_Init()
 
 void BLEManagerImpl::_Shutdown()
 {
+    if (mFlags.Has(Flags::kBleDeinitAndMemReleased))
+    {
+        ChipLogProgress(DeviceLayer, "Ble already deinitialized, returning from ShutDown flow");
+        return;
+    }
+
     CancelBleAdvTimeoutTimer();
 
     BleLayer::Shutdown();
@@ -712,13 +721,15 @@ CHIP_ERROR BLEManagerImpl::MapBLEError(int bleErr)
         return CHIP_ERROR(ChipError::Range::kPlatform, CHIP_DEVICE_CONFIG_ESP32_BLE_ERROR_MIN + bleErr);
     }
 }
+
 void BLEManagerImpl::CancelBleAdvTimeoutTimer(void)
 {
     if (SystemLayer().IsTimerActive(BleAdvTimeoutHandler, nullptr))
     {
         SystemLayer().CancelTimer(BleAdvTimeoutHandler, nullptr);
     }
 }
+
 void BLEManagerImpl::StartBleAdvTimeoutTimer(uint32_t aTimeoutInMs)
 {
     CancelBleAdvTimeoutTimer();
@@ -729,6 +740,7 @@ void BLEManagerImpl::StartBleAdvTimeoutTimer(uint32_t aTimeoutInMs)
         ChipLogError(DeviceLayer, "Failed to start BledAdv timeout timer");
     }
 }
+
 void BLEManagerImpl::DriveBLEState(void)
 {
     CHIP_ERROR err = CHIP_NO_ERROR;
@@ -739,6 +751,11 @@ void BLEManagerImpl::DriveBLEState(void)
         mFlags.Set(Flags::kAsyncInitCompleted);
     }
 
+    if (mFlags.Has(Flags::kBleDeinitAndMemReleased))
+    {
+        return;
+    }
+
     // Initializes the ESP BLE layer if needed.
     if (mServiceMode == ConnectivityManager::kCHIPoBLEServiceMode_Enabled && !mFlags.Has(Flags::kESPBLELayerInitialized))
     {
@@ -844,7 +861,7 @@ void BLEManagerImpl::DriveBLEState(void)
     if (mServiceMode != ConnectivityManager::kCHIPoBLEServiceMode_Enabled && mFlags.Has(Flags::kGATTServiceStarted))
     {
         DeinitESPBleLayer();
-        mFlags.ClearAll();
+        mFlags.ClearAll().Set(Flags::kBleDeinitAndMemReleased);
     }
 
 exit:
@@ -956,6 +973,7 @@ CHIP_ERROR BLEManagerImpl::InitESPBleLayer(void)
         }
     }
 
+    ble_store_config_init();
     nimble_port_freertos_init(bleprph_host_task);
 
     xSemaphoreTake(semaphoreHandle, portMAX_DELAY);