Skip to content

Commit 4f14a6c

Browse files
woody-applewoody-apple
authored
Removing timeouts from jobs (#27447)
1 parent 2f33181 commit 4f14a6c

36 files changed

+1
-250
lines changed

‎.github/workflows/build.yaml

-31
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ env:
3737
jobs:
3838
build_linux_gcc_debug:
3939
name: Build on Linux (gcc_debug)
40-
timeout-minutes: 85
4140

4241
runs-on: ubuntu-latest
4342
if: github.actor != 'restyled-io[bot]'
@@ -88,7 +87,6 @@ jobs:
8887
.environment
8988
build_overrides/pigweed_environment.gni
9089
- name: Bootstrap
91-
timeout-minutes: 10
9290
run: bash scripts/bootstrap.sh
9391
- name: Uploading bootstrap logs
9492
uses: actions/upload-artifact@v3
@@ -107,10 +105,8 @@ jobs:
107105
- name: Setup Build
108106
run: scripts/build/gn_gen.sh --args="chip_config_memory_debug_checks=true chip_config_memory_debug_dmalloc=false"
109107
- name: Run Build
110-
timeout-minutes: 20
111108
run: scripts/run_in_build_env.sh "ninja -C ./out"
112109
- name: Run Tests
113-
timeout-minutes: 30
114110
run: scripts/tests/gn_tests.sh
115111
# TODO Log Upload https://github.com/project-chip/connectedhomeip/issues/2227
116112
# TODO https://github.com/project-chip/connectedhomeip/issues/1512
@@ -123,17 +119,14 @@ jobs:
123119
- name: Setup Build Without Detail Logging
124120
run: scripts/build/gn_gen.sh --args="chip_detail_logging=false"
125121
- name: Run Build Without Detail Logging
126-
timeout-minutes: 20
127122
run: scripts/run_in_build_env.sh "ninja -C ./out"
128123
- name: Setup Build Without Progress Logging
129124
run: scripts/build/gn_gen.sh --args="chip_detail_logging=false chip_progress_logging=false"
130125
- name: Run Build Without Progress Logging
131-
timeout-minutes: 20
132126
run: scripts/run_in_build_env.sh "ninja -C ./out"
133127
- name: Setup Build Without Error Logging
134128
run: scripts/build/gn_gen.sh --args="chip_detail_logging=false chip_progress_logging=false chip_error_logging=false"
135129
- name: Run Build Without Error Logging
136-
timeout-minutes: 20
137130
run: scripts/run_in_build_env.sh "ninja -C ./out"
138131
- name: Uploading core files
139132
uses: actions/upload-artifact@v3
@@ -189,7 +182,6 @@ jobs:
189182

190183
build_linux:
191184
name: Build on Linux (fake, gcc_release, clang, simulated)
192-
timeout-minutes: 150
193185

194186
runs-on: ubuntu-latest
195187
if: github.actor != 'restyled-io[bot]'
@@ -240,7 +232,6 @@ jobs:
240232
.environment
241233
build_overrides/pigweed_environment.gni
242234
- name: Bootstrap
243-
timeout-minutes: 10
244235
run: bash scripts/bootstrap.sh
245236
- name: Uploading bootstrap logs
246237
uses: actions/upload-artifact@v3
@@ -256,21 +247,18 @@ jobs:
256247
with:
257248
languages: "cpp"
258249
- name: Setup and Build Simulated Device
259-
timeout-minutes: 20
260250
run: |
261251
BUILD_TYPE=simulated
262252
GN_ARGS='chip_tests_zap_config="app1" chip_project_config_include_dirs=["../../examples/placeholder/linux/apps/app1/include", "../../config/standalone"] chip_config_network_layer_ble=false'
263253
CHIP_ROOT_PATH=examples/placeholder/linux
264254
CHIP_ROOT_PATH="$CHIP_ROOT_PATH" BUILD_TYPE="$BUILD_TYPE" scripts/build/gn_gen.sh --args="$GN_ARGS"
265255
scripts/run_in_build_env.sh "ninja -C ./out/$BUILD_TYPE"
266256
- name: Setup Build, Run Build and Run Tests
267-
timeout-minutes: 90
268257
run: |
269258
BUILD_TYPE=gcc_release scripts/build/gn_gen.sh --args="is_debug=false"
270259
scripts/run_in_build_env.sh "ninja -C ./out/gcc_release"
271260
BUILD_TYPE=gcc_release scripts/tests/gn_tests.sh
272261
- name: Run Tests with sanitizers
273-
timeout-minutes: 60
274262
env:
275263
LSAN_OPTIONS: detect_leaks=1
276264
run: |
@@ -287,11 +275,9 @@ jobs:
287275
BUILD_TYPE=sanitizers scripts/tests/gn_tests.sh
288276
done
289277
- name: Ensure codegen is done for sanitize
290-
timeout-minutes: 45
291278
run: |
292279
./scripts/run_in_build_env.sh "./scripts/run_codegen_targets.sh out/sanitizers"
293280
- name: Clang-tidy validation
294-
timeout-minutes: 60
295281
run: |
296282
./scripts/run_in_build_env.sh \
297283
"./scripts/run-clang-tidy-on-compile-commands.py \
@@ -300,7 +286,6 @@ jobs:
300286
check \
301287
"
302288
- name: Build using build_examples.py
303-
timeout-minutes: 60
304289
run: |
305290
./scripts/run_in_build_env.sh \
306291
"./scripts/build/build_examples.py \
@@ -315,7 +300,6 @@ jobs:
315300
- name: Clean output
316301
run: rm -rf ./out
317302
- name: Build using build_examples.py (pregen)
318-
timeout-minutes: 60
319303
run: |
320304
./scripts/run_in_build_env.sh \
321305
"./scripts/build/build_examples.py \
@@ -337,7 +321,6 @@ jobs:
337321
rm -rf ./zzz_pregenerated
338322
mv scripts/codegen.py.renamed scripts/codegen.py
339323
- name: Run fake linux tests with build_examples
340-
timeout-minutes: 15
341324
run: |
342325
./scripts/run_in_build_env.sh \
343326
"./scripts/build/build_examples.py --target linux-fake-tests build"
@@ -395,7 +378,6 @@ jobs:
395378

396379
build_linux_python_lib:
397380
name: Build on Linux (python_lib)
398-
timeout-minutes: 60
399381

400382
runs-on: ubuntu-latest
401383
if: github.actor != 'restyled-io[bot]'
@@ -441,33 +423,28 @@ jobs:
441423
.environment
442424
build_overrides/pigweed_environment.gni
443425
- name: Bootstrap
444-
timeout-minutes: 10
445426
run: bash scripts/bootstrap.sh
446427

447428
- name: Setup Build, Run Build and Run Tests
448-
timeout-minutes: 50
449429
run: |
450430
scripts/build/gn_gen.sh --args="enable_rtti=true enable_pylib=true chip_config_memory_debug_checks=false chip_config_memory_debug_dmalloc=false"
451431
scripts/run_in_build_env.sh "ninja -C ./out"
452432
scripts/tests/gn_tests.sh
453433
- name: Run Python library specific unit tests
454-
timeout-minutes: 5
455434
run: |
456435
scripts/run_in_build_env.sh 'pip3 install ./out/controller/python/chip_core-0.0-cp37-abi3-linux_x86_64.whl'
457436
scripts/run_in_build_env.sh 'pip3 install ./out/controller/python/chip_clusters-0.0-py3-none-any.whl'
458437
scripts/run_in_build_env.sh 'pip3 install ./out/controller/python/chip_repl-0.0-py3-none-any.whl'
459438
scripts/run_in_build_env.sh '(cd src/controller/python/test/unit_tests/ && python3 -m unittest -v)'
460439
461440
- name: Run Python Setup Payload Generator Test
462-
timeout-minutes: 20
463441
run: |
464442
scripts/run_in_build_env.sh 'scripts/examples/gn_build_example.sh examples/chip-tool out/'
465443
scripts/run_in_build_env.sh 'pip3 install -r src/setup_payload/python/requirements.txt'
466444
scripts/run_in_build_env.sh 'python3 src/setup_payload/tests/run_python_setup_payload_gen_test.py out/chip-tool'
467445
468446
build_darwin:
469447
name: Build on Darwin (clang, python_lib, simulated)
470-
timeout-minutes: 200
471448
runs-on: macos-latest
472449
if: github.actor != 'restyled-io[bot]'
473450

@@ -500,7 +477,6 @@ jobs:
500477
.environment
501478
build_overrides/pigweed_environment.gni
502479
- name: Bootstrap
503-
timeout-minutes: 25
504480
run: bash scripts/bootstrap.sh
505481
- name: Uploading bootstrap logs
506482
uses: actions/upload-artifact@v3
@@ -517,15 +493,13 @@ jobs:
517493
with:
518494
languages: "cpp"
519495
- name: Setup and Build Simulated Device
520-
timeout-minutes: 20
521496
run: |
522497
BUILD_TYPE=simulated
523498
GN_ARGS='chip_tests_zap_config="app1" chip_project_config_include_dirs=["../../examples/placeholder/linux/apps/app1/include", "../../config/standalone"] chip_config_network_layer_ble=false'
524499
CHIP_ROOT_PATH=examples/placeholder/linux
525500
CHIP_ROOT_PATH="$CHIP_ROOT_PATH" BUILD_TYPE="$BUILD_TYPE" scripts/build/gn_gen.sh --args="$GN_ARGS"
526501
scripts/run_in_build_env.sh "ninja -C ./out/$BUILD_TYPE"
527502
- name: Setup Build, Run Build and Run Tests
528-
timeout-minutes: 120
529503
# We can't enable leak checking here in LSAN_OPTIONS, because on
530504
# Darwin that's only supported with a new enough clang, and we're
531505
# not building with the pigweed clang here.
@@ -547,11 +521,9 @@ jobs:
547521
BUILD_TYPE=$BUILD_TYPE scripts/tests/gn_tests.sh
548522
done
549523
- name: Ensure codegen is done for sanitize
550-
timeout-minutes: 45
551524
run: |
552525
./scripts/run_in_build_env.sh "./scripts/run_codegen_targets.sh out/default"
553526
- name: Clang-tidy validation
554-
timeout-minutes: 60
555527
run: |
556528
./scripts/run_in_build_env.sh \
557529
"./scripts/run-clang-tidy-on-compile-commands.py \
@@ -599,7 +571,6 @@ jobs:
599571

600572
build_linux_gcc_coverage:
601573
name: Build on Linux (coverage)
602-
timeout-minutes: 85
603574

604575
runs-on: ubuntu-latest
605576
if: github.actor != 'restyled-io[bot]'
@@ -637,7 +608,6 @@ jobs:
637608
.environment
638609
build_overrides/pigweed_environment.gni
639610
- name: Bootstrap
640-
timeout-minutes: 10
641611
run: bash scripts/bootstrap.sh
642612
- name: Uploading bootstrap logs
643613
uses: actions/upload-artifact@v3
@@ -649,5 +619,4 @@ jobs:
649619
.environment/pigweed-venv/*.log
650620
651621
- name: Run Build Coverage
652-
timeout-minutes: 30
653622
run: ./scripts/build_coverage.sh

‎.github/workflows/chef.yaml

-3
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,6 @@ jobs:
6363
.environment
6464
build_overrides/pigweed_environment.gni
6565
- name: Bootstrap
66-
timeout-minutes: 10
6766
run: bash scripts/bootstrap.sh
6867
- name: CI Examples Linux
6968
shell: bash
@@ -104,7 +103,6 @@ jobs:
104103
.environment
105104
build_overrides/pigweed_environment.gni
106105
- name: Bootstrap
107-
timeout-minutes: 10
108106
run: bash scripts/bootstrap.sh
109107
- name: CI Examples ESP32
110108
shell: bash
@@ -145,7 +143,6 @@ jobs:
145143
.environment
146144
build_overrides/pigweed_environment.gni
147145
- name: Bootstrap
148-
timeout-minutes: 10
149146
run: bash scripts/bootstrap.sh
150147
- name: CI Examples NRFConnect
151148
shell: bash

‎.github/workflows/cirque.yaml

+1-6
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ env:
3232
jobs:
3333
cirque:
3434
name: Cirque
35-
timeout-minutes: 90
3635

3736
env:
3837
DOCKER_RUN_VERSION: 0.7.3
@@ -79,7 +78,6 @@ jobs:
7978
.environment
8079
build_overrides/pigweed_environment.gni
8180
- name: Bootstrap
82-
timeout-minutes: 15
8381
run: |
8482
integrations/docker/images/chip-build-cirque/run.sh \
8583
-- sh -c " \
@@ -94,8 +92,8 @@ jobs:
9492
- uses: Wandalen/wretry.action@v1.3.0
9593
name: Cirque Bootstrap cache
9694
if: ${{ !env.ACT }}
97-
timeout-minutes: 10
9895
continue-on-error: true
96+
timeout-minutes: 10
9997
with:
10098
action: buildjet/cache@v3
10199
attempt_limit: 3
@@ -105,7 +103,6 @@ jobs:
105103
restore-keys: ${{ runner.os }}-cirque-
106104
path: ${{ env.GITHUB_CACHE_PATH }}
107105
- name: Cirque Bootstrap
108-
timeout-minutes: 15
109106
run: |
110107
integrations/docker/images/chip-build-cirque/run.sh \
111108
--env GITHUB_ACTION_RUN=1 \
@@ -122,15 +119,13 @@ jobs:
122119
if_true: "${{ github.sha }}"
123120
if_false: "pull-${{ github.event.pull_request.number }}"
124121
- name: Build Binaries
125-
timeout-minutes: 30
126122
run: |
127123
integrations/docker/images/chip-build-cirque/run.sh \
128124
-- sh -c " \
129125
git config --global --add safe.directory '*' \
130126
&& scripts/build/gn_gen_cirque.sh \
131127
"
132128
- name: Run Tests
133-
timeout-minutes: 45
134129
run: |
135130
integrations/docker/images/chip-build-cirque/run.sh \
136131
--env LOG_DIR=/tmp/cirque_test_output \

‎.github/workflows/darwin-tests.yaml

-5
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ env:
3434
jobs:
3535
test_suites_chip_tool_darwin:
3636
name: Test Suites - Darwin
37-
timeout-minutes: 150
3837

3938
strategy:
4039
matrix:
@@ -82,7 +81,6 @@ jobs:
8281
.environment
8382
build_overrides/pigweed_environment.gni
8483
- name: Bootstrap
85-
timeout-minutes: 25
8684
run: bash scripts/bootstrap.sh
8785
- name: Uploading bootstrap logs
8886
uses: actions/upload-artifact@v3
@@ -112,7 +110,6 @@ jobs:
112110
run: xcodebuild clean
113111
working-directory: src/darwin/Framework
114112
- name: Build Apps
115-
timeout-minutes: 90
116113
run: |
117114
./scripts/run_in_build_env.sh \
118115
"./scripts/build/build_examples.py \
@@ -127,7 +124,6 @@ jobs:
127124
--copy-artifacts-to objdir-clone \
128125
"
129126
- name: Run Tests
130-
timeout-minutes: 65
131127
run: |
132128
./scripts/run_in_build_env.sh \
133129
"./scripts/tests/run_test_suite.py \
@@ -144,7 +140,6 @@ jobs:
144140
--bridge-app ./out/darwin-x64-bridge-${BUILD_VARIANT}/chip-bridge-app \
145141
"
146142
- name: Run OTA Test
147-
timeout-minutes: 5
148143
run: |
149144
./scripts/run_in_build_env.sh \
150145
"./scripts/tests/run_darwin_framework_ota_test.py \

0 commit comments

Comments
 (0)