Skip to content

Commit 5217353

Browse files
Martin-NXPmarius-alex-tacheChin-Ran Lo
authored
[NXP] Add ICD _SetPollingInterval and set minimum ActiveModeThreshold to 5 seconds (#33875)
* [NXP][common] The minimum ActiveModeThreshold value for a LIT ICD is 5 seconds During initialization, the app would stuck in an assert if the app was configured as a LIT ICD: VerifyOrDieWithMsg(ICDConfigurationData::GetInstance().GetMinLitActiveModeThreshold() <= ICDConfigurationData::GetInstance().GetActiveModeThreshold(), AppServer, "The minimum ActiveModeThreshold value for a LIT ICD is 5 seconds."); Setting the default value of nxp_active_mode_threshold_ms to 5000ms fixes the issue. Signed-off-by: marius-alex-tache <marius.tache@nxp.com> * [NXP][platform][common] Add the _SetPollingInterval for Wi-Fi SIT ICDM function Signed-off-by: Chin-Ran Lo <nxf57500@lsv051039.swis.nl-cdc01.nxp.com> --------- Signed-off-by: marius-alex-tache <marius.tache@nxp.com> Signed-off-by: Chin-Ran Lo <nxf57500@lsv051039.swis.nl-cdc01.nxp.com> Co-authored-by: marius-alex-tache <marius.tache@nxp.com> Co-authored-by: Chin-Ran Lo <nxf57500@lsv051039.swis.nl-cdc01.nxp.com>
1 parent ba640aa commit 5217353

File tree

3 files changed

+14
-1
lines changed

3 files changed

+14
-1
lines changed

src/platform/nxp/common/ConnectivityManagerImpl.cpp

+10
Original file line numberDiff line numberDiff line change
@@ -618,6 +618,16 @@ CHIP_ERROR ConnectivityManagerImpl::_DisconnectNetwork(void)
618618

619619
return err;
620620
}
621+
622+
#if CHIP_CONFIG_ENABLE_ICD_SERVER
623+
CHIP_ERROR ConnectivityManagerImpl::_SetPollingInterval(System::Clock::Milliseconds32 pollingInterval)
624+
{
625+
/*
626+
* ToDo: Call API to put device into sleep
627+
*/
628+
return CHIP_NO_ERROR;
629+
}
630+
#endif // CHIP_CONFIG_ENABLE_ICD_SERVER
621631
#endif
622632

623633
} // namespace DeviceLayer

src/platform/nxp/common/ConnectivityManagerImpl.h

+3
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,9 @@ class ConnectivityManagerImpl final : public ConnectivityManager,
8787

8888
#if CHIP_DEVICE_CONFIG_ENABLE_WPA
8989
void StartWiFiManagement();
90+
#if CHIP_CONFIG_ENABLE_ICD_SERVER
91+
CHIP_ERROR _SetPollingInterval(System::Clock::Milliseconds32 pollingInterval);
92+
#endif // CHIP_CONFIG_ENABLE_ICD_SERVER
9093
#if CHIP_ENABLE_OPENTHREAD
9194
Inet::InterfaceId GetExternalInterface();
9295
Inet::InterfaceId GetThreadInterface();

third_party/nxp/nxp_sdk.gni

+1-1
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ declare_args() {
5353

5454
nxp_idle_mode_duration_s = 600 # 10min Idle Mode Interval
5555
nxp_active_mode_duration_ms = 10000 # 10s Active Mode Interval
56-
nxp_active_mode_threshold_ms = 1000 # 1s Active Mode Threshold
56+
nxp_active_mode_threshold_ms = 5000 # 5s Active Mode Threshold
5757
nxp_icd_supported_clients_per_fabric = 2 # 2 registration slots per fabric
5858
}
5959

0 commit comments

Comments
 (0)