Skip to content

Commit 526541a

Browse files
Fix builds
1 parent 22914b1 commit 526541a

File tree

5 files changed

+28
-22
lines changed

5 files changed

+28
-22
lines changed

src/platform/silabs/DiagnosticDataProviderImpl.cpp

+12-13
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@
3535
#include <sl_cmsis_os2_common.h>
3636

3737
using namespace ::chip::app::Clusters::GeneralDiagnostics;
38-
using namespace ::chip::DeviceLayer::Silabs;
3938

4039
namespace chip {
4140
namespace DeviceLayer {
@@ -341,7 +340,7 @@ CHIP_ERROR DiagnosticDataProviderImpl::GetWiFiBssId(MutableByteSpan & BssId)
341340

342341
VerifyOrReturnError(BssId.size() >= bssIdSize, CHIP_ERROR_BUFFER_TOO_SMALL);
343342

344-
if (WifiInterface::GetInstance().GetAccessPointInfo(ap) == CHIP_NO_ERROR)
343+
if (Silabs::WifiInterface::GetInstance().GetAccessPointInfo(ap) == CHIP_NO_ERROR)
345344
{
346345
memcpy(BssId.data(), ap.bssid, bssIdSize);
347346
BssId.reduce_size(bssIdSize);
@@ -356,7 +355,7 @@ CHIP_ERROR DiagnosticDataProviderImpl::GetWiFiSecurityType(app::Clusters::WiFiNe
356355
using app::Clusters::WiFiNetworkDiagnostics::SecurityTypeEnum;
357356

358357
wfx_wifi_scan_result_t ap = { 0 };
359-
CHIP_ERROR error = WifiInterface::GetInstance().GetAccessPointInfo(ap);
358+
CHIP_ERROR error = Silabs::WifiInterface::GetInstance().GetAccessPointInfo(ap);
360359
if (error == CHIP_NO_ERROR)
361360
{
362361
// TODO: Is this actually right? Do the wfx_wifi_scan_result_t values
@@ -376,7 +375,7 @@ CHIP_ERROR DiagnosticDataProviderImpl::GetWiFiVersion(app::Clusters::WiFiNetwork
376375
CHIP_ERROR DiagnosticDataProviderImpl::GetWiFiChannelNumber(uint16_t & channelNumber)
377376
{
378377
wfx_wifi_scan_result_t ap = { 0 };
379-
CHIP_ERROR error = WifiInterface::GetInstance().GetAccessPointInfo(ap);
378+
CHIP_ERROR error = Silabs::WifiInterface::GetInstance().GetAccessPointInfo(ap);
380379
if (error == CHIP_NO_ERROR)
381380
{
382381
channelNumber = ap.chan;
@@ -388,7 +387,7 @@ CHIP_ERROR DiagnosticDataProviderImpl::GetWiFiChannelNumber(uint16_t & channelNu
388387
CHIP_ERROR DiagnosticDataProviderImpl::GetWiFiRssi(int8_t & rssi)
389388
{
390389
wfx_wifi_scan_result_t ap = { 0 };
391-
CHIP_ERROR error = WifiInterface::GetInstance().GetAccessPointInfo(ap);
390+
CHIP_ERROR error = Silabs::WifiInterface::GetInstance().GetAccessPointInfo(ap);
392391
if (error == CHIP_NO_ERROR)
393392
{
394393
rssi = ap.rssi;
@@ -400,7 +399,7 @@ CHIP_ERROR DiagnosticDataProviderImpl::GetWiFiRssi(int8_t & rssi)
400399
CHIP_ERROR DiagnosticDataProviderImpl::GetWiFiBeaconLostCount(uint32_t & beaconLostCount)
401400
{
402401
wfx_wifi_scan_ext_t extra_info = { 0 };
403-
CHIP_ERROR error = WifiInterface::GetInstance().GetAccessPointExtendedInfo(extra_info);
402+
CHIP_ERROR error = Silabs::WifiInterface::GetInstance().GetAccessPointExtendedInfo(extra_info);
404403
if (error == CHIP_NO_ERROR)
405404
{
406405
beaconLostCount = extra_info.beacon_lost_count;
@@ -417,7 +416,7 @@ CHIP_ERROR DiagnosticDataProviderImpl::GetWiFiCurrentMaxRate(uint64_t & currentM
417416
CHIP_ERROR DiagnosticDataProviderImpl::GetWiFiPacketMulticastRxCount(uint32_t & packetMulticastRxCount)
418417
{
419418
wfx_wifi_scan_ext_t extra_info = { 0 };
420-
CHIP_ERROR error = WifiInterface::GetInstance().GetAccessPointExtendedInfo(extra_info);
419+
CHIP_ERROR error = Silabs::WifiInterface::GetInstance().GetAccessPointExtendedInfo(extra_info);
421420
if (error == CHIP_NO_ERROR)
422421
{
423422
packetMulticastRxCount = extra_info.mcast_rx_count;
@@ -429,7 +428,7 @@ CHIP_ERROR DiagnosticDataProviderImpl::GetWiFiPacketMulticastRxCount(uint32_t &
429428
CHIP_ERROR DiagnosticDataProviderImpl::GetWiFiPacketMulticastTxCount(uint32_t & packetMulticastTxCount)
430429
{
431430
wfx_wifi_scan_ext_t extra_info = { 0 };
432-
CHIP_ERROR error = WifiInterface::GetInstance().GetAccessPointExtendedInfo(extra_info);
431+
CHIP_ERROR error = Silabs::WifiInterface::GetInstance().GetAccessPointExtendedInfo(extra_info);
433432
if (error == CHIP_NO_ERROR)
434433
{
435434
packetMulticastTxCount = extra_info.mcast_tx_count;
@@ -441,7 +440,7 @@ CHIP_ERROR DiagnosticDataProviderImpl::GetWiFiPacketMulticastTxCount(uint32_t &
441440
CHIP_ERROR DiagnosticDataProviderImpl::GetWiFiPacketUnicastRxCount(uint32_t & packetUnicastRxCount)
442441
{
443442
wfx_wifi_scan_ext_t extra_info = { 0 };
444-
CHIP_ERROR error = WifiInterface::GetInstance().GetAccessPointExtendedInfo(extra_info);
443+
CHIP_ERROR error = Silabs::WifiInterface::GetInstance().GetAccessPointExtendedInfo(extra_info);
445444
if (error == CHIP_NO_ERROR)
446445
{
447446
packetUnicastRxCount = extra_info.ucast_rx_count;
@@ -453,7 +452,7 @@ CHIP_ERROR DiagnosticDataProviderImpl::GetWiFiPacketUnicastRxCount(uint32_t & pa
453452
CHIP_ERROR DiagnosticDataProviderImpl::GetWiFiPacketUnicastTxCount(uint32_t & packetUnicastTxCount)
454453
{
455454
wfx_wifi_scan_ext_t extra_info = { 0 };
456-
CHIP_ERROR error = WifiInterface::GetInstance().GetAccessPointExtendedInfo(extra_info);
455+
CHIP_ERROR error = Silabs::WifiInterface::GetInstance().GetAccessPointExtendedInfo(extra_info);
457456
if (error == CHIP_NO_ERROR)
458457
{
459458
packetUnicastTxCount = extra_info.ucast_tx_count;
@@ -465,7 +464,7 @@ CHIP_ERROR DiagnosticDataProviderImpl::GetWiFiPacketUnicastTxCount(uint32_t & pa
465464
CHIP_ERROR DiagnosticDataProviderImpl::GetWiFiOverrunCount(uint64_t & overrunCount)
466465
{
467466
wfx_wifi_scan_ext_t extra_info = { 0 };
468-
CHIP_ERROR error = WifiInterface::GetInstance().GetAccessPointExtendedInfo(extra_info);
467+
CHIP_ERROR error = Silabs::WifiInterface::GetInstance().GetAccessPointExtendedInfo(extra_info);
469468
if (error == CHIP_NO_ERROR)
470469
{
471470
overrunCount = extra_info.overrun_count;
@@ -477,7 +476,7 @@ CHIP_ERROR DiagnosticDataProviderImpl::GetWiFiOverrunCount(uint64_t & overrunCou
477476
CHIP_ERROR DiagnosticDataProviderImpl::GetWiFiBeaconRxCount(uint32_t & beaconRxCount)
478477
{
479478
wfx_wifi_scan_ext_t extra_info = { 0 };
480-
CHIP_ERROR error = WifiInterface::GetInstance().GetAccessPointExtendedInfo(extra_info);
479+
CHIP_ERROR error = Silabs::WifiInterface::GetInstance().GetAccessPointExtendedInfo(extra_info);
481480
if (error == CHIP_NO_ERROR)
482481
{
483482
beaconRxCount = extra_info.beacon_rx_count;
@@ -488,7 +487,7 @@ CHIP_ERROR DiagnosticDataProviderImpl::GetWiFiBeaconRxCount(uint32_t & beaconRxC
488487

489488
CHIP_ERROR DiagnosticDataProviderImpl::ResetWiFiNetworkDiagnosticsCounts()
490489
{
491-
return WifiInterface::GetInstance().ResetCounters();
490+
return Silabs::WifiInterface::GetInstance().ResetCounters();
492491
}
493492
#endif // SL_WIFI
494493

src/platform/silabs/PlatformManagerImpl.cpp

+4-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,10 @@
3030
#include <platform/PlatformManager.h>
3131
#include <platform/internal/GenericPlatformManagerImpl_CMSISOS.ipp>
3232
#include <platform/silabs/DiagnosticDataProviderImpl.h>
33+
34+
#if CHIP_DEVICE_CONFIG_ENABLE_WIFI_STATION
3335
#include <platform/silabs/wifi/WifiInterface.h>
36+
#endif // CHIP_DEVICE_CONFIG_ENABLE_WIFI_STATION
3437

3538
#if defined(SL_MBEDTLS_USE_TINYCRYPT)
3639
#include "tinycrypt/ecc.h"
@@ -41,7 +44,6 @@
4144
#endif // CHIP_SYSTEM_CONFIG_USE_LWIP
4245

4346
using namespace chip::DeviceLayer::Internal;
44-
using namespace chip::DeviceLayer::Silabs;
4547

4648
namespace chip {
4749
namespace DeviceLayer {
@@ -147,6 +149,7 @@ void HandleWFXSystemEvent(sl_wfx_generic_message_t * eventData)
147149
{
148150
using namespace chip;
149151
using namespace chip::DeviceLayer;
152+
using namespace chip::DeviceLayer::Silabs;
150153

151154
ChipDeviceEvent event;
152155
memset(&event, 0, sizeof(event));

src/platform/silabs/wifi/WifiInterface.h

+3
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,9 @@
2626
#include <sl_status.h>
2727

2828
#if (SLI_SI91X_MCU_INTERFACE | EXP_BOARD)
29+
#include "rsi_common_apis.h"
30+
#include "sl_si91x_types.h"
31+
#include "sl_wifi_constants.h"
2932
#include "sl_wifi_device.h"
3033
#endif // (SLI_SI91X_MCU_INTERFACE | EXP_BOARD)
3134

src/platform/silabs/wifi/icd/WifiSleepManager.cpp

+8-6
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@
2020
#include <platform/silabs/wifi/WifiInterface.h>
2121
#include <platform/silabs/wifi/icd/WifiSleepManager.h>
2222

23+
using namespace chip::DeviceLayer::Silabs;
24+
2325
namespace {
2426

2527
// TODO: Once the platform sleep calls are unified, we can removed this ifdef
@@ -33,10 +35,10 @@ namespace {
3335
*/
3436
CHIP_ERROR ConfigureDTIMBasedSleep()
3537
{
36-
ReturnLogErrorOnFailure(ConfigureBroadcastFilter(false));
38+
ReturnLogErrorOnFailure(WifiInterface::GetInstance().ConfigureBroadcastFilter(false));
3739

3840
// Allowing the device to go to sleep must be the last actions to avoid configuration failures.
39-
ReturnLogErrorOnFailure(ConfigurePowerSave(RSI_SLEEP_MODE_2, ASSOCIATED_POWER_SAVE, 0));
41+
ReturnLogErrorOnFailure(WifiInterface::GetInstance().ConfigurePowerSave(RSI_SLEEP_MODE_2, ASSOCIATED_POWER_SAVE, 0));
4042

4143
return CHIP_NO_ERROR;
4244
}
@@ -49,7 +51,7 @@ CHIP_ERROR ConfigureDTIMBasedSleep()
4951
*/
5052
CHIP_ERROR ConfigureDeepSleep()
5153
{
52-
ReturnLogErrorOnFailure(ConfigurePowerSave(RSI_SLEEP_MODE_8, DEEP_SLEEP_WITH_RAM_RETENTION, 0));
54+
ReturnLogErrorOnFailure(WifiInterface::GetInstance().ConfigurePowerSave(RSI_SLEEP_MODE_8, DEEP_SLEEP_WITH_RAM_RETENTION, 0));
5355
return CHIP_NO_ERROR;
5456
}
5557

@@ -61,7 +63,7 @@ CHIP_ERROR ConfigureDeepSleep()
6163
*/
6264
CHIP_ERROR ConfigureHighPerformance()
6365
{
64-
ReturnLogErrorOnFailure(ConfigurePowerSave(RSI_ACTIVE, HIGH_PERFORMANCE, 0));
66+
ReturnLogErrorOnFailure(WifiInterface::GetInstance().ConfigurePowerSave(RSI_ACTIVE, HIGH_PERFORMANCE, 0));
6567
return CHIP_NO_ERROR;
6668
}
6769
#endif // SLI_SI917
@@ -148,15 +150,15 @@ CHIP_ERROR WifiSleepManager::VerifyAndTransitionToLowPowerMode(PowerEvent event)
148150
return CHIP_NO_ERROR;
149151
}
150152

151-
if (!IsWifiProvisioned())
153+
if (!WifiInterface::GetInstance().IsWifiProvisioned())
152154
{
153155
return ConfigureDeepSleep();
154156
}
155157

156158
return ConfigureDTIMBasedSleep();
157159

158160
#else
159-
ReturnErrorOnFailure(ConfigurePowerSave());
161+
ReturnErrorOnFailure(WifiInterface::GetInstance().ConfigurePowerSave());
160162
return CHIP_NO_ERROR;
161163
#endif
162164
}

src/platform/silabs/wifi/rs911x/WifiInterfaceImpl.h

+1-2
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,7 @@ class WifiInterfaceImpl final : public WiseconnectWifiInterface
4343
CHIP_ERROR ResetCounters() override;
4444
#if CHIP_CONFIG_ENABLE_ICD_SERVER
4545
CHIP_ERROR ConfigureBroadcastFilter(bool enableBroadcastFilter) override;
46-
CHIP_ERROR ConfigurePowerSave(rsi_power_save_profile_mode_t sl_si91x_ble_state,
47-
sl_si91x_performance_profile_t sl_si91x_wifi_state, uint32_t listenInterval) override;
46+
CHIP_ERROR ConfigurePowerSave() override;
4847
#endif // CHIP_CONFIG_ENABLE_ICD_SERVER
4948

5049
/**

0 commit comments

Comments
 (0)