File tree 2 files changed +4
-7
lines changed
2 files changed +4
-7
lines changed Original file line number Diff line number Diff line change @@ -540,22 +540,19 @@ CHIP_ERROR CommandHandler::AddStatusInternal(const ConcreteCommandPath & aComman
540
540
void CommandHandler::AddStatus (const ConcreteCommandPath & aCommandPath, const Protocols::InteractionModel::Status aStatus,
541
541
const char * context)
542
542
{
543
- <<<<<<< HEAD
544
- =======
545
543
546
544
CHIP_ERROR error = FallibleAddStatus (aCommandPath, aStatus, context);
547
545
548
546
if (error != CHIP_NO_ERROR)
549
547
{
550
548
ChipLogError (DataManagement, " Failed to add command status: %" CHIP_ERROR_FORMAT, error.Format ());
551
- // TODO we could call mpResponder->ResponseDropped() if err == CHIP_ERROR_NO_MEMORY. This should
552
- // bhe done as a follow up so that it can be evaluated as a standalone change .
549
+ // TODO(#30453) we could call mpResponder->ResponseDropped() if err == CHIP_ERROR_NO_MEMORY. This should
550
+ // be done as a follow up so that change can be evaluated as a standalone PR .
553
551
554
552
// Do not crash if the status has not been added due to running out of packet buffers or other resources.
555
553
// It is better to drop a single response than to go offline and lose all sessions and subscriptions.
556
554
VerifyOrDie (error == CHIP_ERROR_NO_MEMORY);
557
555
}
558
- >>>>>>> master
559
556
}
560
557
561
558
CHIP_ERROR CommandHandler::FallibleAddStatus (const ConcreteCommandPath & path, const Protocols::InteractionModel::Status status,
Original file line number Diff line number Diff line change @@ -90,8 +90,8 @@ void CommandResponder::StartSendingCommandResponses()
90
90
// TODO(#30453): It should be our responsibility to send a Failure StatusResponse to the requestor
91
91
// if there is a SessionHandle, but legacy unit tests explicitly check the behavior where
92
92
// we do not send any message. Changing this behavior should be done in a standalone
93
- // PR where only that specific change is made. Here is a possible solution that should
94
- // be done that fulfills our responsibility to send a Failure StatusResponse, but this causes unit
93
+ // PR where only that specific change is made. Here is a possible solution that could
94
+ // be used that fulfills our responsibility to send a Failure StatusResponse. This causes unit
95
95
// tests to start failing.
96
96
// ```
97
97
// if (mExchangeCtx && mExchangeCtx->HasSessionHandle())
You can’t perform that action at this time.
0 commit comments