Skip to content

Commit 5902746

Browse files
committedMar 11, 2024
Resolve conflict
1 parent bda703a commit 5902746

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed
 

‎src/app/CommandHandler.cpp

+2-5
Original file line numberDiff line numberDiff line change
@@ -540,22 +540,19 @@ CHIP_ERROR CommandHandler::AddStatusInternal(const ConcreteCommandPath & aComman
540540
void CommandHandler::AddStatus(const ConcreteCommandPath & aCommandPath, const Protocols::InteractionModel::Status aStatus,
541541
const char * context)
542542
{
543-
<<<<<<< HEAD
544-
=======
545543

546544
CHIP_ERROR error = FallibleAddStatus(aCommandPath, aStatus, context);
547545

548546
if (error != CHIP_NO_ERROR)
549547
{
550548
ChipLogError(DataManagement, "Failed to add command status: %" CHIP_ERROR_FORMAT, error.Format());
551-
// TODO we could call mpResponder->ResponseDropped() if err == CHIP_ERROR_NO_MEMORY. This should
552-
// bhe done as a follow up so that it can be evaluated as a standalone change.
549+
// TODO(#30453) we could call mpResponder->ResponseDropped() if err == CHIP_ERROR_NO_MEMORY. This should
550+
// be done as a follow up so that change can be evaluated as a standalone PR.
553551

554552
// Do not crash if the status has not been added due to running out of packet buffers or other resources.
555553
// It is better to drop a single response than to go offline and lose all sessions and subscriptions.
556554
VerifyOrDie(error == CHIP_ERROR_NO_MEMORY);
557555
}
558-
>>>>>>> master
559556
}
560557

561558
CHIP_ERROR CommandHandler::FallibleAddStatus(const ConcreteCommandPath & path, const Protocols::InteractionModel::Status status,

‎src/app/CommandResponder.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,8 @@ void CommandResponder::StartSendingCommandResponses()
9090
// TODO(#30453): It should be our responsibility to send a Failure StatusResponse to the requestor
9191
// if there is a SessionHandle, but legacy unit tests explicitly check the behavior where
9292
// we do not send any message. Changing this behavior should be done in a standalone
93-
// PR where only that specific change is made. Here is a possible solution that should
94-
// be done that fulfills our responsibility to send a Failure StatusResponse, but this causes unit
93+
// PR where only that specific change is made. Here is a possible solution that could
94+
// be used that fulfills our responsibility to send a Failure StatusResponse. This causes unit
9595
// tests to start failing.
9696
// ```
9797
// if (mExchangeCtx && mExchangeCtx->HasSessionHandle())

0 commit comments

Comments
 (0)