Fix review

Author: jlatusek

src/platform/tests/TestConnectivityMgr.cpp

@@ -52,6 +52,7 @@ struct TestConnectivityMgr : public ::testing::Test
     {
         auto err = chip::Platform::MemoryInit();
         EXPECT_EQ(err, CHIP_NO_ERROR);
+        // TODO: Move initialization of the platform manager from Init test to here
     }
 
     static void TearDownTestSuite()
@@ -60,6 +61,7 @@ struct TestConnectivityMgr : public ::testing::Test
         chip::DeviceLayer::PlatformMgr().Shutdown();
     }
 };
+
 TEST_F(TestConnectivityMgr, Init)
 {
     // ConfigurationManager is initialized from PlatformManager indirectly

src/platform/tests/TestDnssd.cpp

@@ -119,8 +119,8 @@ static void HandleResolve(void * context, DnssdService * result, const chip::Spa
     }
 
     EXPECT_EQ(result->mTextEntrySize, 1u);
-    EXPECT_EQ(strcmp(result->mTextEntries[0].mKey, "key"), 0);
-    EXPECT_EQ(strcmp(reinterpret_cast<const char *>(result->mTextEntries[0].mData), "val"), 0);
+    EXPECT_STREQ(result->mTextEntries[0].mKey, "key");
+    EXPECT_STREQ(reinterpret_cast<const char *>(result->mTextEntries[0].mData), "val");
 
     if (ctx->mBrowsedServicesCount == ++ctx->mResolvedServicesCount)
     {
@@ -143,7 +143,7 @@ static void HandleBrowse(void * context, DnssdService * services, size_t service
     auto * ctx = static_cast<TestDnssd *>(context);
 
     // Make sure that we will not be called again after end-of-input is set
-    EXPECT_EQ(ctx->mEndOfInput, false);
+    EXPECT_FALSE(ctx->mEndOfInput);
     // Cancelled error is expected when the browse is stopped with
     // ChipDnssdStopBrowse(), so we will not assert on it.
     EXPECT_TRUE(error == CHIP_NO_ERROR || error == CHIP_ERROR_CANCELLED);

src/platform/tests/TestPlatformMgr.cpp

@@ -146,7 +146,7 @@ TEST_F(TestPlatformMgr, BasicRunEventLoop)
 
     PlatformMgr().ScheduleWork(StopTheLoop);
 
-    EXPECT_TRUE(!stopRan);
+    EXPECT_FALSE(stopRan);
     PlatformMgr().RunEventLoop();
     EXPECT_TRUE(stopRan);
     EXPECT_EQ(stopResult, CHIP_NO_ERROR);
@@ -172,8 +172,8 @@ TEST_F(TestPlatformMgr, RunEventLoopTwoTasks)
     PlatformMgr().ScheduleWork(SleepSome);
     PlatformMgr().ScheduleWork(StopTheLoop);
 
-    EXPECT_TRUE(!stopRan);
-    EXPECT_TRUE(!sleepRan);
+    EXPECT_FALSE(stopRan);
+    EXPECT_FALSE(sleepRan);
     PlatformMgr().RunEventLoop();
     EXPECT_TRUE(stopRan);
     EXPECT_TRUE(sleepRan);