Clarify constant name per review comment

Author: jtung-apple

src/darwin/Framework/CHIP/MTRDeviceControllerDataStore.mm

@@ -27,7 +27,7 @@
 #include <lib/support/SafeInt.h>
 
 // Log error each time sync storage takes longer than this threshold
-#define SYNC_OPERATION_DURATION_LOG_THRESHOLD (2.0)
+#define SYNC_OPERATION_DURATION_LOG_THRESHOLD_SECONDS (2.0)
 
 // FIXME: Are these good key strings? https://github.com/project-chip/connectedhomeip/issues/28973
 static NSString * sResumptionNodeListKey = @"caseResumptionNodeList";
@@ -151,7 +151,7 @@ - (nullable instancetype)initWithController:(MTRDeviceController *)controller
         }
     });
     NSTimeInterval syncDuration = -[startTime timeIntervalSinceNow];
-    if (syncDuration > SYNC_OPERATION_DURATION_LOG_THRESHOLD) {
+    if (syncDuration > SYNC_OPERATION_DURATION_LOG_THRESHOLD_SECONDS) {
         MTR_LOG_ERROR("MTRDeviceControllerDataStore init took %0.6lf seconds to read from storage", syncDuration);
     }
     if (resumptionNodeList != nil) {
@@ -192,7 +192,7 @@ - (void)fetchAttributeDataForAllDevices:(MTRDeviceControllerDataStoreClusterData
         }
     });
     NSTimeInterval syncDuration = -[startTime timeIntervalSinceNow];
-    if (syncDuration > SYNC_OPERATION_DURATION_LOG_THRESHOLD) {
+    if (syncDuration > SYNC_OPERATION_DURATION_LOG_THRESHOLD_SECONDS) {
         MTR_LOG_ERROR("MTRDeviceControllerDataStore fetchAttributeDataForAllDevices took %0.6lf seconds to read from storage", syncDuration);
     }
 
@@ -256,7 +256,7 @@ - (void)storeResumptionInfo:(MTRCASESessionResumptionInfo *)resumptionInfo
                          sharingType:MTRStorageSharingTypeNotShared];
     });
     NSTimeInterval syncDuration = -[startTime timeIntervalSinceNow];
-    if (syncDuration > SYNC_OPERATION_DURATION_LOG_THRESHOLD) {
+    if (syncDuration > SYNC_OPERATION_DURATION_LOG_THRESHOLD_SECONDS) {
         MTR_LOG_ERROR("MTRDeviceControllerDataStore storeResumptionInfo took %0.6lf seconds to store to storage", syncDuration);
     }
 }
@@ -304,7 +304,7 @@ - (void)_clearResumptionInfoForNodeID:(NSNumber *)nodeID controller:(MTRDeviceCo
                              sharingType:MTRStorageSharingTypeNotShared];
         });
         NSTimeInterval syncDuration = -[startTime timeIntervalSinceNow];
-        if (syncDuration > SYNC_OPERATION_DURATION_LOG_THRESHOLD) {
+        if (syncDuration > SYNC_OPERATION_DURATION_LOG_THRESHOLD_SECONDS) {
             MTR_LOG_ERROR("MTRDeviceControllerDataStore _clearResumptionInfoForNodeID took %0.6lf seconds to remove from storage", syncDuration);
         }
     }
@@ -325,7 +325,7 @@ - (CHIP_ERROR)storeLastLocallyUsedNOC:(MTRCertificateTLVBytes)noc
                               sharingType:MTRStorageSharingTypeNotShared];
     });
     NSTimeInterval syncDuration = -[startTime timeIntervalSinceNow];
-    if (syncDuration > SYNC_OPERATION_DURATION_LOG_THRESHOLD) {
+    if (syncDuration > SYNC_OPERATION_DURATION_LOG_THRESHOLD_SECONDS) {
         MTR_LOG_ERROR("MTRDeviceControllerDataStore storeLastLocallyUsedNOC took %0.6lf seconds to store to storage", syncDuration);
     }
     return ok ? CHIP_NO_ERROR : CHIP_ERROR_PERSISTED_STORAGE_FAILED;
@@ -347,7 +347,7 @@ - (MTRCertificateTLVBytes _Nullable)fetchLastLocallyUsedNOC
         }
     });
     NSTimeInterval syncDuration = -[startTime timeIntervalSinceNow];
-    if (syncDuration > SYNC_OPERATION_DURATION_LOG_THRESHOLD) {
+    if (syncDuration > SYNC_OPERATION_DURATION_LOG_THRESHOLD_SECONDS) {
         MTR_LOG_ERROR("MTRDeviceControllerDataStore fetchLastLocallyUsedNOC took %0.6lf seconds to read from storage", syncDuration);
     }
 
@@ -383,7 +383,7 @@ - (nullable MTRCASESessionResumptionInfo *)_findResumptionInfoWithKey:(nullable
         }
     });
     NSTimeInterval syncDuration = -[startTime timeIntervalSinceNow];
-    if (syncDuration > SYNC_OPERATION_DURATION_LOG_THRESHOLD) {
+    if (syncDuration > SYNC_OPERATION_DURATION_LOG_THRESHOLD_SECONDS) {
         MTR_LOG_ERROR("MTRDeviceControllerDataStore _findResumptionInfoWithKey took %0.6lf seconds to read from storage", syncDuration);
     }
 
@@ -964,7 +964,7 @@ - (void)clearAllStoredClusterData
         }
     });
     NSTimeInterval syncDuration = -[startTime timeIntervalSinceNow];
-    if (syncDuration > SYNC_OPERATION_DURATION_LOG_THRESHOLD) {
+    if (syncDuration > SYNC_OPERATION_DURATION_LOG_THRESHOLD_SECONDS) {
         MTR_LOG_ERROR("MTRDeviceControllerDataStore getStoredClusterDataForNodeID took %0.6lf seconds to read from storage", syncDuration);
     }
 
@@ -982,7 +982,7 @@ - (nullable MTRDeviceClusterData *)getStoredClusterDataForNodeID:(NSNumber *)nod
         clusterDataToReturn = [self _fetchClusterDataForNodeID:nodeID endpointID:endpointID clusterID:clusterID];
     });
     NSTimeInterval syncDuration = -[startTime timeIntervalSinceNow];
-    if (syncDuration > SYNC_OPERATION_DURATION_LOG_THRESHOLD) {
+    if (syncDuration > SYNC_OPERATION_DURATION_LOG_THRESHOLD_SECONDS) {
         MTR_LOG_ERROR("MTRDeviceControllerDataStore getStoredClusterDataForNodeID took %0.6lf seconds to read from storage", syncDuration);
     }
     return clusterDataToReturn;
@@ -1254,7 +1254,7 @@ - (NSString *)_deviceDataKeyForNodeID:(NSNumber *)nodeID
         deviceData = dictionary;
     });
     NSTimeInterval syncDuration = -[startTime timeIntervalSinceNow];
-    if (syncDuration > SYNC_OPERATION_DURATION_LOG_THRESHOLD) {
+    if (syncDuration > SYNC_OPERATION_DURATION_LOG_THRESHOLD_SECONDS) {
         MTR_LOG_ERROR("MTRDeviceControllerDataStore getStoredDeviceDataForNodeID took %0.6lf seconds to read from storage", syncDuration);
     }
     return deviceData;