[Amazon] StopConnect for UDC in Android tv-casting-app

Updated Android & iOS tv-casting-app to send stopConnect command when user
exits UDC before confirming passcode

Changes
1. Added IsPendingPasscodeFromUser() to CastingPlayer. This function
   will return true if we are still connecting and pending user action
   for passcode
2. ConnectionExampleFragment.java onDestroy() calls stopConnect() if user
   has not confirmed passcode
4. MCConnectionExampleView ConnectingView dissapear calls stopConnect()
   if user has not confirmed passcode

Test
1. Manually verified UDC attempt is successful both Android iOS for following
   1. Attempt UDC attempt (both commissionee & commissioner generated passcode)
   2. Navigate back to discovery page
   3. Start new UDC attempt (both commissionee & commissioner generated passcode)

2. Manually verified UDC attempt is successful both Android iOS for following. UDC will finish in the background.
   1. Attempt UDC attempt (both commissionee & commissioner generated passcode)
   2. Confirm passcode on TV app or casting app depending on who
      generated passcode
   3. Navigate back before commission fnishes.

3. Manual regression test following
   * UDC attempt happy path (no navigate back) for both commissinee &
     commissioner generated passcode

Author: yuenton-amazon

examples/tv-casting-app/android/App/app/src/main/java/com/matter/casting/ConnectionExampleFragment.java

@@ -262,6 +262,22 @@ public void handle(CommissionerDeclaration cd) {
             });
   }
 
+  @Override
+  public void onDestroy() {
+    super.onDestroy();
+
+    // Only stop connection if we are pending passcode confirmation
+    // We cannot stop connection once continueConnecting() is called
+    if (targetCastingPlayer.isPendingPasscodeFromUser()) {
+      MatterError err = targetCastingPlayer.stopConnecting();
+      if (err.hasError()) {
+        Log.e(
+            TAG,
+            "Going back before connection finishes but stopConnecting() failed due to: " + err);
+      }
+    }
+  }
+
   private void displayPasscodeInputDialog(Context context) {
     AlertDialog.Builder builder = new AlertDialog.Builder(context);
 

examples/tv-casting-app/android/App/app/src/main/jni/com/matter/casting/core/CastingPlayer.java

@@ -152,4 +152,10 @@ MatterError verifyOrEstablishConnection(
 
   /** @brief Sets the internal connection state of this CastingPlayer to "disconnected" */
   void disconnect();
+
+  /**
+   * @return true if this CastingPlayer is still pending pass code from user and therefore is not
+   *     ready
+   */
+  boolean isPendingPasscodeFromUser();
 }

examples/tv-casting-app/android/App/app/src/main/jni/com/matter/casting/core/MatterCastingPlayer.java

@@ -267,4 +267,7 @@ public MatterError continueConnecting() {
 
   @Override
   public native void disconnect();
+
+  @Override
+  public native boolean isPendingPasscodeFromUser();
 }

examples/tv-casting-app/android/App/app/src/main/jni/cpp/core/MatterCastingPlayer-JNI.cpp

@@ -165,6 +165,18 @@ JNI_METHOD(void, disconnect)
     castingPlayer->Disconnect();
 }
 
+JNI_METHOD(bool, isPendingPasscodeFromUser)
+(JNIEnv * env, jobject thiz)
+{
+    chip::DeviceLayer::StackLock lock;
+    ChipLogProgress(AppServer, "MatterCastingPlayer-JNI::isPendingPasscodeFromUser()");
+
+    CastingPlayer * castingPlayer = support::convertCastingPlayerFromJavaToCpp(thiz);
+    VerifyOrReturnValue(castingPlayer != nullptr, support::convertMatterErrorFromCppToJava(CHIP_ERROR_INVALID_ARGUMENT));
+
+    return castingPlayer->IsPendingPasscodeFromUser();
+}
+
 JNI_METHOD(jobject, getEndpoints)
 (JNIEnv * env, jobject thiz)
 {

examples/tv-casting-app/darwin/MatterTvCastingBridge/MatterTvCastingBridge/MCCastingPlayer.h

@@ -148,6 +148,11 @@
  */
 - (void)disconnect;
 
+/**
+ * @return true if this CastingPlayer is still pending pass code from user and therefore is not ready
+ */
+- (bool)isPendingPasscodeFromUser;
+
 - (NSString * _Nonnull)identifier;
 - (NSString * _Nonnull)deviceName;
 - (uint16_t)vendorId;

examples/tv-casting-app/darwin/MatterTvCastingBridge/MatterTvCastingBridge/MCCastingPlayer.mm

@@ -190,6 +190,20 @@ - (void)disconnect
     });
 }
 
+- (bool)isPendingPasscodeFromUser
+{
+    ChipLogProgress(AppServer, "MCCastingPlayer.isPendingPasscodeFromUser() called");
+    VerifyOrReturnValue([[MCCastingApp getSharedInstance] isRunning], false, ChipLogError(AppServer, "MCCastingPlayer.isPendingPasscodeFromUser() MCCastingApp NOT running"));
+
+    dispatch_queue_t workQueue = [[MCCastingApp getSharedInstance] getWorkQueue];
+    
+    __block bool isPending = false;
+    dispatch_sync(workQueue, ^{
+        isPending = _cppCastingPlayer->IsPendingPasscodeFromUser();
+    });
+    return isPending;
+}
+
 - (instancetype _Nonnull)initWithCppCastingPlayer:(matter::casting::memory::Strong<matter::casting::core::CastingPlayer>)cppCastingPlayer
 {
     if (self = [super init]) {

examples/tv-casting-app/darwin/TvCasting/TvCasting/MCConnectionExampleView.swift

@@ -88,6 +88,9 @@ struct MCConnectionExampleView: View {
                 viewModel.connect(selectedCastingPlayer: self.selectedCastingPlayer, useCommissionerGeneratedPasscode: self.useCommissionerGeneratedPasscode)
             }
         })
+        .onDisappear(perform: {
+            viewModel.cancelConnectionAttempt(selectedCastingPlayer: self.selectedCastingPlayer)
+        })
     }
 }
 

examples/tv-casting-app/darwin/TvCasting/TvCasting/MCConnectionExampleViewModel.swift

@@ -42,6 +42,23 @@ class MCConnectionExampleViewModel: ObservableObject {
 
     @Published var errorCodeDescription: String?
 
+    func cancelConnectionAttempt(selectedCastingPlayer: MCCastingPlayer?) {
+        DispatchQueue.main.async {
+            // Only stop connection if we are pending passcode confirmation
+            if selectedCastingPlayer?.isPendingPasscodeFromUser() == true {
+                self.Log.info("MCConnectionExampleViewModel cancelConnect(). User navigating back from ConnectionView")
+                let err = selectedCastingPlayer?.stopConnecting()
+                if err == nil {
+                    self.connectionStatus = "User cancelled the connection attempt with CastingPlayer.stopConnecting()."
+                    self.Log.info("MCConnectionExampleViewModel cancelConnect() MCCastingPlayer.stopConnecting() succeeded.")
+                } else {
+                    self.connectionStatus = "Cancel connection failed due to: \(String(describing: err))."
+                    self.Log.error("MCConnectionExampleViewModel cancelConnect() MCCastingPlayer.stopConnecting() failed due to: \(err)")
+                }
+            }
+        }
+    }
+
     func connect(selectedCastingPlayer: MCCastingPlayer?, useCommissionerGeneratedPasscode: Bool) {
         self.Log.info("MCConnectionExampleViewModel.connect() useCommissionerGeneratedPasscode: \(String(describing: useCommissionerGeneratedPasscode))")
 

examples/tv-casting-app/tv-casting-common/core/CastingPlayer.cpp

@@ -228,11 +228,6 @@ CHIP_ERROR CastingPlayer::ContinueConnecting()
 
 CHIP_ERROR CastingPlayer::StopConnecting()
 {
-    VerifyOrReturnValue(
-        mIdOptions.mCommissionerPasscode, CHIP_ERROR_INCORRECT_STATE,
-        ChipLogError(AppServer,
-                     "CastingPlayer::StopConnecting() mIdOptions.mCommissionerPasscode == false, ContinueConnecting() should only "
-                     "be called when the CastingPlayer/Commissioner-Generated passcode commissioning flow is in progress."););
     // Calling the internal StopConnecting() API with the shouldSendIdentificationDeclarationMessage set to true to notify the
     // CastingPlayer/Commissioner that the commissioning session was cancelled by the Casting Client/Commissionee user. This will
     // result in the Casting Client/Commissionee sending a CancelPasscode IdentificationDeclaration message to the CastingPlayer.

examples/tv-casting-app/tv-casting-common/core/CastingPlayer.h

@@ -142,6 +142,14 @@ class CastingPlayer : public std::enable_shared_from_this<CastingPlayer>
      */
     bool IsConnected() const { return mConnectionState == CASTING_PLAYER_CONNECTED; }
 
+    /**
+     * @return true if this CastingPlayer is still pending pass code from user and therefore is not ready
+     */
+    bool IsPendingPasscodeFromUser() const
+    {
+        return mConnectionState == CASTING_PLAYER_CONNECTING && !mIdOptions.mCommissionerPasscodeReady;
+    }
+
     /**
      * @brief Verifies that a connection exists with this CastingPlayer, or triggers a new commissioning session request. If the
      * CastingApp does not have the nodeId and fabricIndex of this CastingPlayer cached on disk, this will execute the User Directed