Skip to content

Commit 5da3a66

Browse files
ksperling-applebzbarsky-applekiel-apple
authored
Apply suggestions from code review
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> Co-authored-by: Kiel Oleson <kielo@apple.com>
1 parent 39ac64e commit 5da3a66

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

src/app/clusters/thread-network-directory-server/thread-network-directory-server.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ CHIP_ERROR ThreadNetworkDirectoryServer::WritePreferredExtendedPanId(const Concr
119119

120120
// "A zero-length value SHALL be allowed for nullable values ... and SHALL have the same semantics as the null value."
121121
ByteSpan value = nullableValue.ValueOr(ByteSpan());
122-
// Ensure the provided value is value (correct size) and refers to PAN from the list.
122+
// Ensure the provided value is valid (correct size) and refers to PAN from the list.
123123
VerifyOrReturnError(value.empty() || (value.size() == ExtendedPanId::size() && mStorage.ContainsNetwork(ExtendedPanId(value))),
124124
StatusIB(IMStatus::ConstraintError).ToChipError());
125125

src/app/tests/TestDefaultThreadNetworkDirectoryStorage.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ class TestDefaultThreadNetworkDirectoryStorage : public ::testing::Test
3535
static void TearDownTestSuite() { chip::Platform::MemoryShutdown(); }
3636

3737
protected:
38-
TestPersistentStorageDelegate persistendStorageDelegate;
39-
DefaultThreadNetworkDirectoryStorage storageImpl{ persistendStorageDelegate };
38+
TestPersistentStorageDelegate persistentStorageDelegate;
39+
DefaultThreadNetworkDirectoryStorage storageImpl{ persistentStorageDelegate };
4040
ThreadNetworkDirectoryStorage & storage = storageImpl;
4141
};
4242

src/lib/support/ThreadOperationalDataset.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ namespace Thread {
3939
class ThreadTLV final
4040
{
4141
static constexpr uint8_t kLengthEscape = 0xff; ///< This length value indicates the actual length is of two-bytes length, which
42-
///< not allowed in Thread Operational Dataset TLVs.
42+
///< is not allowed in Thread Operational Dataset TLVs.
4343

4444
public:
4545
static constexpr uint8_t kMaxLength = kLengthEscape - 1;

0 commit comments

Comments
 (0)