Add more tests for full coverage (not that useful, but ok)

Author: andy31415

src/app/server-cluster/tests/BUILD.gn

@@ -27,6 +27,7 @@ chip_test_suite("tests") {
 
   public_deps = [
     "${chip_root}/src/app/common:ids",
+    "${chip_root}/src/app/data-model-provider/tests:encode-decode",
     "${chip_root}/src/app/server-cluster:registry",
     "${chip_root}/src/lib/core:string-builder-adapters",
   ]

src/app/server-cluster/tests/TestServerClusterInterface.cpp

@@ -14,13 +14,17 @@
  *    See the License for the specific language governing permissions and
  *    limitations under the License.
  */
-#include "access/Privilege.h"
-#include "app/data-model-provider/MetadataList.h"
-#include "app/data-model-provider/MetadataTypes.h"
-#include "app/data-model/List.h"
+#include "app/data-model-provider/OperationTypes.h"
+#include "lib/core/TLVReader.h"
+#include <optional>
 #include <pw_unit_test/framework.h>
 
+#include <access/Privilege.h>
 #include <app-common/zap-generated/ids/Attributes.h>
+#include <app/data-model-provider/MetadataList.h>
+#include <app/data-model-provider/MetadataTypes.h>
+#include <app/data-model-provider/tests/ReadTesting.h>
+#include <app/data-model-provider/tests/WriteTesting.h>
 #include <app/server-cluster/ServerClusterInterface.h>
 #include <lib/core/CHIPError.h>
 #include <lib/core/DataModelTypes.h>
@@ -30,8 +34,10 @@
 
 using namespace chip;
 using namespace chip::app;
-using namespace chip::app::DataModel;
 using namespace chip::app::Clusters;
+using namespace chip::app::DataModel;
+using namespace chip::app::Testing;
+using namespace chip::Protocols::InteractionModel;
 
 namespace {
 
@@ -204,8 +210,33 @@ TEST(TestServerClusterInterface, CommandsDefault)
     ASSERT_EQ(cluster.AcceptedCommands({ 1, 1 }, acceptedCommands), CHIP_NO_ERROR);
     ASSERT_TRUE(acceptedCommands.TakeBuffer().empty());
 
-
     DataModel::ListBuilder<CommandId> generatedCommands;
     ASSERT_EQ(cluster.GeneratedCommands({ 1, 1 }, generatedCommands), CHIP_NO_ERROR);
     ASSERT_TRUE(generatedCommands.TakeBuffer().empty());
 }
+
+TEST(TestServerClusterInterface, WriteAttributeDefault)
+{
+    FakeServerClusterInterface cluster(1);
+
+    WriteOperation test(0 /* endpoint */, 1 /* cluster */, 1234 /* attribute */);
+    test.SetSubjectDescriptor(kAdminSubjectDescriptor);
+
+    AttributeValueDecoder decoder = test.DecoderFor<uint32_t>(12345);
+
+    ASSERT_EQ(cluster.WriteAttribute(test.GetRequest(), decoder), Status::UnsupportedWrite);
+    ASSERT_FALSE(decoder.TriedDecode());
+}
+
+TEST(TestServerClusterInterface, InvokeDefault)
+{
+    FakeServerClusterInterface cluster(1);
+
+    TLV::TLVReader tlvReader;
+    InvokeRequest request;
+
+    request.path = { 0 /* endpoint */, 1 /* cluster */, 1234 /* command */ };
+
+    ASSERT_EQ(cluster.Invoke(request, tlvReader, nullptr /* command handler, assumed unused here */),
+              Status::UnsupportedCommand);
+}

src/app/server-cluster/tests/TestServerClusterInterfaceRegistry.cpp

@@ -266,3 +266,18 @@ TEST_F(TestServerClusterInterfaceRegistry, StressTest)
         }
     }
 }
+
+TEST_F(TestServerClusterInterfaceRegistry, InstanceUsage)
+{
+    // This tests uses the instance member, to get coverage
+    // instance is assumed to be empty
+    FakeServerClusterInterface cluster(1234);
+
+    ASSERT_EQ(ServerClusterInterfaceRegistry::Instance().Get({ kEp1, 1234 }), nullptr);
+    ASSERT_EQ(ServerClusterInterfaceRegistry::Instance().Register(kEp1, &cluster), CHIP_NO_ERROR);
+    ASSERT_EQ(ServerClusterInterfaceRegistry::Instance().Get({ kEp1, 1234 }), &cluster);
+    ASSERT_EQ(ServerClusterInterfaceRegistry::Instance().Unregister({ kEp1, 1234 }), &cluster);
+    ASSERT_EQ(ServerClusterInterfaceRegistry::Instance().Get({ kEp1, 1234 }), nullptr);
+    ASSERT_EQ(ServerClusterInterfaceRegistry::Instance().Unregister({ kEp1, 1234 }), nullptr);
+    ASSERT_EQ(ServerClusterInterfaceRegistry::Instance().Get({ kEp1, 1234 }), nullptr);
+}