Change nodesWithStoredData to be a property. (#37772)

Author: bzbarsky-apple

src/darwin/Framework/CHIP/MTRDeviceController.h

@@ -321,7 +321,7 @@ MTR_AVAILABLE(ios(16.1), macos(13.0), watchos(9.1), tvos(16.1))
  * information.  Returns empty list if the controller does not have any
  * information stored.
  */
-- (NSArray<NSNumber *> *)nodesWithStoredData MTR_AVAILABLE(ios(18.4), macos(15.4), watchos(11.4), tvos(18.4));
+@property (readonly, nonatomic) NSArray<NSNumber *> * nodesWithStoredData MTR_AVAILABLE(ios(18.4), macos(15.4), watchos(11.4), tvos(18.4));
 
 /**
  * Shut down the controller. Calls to shutdown after the first one are NO-OPs.

src/darwin/Framework/CHIP/MTRDeviceControllerDataStore.h

@@ -109,7 +109,7 @@ typedef void (^MTRDeviceControllerDataStoreClusterDataHandler)(NSDictionary<NSNu
  * Returns the list of node IDs for which this data store has stored data of
  * some sort.
  */
-- (NSArray<NSNumber *> *)nodesWithStoredData;
+@property (readonly, nonatomic) NSArray<NSNumber *> * nodesWithStoredData;
 
 @end
 

src/darwin/Framework/CHIP/MTRDeviceController_Concrete.mm

@@ -1760,7 +1760,7 @@ - (nullable NSNumber *)neededReadPrivilegeForClusterID:(NSNumber *)clusterID att
         return @[];
     }
 
-    return [self.controllerDataStore nodesWithStoredData];
+    return self.controllerDataStore.nodesWithStoredData;
 }
 
 @end

src/darwin/Framework/CHIPTests/MTRPerControllerStorageTests.m

@@ -1787,9 +1787,9 @@ - (void)test010_TestDataStoreMTRDeviceWithBulkReadWrite
     XCTAssertNotNil([dataStore findResumptionInfoByNodeID:deviceID]);
     XCTAssertNotNil([dataStore getStoredDeviceDataForNodeID:deviceID]);
     XCTAssertNotNil([dataStore getStoredClusterDataForNodeID:deviceID]);
-    __auto_type * nodesWithStoredData = [controller nodesWithStoredData];
+    __auto_type * nodesWithStoredData = controller.nodesWithStoredData;
     XCTAssertTrue([nodesWithStoredData containsObject:deviceID]);
-    XCTAssertEqualObjects(nodesWithStoredData, [dataStore nodesWithStoredData]);
+    XCTAssertEqualObjects(nodesWithStoredData, dataStore.nodesWithStoredData);
     XCTAssertEqualObjects(nodesWithStoredData, deviceAttributeCounts.allKeys);
 
     [controller forgetDeviceWithNodeID:deviceID];
@@ -1798,9 +1798,9 @@ - (void)test010_TestDataStoreMTRDeviceWithBulkReadWrite
     XCTAssertNil([dataStore findResumptionInfoByNodeID:deviceID]);
     XCTAssertNil([dataStore getStoredDeviceDataForNodeID:deviceID]);
     XCTAssertNil([dataStore getStoredClusterDataForNodeID:deviceID]);
-    nodesWithStoredData = [controller nodesWithStoredData];
+    nodesWithStoredData = controller.nodesWithStoredData;
     XCTAssertFalse([nodesWithStoredData containsObject:deviceID]);
-    XCTAssertEqualObjects(nodesWithStoredData, [dataStore nodesWithStoredData]);
+    XCTAssertEqualObjects(nodesWithStoredData, dataStore.nodesWithStoredData);
 
     [controller shutdown];
     XCTAssertFalse([controller isRunning]);

src/darwin/Framework/CHIPTests/TestHelpers/MTRTestDeclarations.h

@@ -44,7 +44,7 @@ NS_ASSUME_NONNULL_BEGIN
 - (nullable NSArray<NSNumber *> *)_fetchClusterIndexForNodeID:(NSNumber *)nodeID endpointID:(NSNumber *)endpointID;
 - (nullable MTRDeviceClusterData *)_fetchClusterDataForNodeID:(NSNumber *)nodeID endpointID:(NSNumber *)endpointID clusterID:(NSNumber *)clusterID;
 - (nullable NSDictionary<NSString *, id> *)getStoredDeviceDataForNodeID:(NSNumber *)nodeID;
-- (NSArray<NSNumber *> *)nodesWithStoredData;
+@property (readonly, nonatomic) NSArray<NSNumber *> * nodesWithStoredData;
 @end
 
 // Declare internal methods for testing