Skip to content

Commit 64bf06a

Browse files
committed
Comment updates
1 parent 1f0c2b0 commit 64bf06a

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

src/BUILD.gn

+2-2
Original file line numberDiff line numberDiff line change
@@ -101,8 +101,8 @@ if (chip_build_tests) {
101101
]
102102
}
103103

104-
#+++++x TODO: Add issue about this.
105-
# in function `_open_r': openr.c:(.text._open_r+0x10): warning: _open is not implemented and will always fail
104+
# Disabled for EFR32 because _open is not implemented.
105+
# https://github.com/project-chip/connectedhomeip/issues/35624
106106
if (chip_device_platform != "efr32") {
107107
tests += [
108108
"${chip_root}/src/credentials/tests",

src/controller/tests/BUILD.gn

+11-11
Original file line numberDiff line numberDiff line change
@@ -23,22 +23,22 @@ chip_test_suite("tests") {
2323

2424
test_sources = []
2525

26-
#+++++x TODO: Add issue about this.
27-
# undefined reference to chip::Controller::CommissionableNodeController::*
26+
# Not supported on efr32.
2827
if (chip_device_platform != "efr32") {
2928
test_sources += [ "TestCommissionableNodeController.cpp" ]
3029
}
3130

3231
if (chip_device_platform != "mbed" && chip_device_platform != "esp32") {
33-
test_sources += [ "TestServerCommandDispatch.cpp" ]
34-
test_sources += [ "TestEventChunking.cpp" ]
35-
test_sources += [ "TestEventCaching.cpp" ]
36-
test_sources += [ "TestReadChunking.cpp" ]
37-
test_sources += [ "TestWriteChunking.cpp" ]
38-
test_sources += [ "TestEventNumberCaching.cpp" ]
39-
40-
#+++++x TODO: Add issue about this.
41-
# undefined reference to chip::Controller::CommissioningWindowOpener::*
32+
test_sources += [
33+
"TestServerCommandDispatch.cpp",
34+
"TestEventChunking.cpp",
35+
"TestEventCaching.cpp",
36+
"TestReadChunking.cpp",
37+
"TestWriteChunking.cpp",
38+
"TestEventNumberCaching.cpp",
39+
]
40+
41+
# Not supported on efr32.
4242
if (chip_device_platform != "efr32") {
4343
test_sources += [ "TestCommissioningWindowOpener.cpp" ]
4444
}

0 commit comments

Comments
 (0)