Skip to content

Commit 64e3661

Browse files
committedJul 18, 2024
Updated TC_CADMIN_1_9:
- Changed method for setting setupPinCode as in CI/CD pipeline it was failing previously.
1 parent b562fbc commit 64e3661

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed
 

‎src/python_testing/TC_CADMIN_1_9.py

+7-6
Original file line numberDiff line numberDiff line change
@@ -66,12 +66,12 @@ def generate_unique_random_value(self, value):
6666
return random_value
6767

6868
async def CommissionAttempt(
69-
self, params: dict, expectedErrCode: int):
69+
self, setupPinCode: int, expectedErrCode: int):
7070

7171
if expectedErrCode == 3:
7272
for cycle in range(20):
7373
logging.info("-----------------Current Iteration {}-------------------------".format(cycle+1))
74-
setup_code = self.generate_unique_random_value(params.setupPinCode)
74+
setup_code = self.generate_unique_random_value(setupPinCode)
7575
errcode = self.th2.CommissionOnNetwork(
7676
nodeId=self.dut_node_id, setupPinCode=setup_code,
7777
filterType=ChipDeviceCtrl.DiscoveryFilterType.LONG_DISCRIMINATOR, filter=self.discriminator)
@@ -84,7 +84,7 @@ async def CommissionAttempt(
8484
elif expectedErrCode == 50:
8585
logging.info("-----------------Attempting connection expecting timeout-------------------------")
8686
errcode = self.th2.CommissionOnNetwork(
87-
nodeId=self.dut_node_id, setupPinCode=params.setupPinCode,
87+
nodeId=self.dut_node_id, setupPinCode=setupPinCode,
8888
filterType=ChipDeviceCtrl.DiscoveryFilterType.LONG_DISCRIMINATOR, filter=self.discriminator)
8989
logging.info('Commissioning complete done. Successful? {}, errorcode = {}'.format(errcode.is_success, errcode))
9090
asserts.assert_false(errcode.is_success, 'Commissioning complete did not error as expected')
@@ -106,15 +106,16 @@ async def test_TC_CADMIN_1_9(self):
106106

107107
self.step(2)
108108
params = await self.OpenCommissioningWindow()
109-
109+
setupPinCode = params.setupPinCode
110+
110111
self.step(3)
111-
await self.CommissionAttempt(params, expectedErrCode=0x03)
112+
await self.CommissionAttempt(setupPinCode, expectedErrCode=0x03)
112113
# TODO: Found if we don't add sleep time after test completes that we get unexpected error code and response after the 21st iteration.
113114
# Link to Bug Filed: https://github.com/project-chip/connectedhomeip/issues/34383
114115
sleep(1)
115116

116117
self.step(4)
117-
await self.CommissionAttempt(params, expectedErrCode=0x32)
118+
await self.CommissionAttempt(setupPinCode, expectedErrCode=0x32)
118119

119120
self.step(5)
120121
params = await self.OpenCommissioningWindow()

0 commit comments

Comments
 (0)