Skip to content

Commit 65be4d8

Browse files
committed
[Realtek] Fix some review errors
1 parent 1ac22ed commit 65be4d8

File tree

4 files changed

+8
-44
lines changed

4 files changed

+8
-44
lines changed

config/realtek_bee/args.gni

-7
Original file line numberDiff line numberDiff line change
@@ -40,16 +40,9 @@ chip_enable_nfc_onboarding_payload = false
4040
chip_build_libshell = false
4141
chip_enable_ota_requestor = false
4242

43-
#chip_inet_config_enable_tcp_endpoint = true
44-
#chip_inet_config_enable_udp_endpoint = true
45-
#chip_system_config_use_open_thread_inet_endpoints = true
46-
#chip_with_lwip = false
4743
openthread_root = ""
4844

4945
chip_config_network_layer_ble = true
5046

5147
custom_toolchain =
5248
"//third_party/connectedhomeip/config/realtek_bee/toolchain:realtek_bee"
53-
#pw_build_PIP_CONSTRAINTS =
54-
# [ "//third_party/connectedhomeip/scripts/setup/constraints.txt" ]
55-
#cpp_standard = "c++17"

config/realtek_bee/bee_arm.gni

-4
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,4 @@
1414

1515
arm_arch = "armv8.1-m.main+dsp+mve+fp"
1616

17-
#arm_abi = "aapcs"
18-
#arm_cpu = "cortex-m4"
19-
2017
arm_float_abi = "hard"
21-
#arm_fpu = "fpv5-sp-d16"

examples/light-switch-app/realtek_bee/main/BindingHandler.cpp

+8-8
Original file line numberDiff line numberDiff line change
@@ -18,21 +18,21 @@
1818

1919
#include "BindingHandler.h"
2020
#include "AppConfig.h"
21-
#include "app/CommandSender.h"
22-
#include "app/clusters/bindings/BindingManager.h"
23-
#include "app/server/Server.h"
24-
#include "controller/InvokeInteraction.h"
25-
#include "controller/ReadInteraction.h"
26-
#include "platform/CHIPDeviceLayer.h"
21+
#include <app/CommandSender.h>
22+
#include <app/clusters/bindings/BindingManager.h>
23+
#include <app/server/Server.h>
24+
#include <controller/InvokeInteraction.h>
25+
#include <controller/ReadInteraction.h>
26+
#include <platform/CHIPDeviceLayer.h>
2727
#include <app/clusters/bindings/bindings.h>
2828
#include <lib/support/CodeUtils.h>
2929

3030
using namespace chip;
3131
using namespace chip::app;
3232

3333
#if CONFIG_ENABLE_CHIP_SHELL
34-
#include "lib/shell/Engine.h"
35-
#include "lib/shell/commands/Help.h"
34+
#include <lib/shell/Engine.h>
35+
#include <lib/shell/commands/Help.h>
3636

3737
using Shell::Engine;
3838
using Shell::shell_command_t;

examples/light-switch-app/realtek_bee/main/include/BindingHandler.h

-25
Original file line numberDiff line numberDiff line change
@@ -18,31 +18,6 @@
1818

1919
#pragma once
2020

21-
// #include "app-common/zap-generated/ids/Clusters.h"
22-
// #include "app-common/zap-generated/ids/Commands.h"
23-
// #include "lib/core/CHIPError.h"
24-
25-
// CHIP_ERROR InitBindingHandler();
26-
// void SwitchWorkerFunction(intptr_t context);
27-
// void SwitchWorkerFunction2(int localEndpointId);
28-
// void SwitchWorkerFunction3(int remoteNodeId);
29-
// void BindingWorkerFunction(intptr_t context);
30-
31-
// struct BindingCommandData
32-
// {
33-
// chip::EndpointId localEndpointId;
34-
// chip::CommandId commandId;
35-
// chip::ClusterId clusterId;
36-
// bool isGroup = false;
37-
// };
38-
39-
// struct SubscribeCommandData
40-
// {
41-
// chip::EndpointId localEndpointId;
42-
// chip::NodeId nodeId;//remote nodeid
43-
// chip::FabricIndex fabricIndex;
44-
// };
45-
4621
#include "app-common/zap-generated/ids/Clusters.h"
4722
#include "app-common/zap-generated/ids/Commands.h"
4823
#include "lib/core/CHIPError.h"

0 commit comments

Comments
 (0)