Skip to content

Commit 6603bae

Browse files
committed
switched to shutil.copy instead of subprocess copy
1 parent 5b884bc commit 6603bae

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

build/chip/chip_test_suite.gni

-2
Original file line numberDiff line numberDiff line change
@@ -69,8 +69,6 @@ template("chip_test_suite") {
6969
invoker.sources += invoker.test_sources
7070
}
7171
}
72-
#++++x did we change the logic here? think about it for all cases that don't involve building efr32 test driver -- would should happen if chip_link_tests is true or false?
73-
# prior to me making my changes for efr32 test driver, was it was ok if the the test_sources were contained in both the common library and the individual libraries?
7472

7573
# Target for the common library. Contains all the common sources, and sometimes all the individual test sources.
7674
if (chip_build_test_static_libraries) {

scripts/flashing/silabs_firmware_utils.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
"""
5151

5252
import os
53-
import subprocess
53+
import shutil
5454
import sys
5555

5656
import firmware_utils
@@ -183,10 +183,10 @@ def _platform_wrapper_args(self, args):
183183
output_dir = os.path.dirname(args.output) or "."
184184
if args.platform_firmware_utils is not None:
185185
flashbundle_contents += "\n" + os.path.basename(args.platform_firmware_utils)
186-
subprocess.run(["cp", args.platform_firmware_utils, output_dir])
186+
shutil.copy(args.platform_firmware_utils, output_dir)
187187
if args.firmware_utils is not None:
188188
flashbundle_contents += "\n" + os.path.basename(args.firmware_utils)
189-
subprocess.run(["cp", args.firmware_utils, output_dir])
189+
shutil.copy(args.firmware_utils, output_dir)
190190

191191
# Create the flashbundle file.
192192
try:

0 commit comments

Comments
 (0)