Skip to content

Commit 688fce2

Browse files
committed
integrate comments
1 parent d541b85 commit 688fce2

File tree

2 files changed

+10
-50
lines changed

2 files changed

+10
-50
lines changed

src/lib/dnssd/minimal_mdns/core/tests/TestQName.cpp

+9-9
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ TEST (TestQName, IteratorTest)
4646
SerializedQNameIterator it = AsSerializedQName(kOneItem);
4747

4848
EXPECT_TRUE(it.Next());
49-
EXPECT_FALSE(strcmp(it.Value(), "test"));
49+
EXPECT_STREQ(it.Value(), "test");
5050
EXPECT_FALSE(it.Next());
5151
EXPECT_TRUE(it.IsValid());
5252
}
@@ -56,16 +56,16 @@ TEST (TestQName, IteratorTest)
5656
SerializedQNameIterator it = AsSerializedQName(kManyItems);
5757

5858
EXPECT_TRUE(it.Next());
59-
EXPECT_FALSE(strcmp(it.Value(), "this"));
59+
EXPECT_STREQ(it.Value(), "this");
6060

6161
EXPECT_TRUE(it.Next());
62-
EXPECT_FALSE(strcmp(it.Value(), "is"));
62+
EXPECT_STREQ(it.Value(), "is");
6363

6464
EXPECT_TRUE(it.Next());
65-
EXPECT_FALSE(strcmp(it.Value(), "a"));
65+
EXPECT_STREQ(it.Value(), "a");
6666

6767
EXPECT_TRUE(it.Next());
68-
EXPECT_FALSE(strcmp(it.Value(), "test"));
68+
EXPECT_STREQ(it.Value(), "test");
6969

7070
EXPECT_FALSE(it.Next());
7171
EXPECT_TRUE(it.IsValid());
@@ -75,16 +75,16 @@ TEST (TestQName, IteratorTest)
7575
SerializedQNameIterator it(BytesRange(kPtrItems, kPtrItems + sizeof(kPtrItems)), kPtrItems + 14);
7676

7777
EXPECT_TRUE(it.Next());
78-
EXPECT_FALSE(strcmp(it.Value(), "this"));
78+
EXPECT_STREQ(it.Value(), "this");
7979

8080
EXPECT_TRUE(it.Next());
81-
EXPECT_FALSE(strcmp(it.Value(), "is"));
81+
EXPECT_STREQ(it.Value(), "is");
8282

8383
EXPECT_TRUE(it.Next());
84-
EXPECT_FALSE(strcmp(it.Value(), "a"));
84+
EXPECT_STREQ(it.Value(), "a");
8585

8686
EXPECT_TRUE(it.Next());
87-
EXPECT_FALSE(strcmp(it.Value(), "test"));
87+
EXPECT_STREQ(it.Value(), "test");
8888

8989
EXPECT_FALSE(it.Next());
9090
EXPECT_TRUE(it.IsValid());

src/lib/dnssd/minimal_mdns/core/tests/TestRecordWriter.cpp

+1-41
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,7 @@
1717
*/
1818

1919
#include <lib/dnssd/minimal_mdns/core/RecordWriter.h>
20-
//#include <lib/support/UnitTestRegistration.h>
2120

22-
//#include <nlunit-test.h>
2321
#include <gtest/gtest.h>
2422

2523
namespace {
@@ -28,7 +26,6 @@ using namespace mdns::Minimal;
2826
using namespace chip::Encoding::BigEndian;
2927

3028

31-
//void BasicWriteTest(nlTestSuite * inSuite, void * inContext)
3229
TEST (TestRecordWriter, BasicWriteTest)
3330
{
3431
const QNamePart kName1[] = { "some", "name" };
@@ -59,7 +56,6 @@ TEST (TestRecordWriter, BasicWriteTest)
5956
EXPECT_EQ(memcmp(dataBuffer, expectedOutput, sizeof(expectedOutput)), 0);
6057
}
6158

62-
//void SimpleDedup(nlTestSuite * inSuite, void * inContext)
6359
TEST (TestRecordWriter, SimpleDedup)
6460
{
6561
const QNamePart kName1[] = { "some", "name" };
@@ -88,7 +84,6 @@ TEST (TestRecordWriter, SimpleDedup)
8884
EXPECT_EQ(memcmp(dataBuffer, expectedOutput, sizeof(expectedOutput)), 0);
8985
}
9086

91-
//void ComplexDedup(nlTestSuite * inSuite, void * inContext)
9287
TEST (TestRecordWriter, ComplexDedup)
9388
{
9489
const QNamePart kName1[] = { "some", "name" };
@@ -134,7 +129,6 @@ TEST (TestRecordWriter, ComplexDedup)
134129
EXPECT_EQ(memcmp(dataBuffer, expectedOutput, sizeof(expectedOutput)), 0);
135130
}
136131

137-
//void TonsOfReferences(nlTestSuite * inSuite, void * inContext)
138132
TEST (TestRecordWriter, TonsOfReferences)
139133
{
140134
const QNamePart kName1[] = { "some", "name" };
@@ -169,38 +163,4 @@ TEST (TestRecordWriter, TonsOfReferences)
169163
EXPECT_EQ(output.Needed(), size_t(423));
170164
}
171165

172-
} // namespace
173-
174-
// clang-format off
175-
176-
/* static const nlTest sTests[] =
177-
{
178-
NL_TEST_DEF("BasicWriteTest", BasicWriteTest),
179-
NL_TEST_DEF("SimpleDedup", SimpleDedup),
180-
NL_TEST_DEF("ComplexDedup", ComplexDedup),
181-
NL_TEST_DEF("TonsOfReferences", TonsOfReferences),
182-
183-
NL_TEST_SENTINEL()
184-
}; */
185-
186-
// clang-format on
187-
/*
188-
int TestRecordWriter()
189-
{
190-
// clang-format off
191-
nlTestSuite theSuite =
192-
{
193-
"RecordWriter",
194-
&sTests[0],
195-
nullptr,
196-
nullptr
197-
};
198-
// clang-format on
199-
200-
nlTestRunner(&theSuite, nullptr);
201-
202-
return (nlTestRunnerStats(&theSuite));
203-
}*/
204-
/*
205-
CHIP_REGISTER_TEST_SUITE(TestRecordWriter)
206-
*/
166+
} // namespace

0 commit comments

Comments
 (0)