Merge branch 'server_cluster_registry' of github.com:andy31415/connectedhomeip into server_cluster_registry

Author: andreilitvin

src/app/server-cluster/ServerClusterInterface.h

@@ -44,7 +44,7 @@ class ServerClusterInterface
 
     ///////////////////////////////////// Cluster Metadata Support //////////////////////////////////////////////////
 
-    /// The path where this cluster operates on.
+    /// The path to this cluster instance.
     ///
     /// This path (endpointid,clusterid) is expected to be fixed once the server
     /// cluster interface is in use.

src/data-model-providers/codegen/ServerClusterInterfaceRegistry.cpp

@@ -83,7 +83,7 @@ ServerClusterInterface * ServerClusterInterfaceRegistry::Unregister(const Concre
                 mCachedInterface = nullptr;
             }
 
-            current->next = nullptr; // some clearing
+            current->next = nullptr; // Make sure current does not look like part of a list.
             return current->serverClusterInterface;
         }
 
@@ -121,7 +121,7 @@ void ServerClusterInterfaceRegistry::UnregisterAllFromEndpoint(EndpointId endpoi
                 prev->next = current->next;
             }
             ServerClusterRegistration * actual_next = current->next;
-            current->next                           = nullptr; // some clearing
+            current->next                           = nullptr; // Make sure current does not look like part of a list.
             current                                 = actual_next;
         }
         else

src/data-model-providers/codegen/ServerClusterInterfaceRegistry.h

@@ -31,14 +31,13 @@ namespace app {
 struct ServerClusterRegistration
 {
     // A single-linked list of clusters registered for the given `endpointId`
-    ServerClusterInterface * serverClusterInterface;
+    ServerClusterInterface * const serverClusterInterface;
     ServerClusterRegistration * next;
 
     constexpr ServerClusterRegistration(ServerClusterInterface &interface, ServerClusterRegistration * next_item = nullptr) :
         serverClusterInterface(&interface), next(next_item)
     {}
     ServerClusterRegistration(ServerClusterRegistration &&other) = default;
-    ServerClusterRegistration& operator=(ServerClusterRegistration &&other) = default;
 
     // we generally do not want to allow copies as those may have different "next" entries.
     ServerClusterRegistration(const ServerClusterRegistration &other) = delete;
@@ -118,7 +117,7 @@ class ServerClusterInterfaceRegistry
 
     /// Provides a list of clusters that are registered for the given endpoint.
     ///
-    /// As ClustersList points inside the internal registrations of the registry,
+    /// ClustersList points inside the internal registrations of the registry, so
     /// the list is only valid as long as the registry is not modified.
     ClustersList ClustersOnEndpoint(EndpointId endpointId);