Updated AppContext, LoopbackMessagingContext, and UDPMessagingContext to serve as PW test fixture classes. (#34036)

* Modified MessagingContext and its subclasses as well as AppContext to reflect PW migration.

* Modifed all tests that use LoopbackMessagingContext or AppContext.  Moved LoopbackMessagingContext data to heap.

* Removed unneeded scope from call to parent setup/teardown

* Made some helper functions into class methods.

* Restyled by prettier-markdown

* Reverted TestICDManager back to using LoopbackMessagingContext

* fixing merge conflicts

* fixing merge conflicts

* Fixed duplicate code and missing semicolon

* Trying to update TestReadHandler_DataVersionFiltersTruncated

* Restyled by whitespace

* Restyled by clang-format

* fixed problem with the new TestReadHandler_DataVersionFiltersTruncated

* fix in tracing

* Changes to MessagingContext member variable initialization in response to code review

* Used std::unique_ptr for MessagingContext.mpData

---------

Co-authored-by: Restyled.io <commits@restyled.io>

Author: feasel0

docs/testing/unit_testing.md

@@ -218,8 +218,8 @@ your overriding function make sure to check `HasFailure()` and return if the
 parent function failed.
 
 If you don't override any of the setup/teardown functions, you can simply make a
-type alias: `using YourTestContext = Test::AppContextPW;` instead of defining
-your own text context class.
+type alias: `using YourTestContext = Test::AppContext;` instead of defining your
+own text context class.
 
 ## Best practices
 

src/app/icd/server/tests/TestICDManager.cpp

@@ -15,6 +15,8 @@
  *    See the License for the specific language governing permissions and
  *    limitations under the License.
  */
+#include <pw_unit_test/framework.h>
+
 #include <app/SubscriptionsInfoProvider.h>
 #include <app/TestEventTriggerDelegate.h>
 #include <app/icd/server/ICDConfigurationData.h>
@@ -24,7 +26,6 @@
 #include <app/icd/server/ICDStateObserver.h>
 #include <app/icd/server/tests/ICDConfigurationDataTestAccess.h>
 #include <crypto/DefaultSessionKeystore.h>
-#include <gtest/gtest.h>
 #include <lib/address_resolve/AddressResolve.h>
 #include <lib/core/DataModelTypes.h>
 #include <lib/core/NodeId.h>
@@ -124,18 +125,16 @@ class TestSubscriptionsInfoProvider : public SubscriptionsInfoProvider
     bool mHasPersistedSubscription = false;
 };
 
-System::Clock::Internal::MockClock * pMockClock          = nullptr;
-System::Clock::ClockBase * pRealClock                    = nullptr;
-chip::Test::LoopbackMessagingContext * pMessagingContext = nullptr;
+System::Clock::Internal::MockClock * pMockClock = nullptr;
+System::Clock::ClockBase * pRealClock           = nullptr;
 
 } // namespace
 
 namespace chip {
 namespace app {
 
-class TestICDManager : public ::testing::Test
+class TestICDManager : public Test::LoopbackMessagingContext
 {
-
 public:
     /*
      * Advance the test Mock clock time by the amout passed in argument
@@ -147,7 +146,7 @@ class TestICDManager : public ::testing::Test
     static void AdvanceClockAndRunEventLoop(Milliseconds64 time)
     {
         pMockClock->AdvanceMonotonic(time);
-        pMessagingContext->GetIOContext().DriveIO();
+        GetIOContext().DriveIO();
     }
 
     // Performs shared setup for all tests in the test suite
@@ -159,16 +158,12 @@ class TestICDManager : public ::testing::Test
             ASSERT_NE(pMockClock, nullptr);
         }
 
-        if (pMessagingContext == nullptr)
-        {
-            pMessagingContext = new LoopbackMessagingContext();
-            ASSERT_NE(pMessagingContext, nullptr);
-        }
+        LoopbackMessagingContext::SetUpTestSuite();
+        VerifyOrReturn(!HasFailure());
 
-        pMessagingContext->SetUpTestSuite();
         ASSERT_EQ(chip::DeviceLayer::PlatformMgr().InitChipStack(), CHIP_NO_ERROR);
 
-        DeviceLayer::SetSystemLayerForTesting(&(pMessagingContext->GetSystemLayer()));
+        DeviceLayer::SetSystemLayerForTesting(&GetSystemLayer());
         pRealClock = &SystemClock();
         Clock::Internal::SetSystemClockForTesting(pMockClock);
     }
@@ -180,39 +175,34 @@ class TestICDManager : public ::testing::Test
         DeviceLayer::SetSystemLayerForTesting(nullptr);
 
         DeviceLayer::PlatformMgr().Shutdown();
-        pMessagingContext->TearDownTestSuite();
+
+        LoopbackMessagingContext::TearDownTestSuite();
 
         if (pMockClock != nullptr)
         {
             delete pMockClock;
             pMockClock = nullptr;
         }
 
-        if (pMessagingContext != nullptr)
-        {
-            delete pMessagingContext;
-            pMessagingContext = nullptr;
-        }
-
         pRealClock = nullptr;
     }
 
     // Performs setup for each individual test in the test suite
     void SetUp() override
     {
-        pMessagingContext->SetUp();
+        LoopbackMessagingContext::SetUp();
+        VerifyOrReturn(!HasFailure());
 
         mICDStateObserver.ResetAll();
         mICDManager.RegisterObserver(&mICDStateObserver);
-        mICDManager.Init(&testStorage, &(pMessagingContext->GetFabricTable()), &mKeystore,
-                         &(pMessagingContext->GetExchangeManager()), &mSubInfoProvider);
+        mICDManager.Init(&testStorage, &GetFabricTable(), &mKeystore, &GetExchangeManager(), &mSubInfoProvider);
     }
 
     // Performs teardown for each individual test in the test suite
     void TearDown() override
     {
         mICDManager.Shutdown();
-        pMessagingContext->TearDown();
+        LoopbackMessagingContext::TearDown();
     }
 
     TestSessionKeystoreImpl mKeystore;
@@ -576,8 +566,7 @@ TEST_F(TestICDManager, TestICDCounter)
 
     // Shut down and reinit ICDManager to increment counter
     mICDManager.Shutdown();
-    mICDManager.Init(&(testStorage), &(pMessagingContext->GetFabricTable()), &(mKeystore),
-                     &(pMessagingContext->GetExchangeManager()), &(mSubInfoProvider));
+    mICDManager.Init(&(testStorage), &GetFabricTable(), &(mKeystore), &GetExchangeManager(), &(mSubInfoProvider));
     mICDManager.RegisterObserver(&(mICDStateObserver));
 
     EXPECT_EQ(counter + ICDConfigurationData::kICDCounterPersistenceIncrement,
@@ -982,8 +971,7 @@ TEST_F(TestICDManager, TestICDStateObserverOnICDModeChangeOnInit)
     // Shut down and reinit ICDManager - We should go to LIT mode since we have a registration
     mICDManager.Shutdown();
     mICDManager.RegisterObserver(&(mICDStateObserver));
-    mICDManager.Init(&testStorage, &(pMessagingContext->GetFabricTable()), &mKeystore, &(pMessagingContext->GetExchangeManager()),
-                     &mSubInfoProvider);
+    mICDManager.Init(&testStorage, &GetFabricTable(), &mKeystore, &GetExchangeManager(), &mSubInfoProvider);
 
     // We have a registration, transition to LIT mode
     EXPECT_TRUE(mICDStateObserver.mOnICDModeChangeCalled);